Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

2018-10-12 Thread Dmitry Markov
Hi Manajit, There is an inconsistency between the proposed implementation and Apple JDK: if the property applied to the dialog which does not have an owner on the build with your changes it appears as sheet, but on Apple JDK it appears as a window. I think every frame/dialog inside dispose() me

Re: OpenJdk11-28-EA JDialog hanging

2018-10-12 Thread Laurent Bourgès
Martin, The reproducer test works now on OpenJDK12 + 8204142.webrev.01 patch ! I also tested with 4 windows and it is OK. One minor bug that appears in my logs, it is certainly related to your fix as I never had that message on JDK8: Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumen

Re: OpenJdk11-28-EA JDialog hanging

2018-10-12 Thread Laurent Bourgès
Hi Martin, What an amazing effort ! I am very pleased that my (crazy) test triggered a very complicated case; I will try asap if it works with your new webrev. Thanks for your feedback and sharing your test. > > I've taken your suggestion of making the filter class final. In regards to > having a

Re: OpenJdk11-28-EA JDialog hanging

2018-10-12 Thread Martin Balao
Hi Laurent, Thanks for your feedback and sharing your test. I've taken your suggestion of making the filter class final. In regards to having a single instance of the filter class, it would have been a good idea but now we have some additional requirements you'll see below. I could reproduce you