Re: java.awt.* properties initialization?

2018-10-18 Thread Roger Riggs
Hi Phil, Thanks for filing the issues and clarifications. I agree that removal is a great option to reduce clutter and maintenance. I forgot to include 'sun.desktop' which seems to be only ever set to 'gnome' on linux and 'windows' on windows. Thanks, Roger On 10/18/2018 05:39 PM, Phil Rac

Re: java.awt.* properties initialization?

2018-10-18 Thread Phil Race
Adding 2d-dev .. as most of these are actually for 2D, not AWT, despite the names. I have bugs filed to get rid of these two 2D properties : https://bugs.openjdk.java.net/browse/JDK-8130264 : java.awt.printerjob https://bugs.openjdk.java.net/browse/JDK-8130266 : java.awt.graphicsenv Probably I

Re: [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

2018-10-18 Thread Phil Race
And +1 from me too. -phil. On 10/18/2018 01:30 PM, Magnus Ihse Bursie wrote: 18 okt. 2018 kl. 01:02 skrev Sergey Bylokhov : On 17/10/2018 13:59, Phil Race wrote: Everything in here - except the subject line - points to a completely unrelated bug + fix. I believe you meant : https://bugs.open

Re: [12] Review Request: 8212213 All tests for splashscreen stopped worked in jdk12b13

2018-10-18 Thread Magnus Ihse Bursie
> 18 okt. 2018 kl. 01:02 skrev Sergey Bylokhov : > >> On 17/10/2018 13:59, Phil Race wrote: >> Everything in here - except the subject line - points to a completely >> unrelated bug + fix. >> I believe you meant : >> https://bugs.openjdk.java.net/browse/JDK-8212213 >> http://cr.openjdk.java.net

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Laurent Bourgès
Martin & Sergey, Here are my test results on macOS New Sierra: $ uname -a Darwin 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64 $ source ~/Desktop/test-jdk11.sh openjdk version "11" 2018-09-25 OpenJDK Runtime Environment 18.

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Martin Balao
Yes, your results are exactly what I was expecting. On Thu, Oct 18, 2018 at 4:35 PM, Laurent Bourgès wrote: > Hi Martin, > > Here are my test outputs: > > 1/ First > $ java TestWinEvent > reject ID = 1200 : java.awt.event.InvocationEvent[INVOCATION_ > DEFAULT,runnable=javax.swing.RepaintManager$

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Laurent Bourgès
Hi Martin, Here are my test outputs: 1/ First $ java TestWinEvent reject ID = 1200 : java.awt.event.InvocationEvent[INVOCATION_DEFAULT,runnable=javax.swing.RepaintManager$ProcessingRunnable@28985415,notifier=null,catchExceptions=false,when=1539872732255] on sun.awt.X11.XToolkit@4645926f reject ID

java.awt.* properties initialization?

2018-10-18 Thread Roger Riggs
Hi, There are a few java.awt.* properties that have support in the system.c native code based on the operating system.   Most do not need to be in native code and decoupling the code would be a good cleanup. I'd like to look at the properties and move the initializations to a more appropriat

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Martin Balao
On Thu, Oct 18, 2018 at 3:58 PM, Laurent Bourgès wrote: > Hi Martin, > > PS: could you tell me what lines to change to discard non sequenced events >>> in your patch ? I will then try it >>> >> >> Instead of "if (ev.getID() == ID) { ... } return FilterAction.ACCEPT;", >> do: >> >> "if (ev.getID()

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Laurent Bourgès
Hi Martin, PS: could you tell me what lines to change to discard non sequenced events >> in your patch ? I will then try it >> > > Instead of "if (ev.getID() == ID) { ... } return FilterAction.ACCEPT;", do: > > "if (ev.getID() == ID) { ... } else if (ev.getID() == SentEvent.ID) { > return FilterA

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Martin Balao
On Thu, Oct 18, 2018 at 12:14 PM, Laurent Bourgès wrote: > > > PS: could you tell me what lines to change to discard non sequenced events > in your patch ? I will then try it > > Instead of "if (ev.getID() == ID) { ... } return FilterAction.ACCEPT;", do: "if (ev.getID() == ID) { ... } else if (e

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Laurent Bourgès
Martin, >> Have you tried Laurent's test case on Mac? (the version previous to my >>> refactorings, so we eliminate the OS layer). This bug should manifest there >>> too. Unfortunately, I don't have such environment to test and debug. >>> >> >> Yes, it is not reproduced on macos, at-least not so

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Krishna Addepalli
Hi Martin, As far as my experience goes(which is less), the usage of SequencedEvents is relatively rare, and rarer even to generate a high volume of SequencedEvents. So, I would be inclined to pursue the path of blocking the dispatch till the SequencedEvents are processed. Probably Sergey/Phil a

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Martin Balao
On Thu, Oct 18, 2018 at 11:05 AM, Laurent Bourgès wrote: > > > There is no shame that EDT or event processing consuming lots of cpu > cycles, in such intensive tests. > > That's not a problem, the problem is starvation of non-SequencedEvent events if the EDT is blocked-like rejecting them all. Eve

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Martin Balao
Hi Sergey, On Thu, Oct 18, 2018 at 3:35 AM, Sergey Bylokhov wrote: > On 17/10/2018 07:12, Martin Balao wrote: > >> Have you tried Laurent's test case on Mac? (the version previous to my >> refactorings, so we eliminate the OS layer). This bug should manifest there >> too. Unfortunately, I don't

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Laurent Bourgès
Hi Martin, If the behavior changed in your patch, it sounds more conservative to >> discard events (as before) if the present bug is still fixed. >> It could be revisited later in another appropriate bug. >> Is it a trivial change in your event filter ? I am looking forward trying >> this alternat

Re: OpenJdk11-28-EA JDialog hanging

2018-10-18 Thread Martin Balao
Hi Laurent, On Wed, Oct 17, 2018 at 8:13 PM, Laurent Bourgès wrote: > > If the behavior changed in your patch, it sounds more conservative to > discard events (as before) if the present bug is still fixed. > It could be revisited later in another appropriate bug. > Is it a trivial change in your