Re: OpenJdk11-28-EA JDialog hanging

Hi, Digging a bit into SequencedEvent event clients, I've found 3 usages: 1) Wrapping focus in and out window events (Unix only) 2) Wrapping TimedWindowEvent events (Windows and macOS only) 3) Wrapping FocusEvent events in XEmbedChildProxyPeer.simulateMotifRequestFocus (Unix only) This is how

Re: OpenJdk11-28-EA JDialog hanging

On Fri, Oct 26, 2018 at 6:59 PM, Sergey Bylokhov wrote: > On 25/10/2018 01:05, Laurent Bourgès wrote: > >> According to me, Martin already exposed his detailled analysis of 2 cases >> making AWT to hang with several AppContexts: in summary, like a deadlock, >> the EDT threads are waiting for each

Re: OpenJdk11-28-EA JDialog hanging

On 25/10/2018 01:05, Laurent Bourgès wrote: According to me, Martin already exposed his detailled analysis of 2 cases making AWT to hang with several AppContexts: in summary, like a deadlock, the EDT threads are waiting for each other to dispatch SequencedEvents ! If you are talking about an

Re: [12] Review Request: 8211435 Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source

Hi, Denis. Thank you for review, see my comments inline. the fix conceals other scenarios. Now if another fix breaks the activeWindow  field logic it can be unnoticed. Do not you think it is worth to distinguish  the field update on  per-AppContext basis instead? The activeWindow field logic is

Re: OpenJdk11-28-EA JDialog hanging

Hi guys, just out of curiosity, should not we store the SE lists per-AppContext? Thank you, Denis On Fri, Oct 26, 2018 at 1:35 AM Krishna Addepalli < krishna.addepa...@oracle.com> wrote: > Hi Sergey, > > I also agree with Laurent about root cause of hang provided by Martin. > However, we jus

Re: [12] Review Request: 8211435 Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source

Hi Sergey, the fix conceals other scenarios. Now if another fix breaks the activeWindow field logic it can be unnoticed. Do not you think it is worth to distinguish the field update on per-AppContext basis instead? Thank you, Denis On Fri, Oct 26, 2018 at 3:33 AM Krishna Addepalli < krishna

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

Hi Manajit, Looks good to me. Thanks, Dmitry > On 26 Oct 2018, at 11:02, Manajit Halder wrote: > > Hi Dmitry, > > I have corrected the test case, now it fails if timeout takes place. Please > review the webrev: > http://cr.openjdk.java.net/~mhalder/8208543/webrev.02/ >

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

Hi Dmitry, I have corrected the test case, now it fails if timeout takes place. Please review the webrev: http://cr.openjdk.java.net/~mhalder/8208543/webrev.02/ Regards, Manajit On 25/10/18 7:18 PM, Dmitry Markov wrote: Hi Manajit