Re: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

Hi, Toshio. Can you please add the steps to reproduce to the bug description. On 06/11/2018 01:19, Toshio 5 Nakamura wrote: Hello, Can I obtain a sponsor of this proposal about InputMethod issue on Linux? Bug: https://bugs.openjdk.java.net/browse/JDK-8213183 Webrev: http://cr.openjdk.java.net

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

On 07/11/2018 23:18, Shashidhara Veerabhadraiah wrote: From the usability perspective of a disabled person, I don't think one would know use the Ctrl+option+shift kind of traversal and they would definitely prefer to be same across the platforms. i.e., TAB key traversals(just the important vi

Re: Proposal: getGTKIcon with Unicode chars got StringIndexOutOfBoundsException

Hi, Ichiroh. The changes looks good, i think that the test from the bug description can be integrated as well. Note that, src/java.desktop/unix/native/libawt_xawt/awt/swing_GTKEngine.c has same kind of code. But buffer handling is not same, so I could not determine, I need to change swing_GTKE

Re: RFR 8186549: move ExtendedRobot closer to tests

Looks fine. On 08/11/2018 15:23, Alexandre (Shura) Iline wrote: I have updated the web rev accordingly: http://cr.openjdk.java.net/~shurailine/8186549/webrev.01/test/jdk/java/awt/Modal/ModalBlockingTests/BlockingDFSetModalTest.java.sdiff.html Let me know if there are other concerns. Shura O

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Looks fine. On 09/11/2018 03:31, Jayathirth D V wrote: Hi Sergey, I have made changes to specifically use RGB channel for Jpeg and ARGB for all others. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8176556/webrev.03/ In DataTransferer. imageToStandardBytesImpl(), Jpe

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Hi, Krishna. The closed tag "" is optional and might be omitted, it was dropped in most of our specifications. BTW I think that in most cases in this specs the style "align=" for the table can be dropped as well and some default could be used. On 09/11/2018 04:34, Krishna Addepalli wrote: Hi

Re: RFR 8213532: add missing LocalFree calls after using FormatMessage(A) [windows] - was RE: FW: RFR [XS] : 8213366: (fs) avoid handle leak in Java_sun_nio_fs_WindowsNativeDispatcher_FindFi

Looks fine. On 08/11/2018 08:20, Baesken, Matthias wrote: Hello, looks like I used the wrong DTRACE_PRINTLN* call at one place in src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp . New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8213532.1/ Regards, Matthias -O

Re: [12] RFR JDK-8213536: Update ProblemList.txt for Linux

Looks fine. On 08/11/2018 12:33, Pankaj Bansal wrote: Hello Sergey, Thanks for the review. << Can you please update all old bugs with a comment that the test can fail on linux(ubuntu/oel) and attach the log files to the bug. Done. Please have a look.

Re: OpenJdk11-28-EA JDialog hanging

On Fri, Nov 9, 2018 at 10:50 AM, Laurent Bourgès wrote: > > I suppose the Webrev.04 only removed the SequencedEventTest class ? > That's right

Re: OpenJdk11-28-EA JDialog hanging

Dear Martin & Sergey, I just tested webrev.03 on latest openjdk12 and it passed my tests: good job ! (I am not an official openjdk reviewer) Le ven. 9 nov. 2018 à 14:43, Martin Balao a écrit : > Hi, > > Here we have Webrev.04: > > * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.we

Re: OpenJdk11-28-EA JDialog hanging

Hi, Here we have Webrev.04: * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.04/ * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.04.zip @Sergey: are you okay to go? Thanks, Martin.- On Thu, Nov 8, 2018 at 9:09 PM, Sergey Bylokhov wrote: > I am fine wit

Re: [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows

Thanks for the review Sergey & Krishna, I shall remove the wild card imports and check in the change. Regards, Ambarish -Original Message- From: Krishna Addepalli Sent: Friday, November 09, 2018 5:08 PM To: Sergey Bylokhov ; Ambarish Rapte ; awt-dev@openjdk.java.net Subject: RE: [12] R

[12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Hi All, Please review a simple fix for updating html attributes to use CSS style options to comply with HTML5. JDK-8213048: https://bugs.openjdk.java.net/browse/JDK-8213048 Webrev: http://cr.openjdk.java.net/~kaddepalli/8213048/webrev00/ Thanks, Krishna

RFR: 8213614 DnD operation change feature does not work with 64bit big endian CPU

Hello, IBM would like to contribute this patch to OpenJDK project. Bug:https://bugs.openjdk.java.net/browse/JDK-8213614 Change: https://cr.openjdk.java.net/~itakiguchi/8213614/webrev.00/ Issue: This issue only happens on 64bit big endian CPU. Keyboard's key data is 32bit, but current code pi

Re: [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows

Hi Ambarish, Looks fine to me as well. Could you also remove the wildcard imports in the test? I don't need to see a new webrev - just do the changes and push it. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, November 8, 2018 10:41 PM To: Ambarish Rapte ; awt

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hi Sergey, I have made changes to specifically use RGB channel for Jpeg and ARGB for all others. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8176556/webrev.03/ In DataTransferer. imageToStandardBytesImpl(), JpegImageWriterSpi.canEncodeImage() returns false. And since