RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.00/ This issue is related by wrong usage of XNPreeditState on XSetICValues(). Because of wrong usage, UnsupportedOperationException exceptio

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

Fair enough, that warning is enough. You don't need to add anything else. I'm ok with the patch. /Magnus > 3 dec. 2018 kl. 20:37 skrev Sergey Bylokhov : > > Hi, Magnus. > >> This looks good to me too, but as I said before, I still think you should >> write a note about this change in UPDATIN

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

Hi, Magnus. This looks good to me too, but as I said before, I still think you should write a note about this change in UPDATING.txt, so this fix is not lost if pnglibconf.h were to be re-generated. All lines which started by "/*#undef " in the "pnglibconf.h" are commented manually and this

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Krishna, Sure I will check it once again tomorrow for the logger file extension as I am not able to get the JAWS license from home network. Another problem that I see is that the way we use the environment variable. We need to set the flag pointing to a single text file it will end up in crea

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Shashi, 1. It is strange that the Windows Log file did not have any extension and the Java log file had an extension. The code for reading the environment variable content and creating the appropriate file is common between JavaAccessBridge.dll and WindowsAccessBridge.dll, so if one is able

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Shashi, Sergey's question was whether the change in progress bar state is announced by VO or not while the text is loading. So you click the button to start text loading and then move VO selection to progress bar. It should announce the current state and, as I understand, announce progres

Re: RFR: 8211267: StackOverflowError happened by TextField.setFont(...) & Add non interactive test case for JDK-8211267

Hello. Thanks, Sergey. I created new test case for JDK-8214298. I merged JDK-8211267 & JDK-8214298. I removed interactive test case and added JDK-8214298's code. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211267 Change: https://cr.openjdk.java.net/~itakiguchi/