[12] Review Request: 8215200 IllegalArgumentException in sun.lwawt.macosx.CPlatformWindow

2018-12-13 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8215200 Webrev: http://cr.openjdk.java.net/~serb/8215200/webrev.00 In the fix for JDK-8190230 we started to sort the list of owned windows to maintain their z-order. But there is a small issue in the compactor

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

2018-12-13 Thread Krishna Addepalli
Thanks for the review Sergey! -Original Message- From: Sergey Bylokhov Sent: Friday, December 14, 2018 10:07 AM To: Krishna Addepalli Cc: Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net; Prasanta Sadhukhan Subject: Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

2018-12-13 Thread Sergey Bylokhov
Looks fine. > 2. I made all the declarations auto. Here is the new webrev: > http://cr.openjdk.java.net/~kaddepalli/8196681/webrev09 -- Best regards, Sergey.

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

2018-12-13 Thread Krishna Addepalli
Hi Sergey, I hope that your query is answered. Could you review the new webrev and approve it? Thanks, Krishna -Original Message- From: Krishna Addepalli Sent: Tuesday, December 11, 2018 5:14 PM To: Sergey Bylokhov ; Shashidhara Veerabhadraiah Cc: Prasanta Sadhukhan ; awt-dev@openjdk

Re: [OpenJDK 2D-Dev] RFR: JDK-8215296 do not disable c99 on Solaris

2018-12-13 Thread Phil Race
On 12/13/18 10:07 AM, Erik Joelsson wrote:  * These macros only have an effect if the operating system supports either  * POSIX 1003.1 or C99, or both.  On other operating systems (particularly  * Windows/Visual Studio) there is no effect; the OS specific tests below are  * still required (

Re: RFR: JDK-8215296 do not disable c99 on Solaris

2018-12-13 Thread Erik Joelsson
On 2018-12-13 02:11, Magnus Ihse Bursie wrote: -D_XPG6 ?? To be honest, I'm not completely sure about this. Without this define, the build failed with the following error message: Compiler or options invalid for pre-UNIX 03 X/Open applications and pre-2001 POSIX applications This was tri

Re: RFR: JDK-8215296 do not disable c99 on Solaris

2018-12-13 Thread Magnus Ihse Bursie
On 2018-12-12 23:17, David Holmes wrote: Hi Magnus, What did -Xa do? I believe Kim has answered this satisfactory. Do AWT folk need to check this. I'm adding awt and 2d lists to this review. I find it hard to understand the connection between: I'm not sure there is a connection..? It's t