Re: RFR: [OpenJDK 2D-Dev] JDK-8215296 do not disable c99 on Solaris

2018-12-19 Thread David Holmes
On 20/12/2018 1:31 am, Baesken, Matthias wrote: Sounds like a simpler change, at least for now. Does it pass jdk-submit? Hello Magnus , pushed it to jdk/submit , however I do not expect much info from it because David told me Solaris is not tested there I was incorrect. (and the

Re: RFR: [OpenJDK 2D-Dev] JDK-8215296 do not disable c99 on Solaris

2018-12-19 Thread David Holmes
Correction: jdk-submit does test Solaris. David On 18/12/2018 8:02 am, David Holmes wrote: Hi Matthias, On 17/12/2018 11:12 pm, Baesken, Matthias wrote: Hello,  please review http://cr.openjdk.java.net/~mbaesken/webrevs/8215296.0/ in my change just -xc99=%none  is removed, so we do not for

Re: RFR: [OpenJDK 2D-Dev] JDK-8215296 do not disable c99 on Solaris

2018-12-19 Thread Baesken, Matthias
> > Sounds like a simpler change, at least for now. Does it pass jdk-submit? > Hello Magnus , pushed it to jdk/submit , however I do not expect much info from it because David told me Solaris is not tested there (and the other platforms are not affected by my path). However David tested

Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2018-12-19 Thread Krishna Addepalli
Hi Sergey,   The changes look fine to me.   Thanks, Krishna Subject: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms Date: Thu, 6 Dec 2018 09:26:06 -0800 From: Sergey Bylokhov HYPERLINK "mailto:sergey.bylok