Hi Krishna, Thank you for the review.
Thanks and regards,
Shashi
From: Krishna Addepalli
Sent: Thursday, January 3, 2019 8:22 PM
To: Shashidhara Veerabhadraiah ;
awt-dev@openjdk.java.net; swing-...@openjdk.java.net
Subject: RE: [13] JDK-8216008:
-Djavax.accessibility.assistive_technolo
Hi, Shashi.
I think you can update an existing test:
open/test/jdk/javax/accessibility/AccessibilityProvider/basic.sh
On 03/01/2019 01:36, Shashidhara Veerabhadraiah wrote:
Hi All, Please review a fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8216008
Webrev: http://cr.op
+1
On 03/01/2019 07:18, Alexey Ivanov wrote:
Hi Krishna,
On 03/01/2019 05:40, Krishna Addepalli wrote:
Hi Alexey,
Thank you for the suggestion. Here is the new webrev:
http://cr.openjdk.java.net/~kaddepalli/8215910/webrev01/
This version looks good to me.
I'm not a reviewer though, so you
On 03/01/2019 17:25, Krishna Addepalli wrote:
Thank you Alexey. I understood that the second Runnable was not needed, hence I
made changes.
So, I believe you are endorsing webrev01 right?
Right.
I've replied to that mail message to make it clear.
Thanks
Krishna
--
Regards,
Alexey
Hi Krishna,
On 03/01/2019 05:40, Krishna Addepalli wrote:
Hi Alexey,
Thank you for the suggestion. Here is the new webrev:
http://cr.openjdk.java.net/~kaddepalli/8215910/webrev01/
This version looks good to me.
I'm not a reviewer though, so you'll need someone else's okay too.
Regards,
Al
+1
Thanks,
Krishna
From: Shashidhara Veerabhadraiah
Sent: Thursday, January 3, 2019 3:06 PM
To: awt-dev@openjdk.java.net; swing-...@openjdk.java.net
Subject: [13] JDK-8216008:
-Djavax.accessibility.assistive_technologies empty list leads to crash
Hi All, Please review a fix for the
Thank you Alexey. I understood that the second Runnable was not needed, hence I
made changes.
So, I believe you are endorsing webrev01 right?
Thanks
Krishna
-Original Message-
From: Alexey Ivanov
Sent: Thursday, January 3, 2019 3:14 PM
To: Krishna Addepalli ; awt-dev
Subject: Re: [13
Hi Krishna,
On 31/12/2018 16:09, Alexey Ivanov wrote:
Hi Krishna,
But the bug hasn't been fixed yet:
Sorry I might have sounded rude. I didn't intend to.
- 230 * @param listener The {@code Runnable}Runnable whose
+ 230 * @param listener The {@code Runnable} Runna
Hi All, Please review a fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8216008
Webrev: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.00/
Since the mentioned list of assistive technologies for the system
property(javax.accessibility.assistive_technologies
Hi Sergey,
Still looks good.
Thanks,
Dmitry
> On 3 Jan 2019, at 01:32, Sergey Bylokhov wrote:
>
> Hi, Dmitry.
> Can you please review a simplified version of the fix.
>
> The "javaPlatformWindow" is declared in AWTWindow.h this way:
> @property (nonatomic, retain) JNFWeakJObjectWrapper *jav
10 matches
Mail list logo