Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-16 Thread shashidhara . veerabhadraiah
Another point is that the whitespace trimming should not trigger additional input processing  for the custom class that will be used for assistive technology. For eg., if custom class "FooProvider" is implemented and if we pass "  FooProvider  " by mistake, a bug may be created to trim the whit

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-16 Thread Shashidhara Veerabhadraiah
We need one way to tell the system not to load any assistive technologies and which is being provided. If we add trailing white spaces removal then we may need to add another functionality to see if that class exists or not and based on that not to load anything(without throwing the error becau

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-16 Thread Sergey Bylokhov
I guess you meant whitespaces, then it is unclear why we should not consider "empty" parameter as a "mistake"? On 15/01/2019 20:37, Shashidhara Veerabhadraiah wrote: Hi Sergey, I felt that a string with an empty space is intentional and should be considering it as a 'mistake' if done by the de

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

2019-01-16 Thread Sergey Bylokhov
On 16/01/2019 09:59, Krishna Addepalli wrote: Hi Sergey, I checked the code, by putting logs and can confirm that an event is not generated even if the same is reselected. I have updated the test case to reflect this fact, so here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8215

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

2019-01-16 Thread Krishna Addepalli
Hi Sergey, I checked the code, by putting logs and can confirm that an event is not generated even if the same is reselected. I have updated the test case to reflect this fact, so here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev01/

Re: [12] Review request for JDK-8215280: Double click on titlebar not working for Frame with extended state set to MAXIMIZED_BOTH

2019-01-16 Thread Krishna Addepalli
+1 -Original Message- From: Sergey Bylokhov Sent: Tuesday, January 15, 2019 7:19 AM To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8215280: Double click on titlebar not working for Frame with extended state set to MAXIMIZED_BOTH Looks fine.

Re: RFR: 8212678 Windows IME related patch

2019-01-16 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212678 Change: https://cr.openjdk.java.net/~itakiguchi/8212678/webrev.01/ 3 issues were combined. 2 issues are recreatable on English Windows. Screen shots and movies are attached into JDK-8212678. Please check