So the code changes are OK if this is the direction but you pointed
yourself to where
the existing behaviour was documented, so if that documentation page
exists still for
current releases, it seems it needs to be updated, and if not you should
do a release note for this change.
-phil.
On 12/
On 23/01/2019 14:00, Philip Race wrote:
Do you mean that the test may be showing up a problem on macos ?
The fix does not affect the macOS, but the test does not
check the usecase which it is supposed to verify.
-phil.
On 1/23/19, 1:43 PM, Sergey Bylokhov wrote:
Hi, Krishna.
I tried a new
The fix is in X11 code .. how can it affect Mac ?
Do you mean that the test may be showing up a problem on macos ?
-phil.
On 1/23/19, 1:43 PM, Sergey Bylokhov wrote:
Hi, Krishna.
I tried a new version of the fix on macOS, and looks
like the second click is never success, the test always
fails
Hi, Krishna.
I tried a new version of the fix on macOS, and looks
like the second click is never success, the test always
fails to open the list of items and as a result clicked
on the desktop instead of the same element in the list.
On 23/01/2019 09:33, Phil Race wrote:
This looks OK so long a
This looks OK so long as you can confirm that you re-tested all related
tests, not
just your regression test after making the source code update ...
-phil.
On 1/21/19 5:00 AM, Krishna Addepalli wrote:
Hi Sergey,
I have modified the test as you suggested. Here is the new webrev:
http://cr.ope
Hello.
Could you review the fix and give me your suggestion ?
Thanks,
Ichiroh Takiguchi
On 2019-01-16 20:13, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8212678
Change: https://cr.openjdk.java.net/~itakiguchi/8212678/webrev.01/