Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

2019-02-28 Thread Krishna Addepalli
Hi Sergey Malenkov, Thank you for pointing this out. This issue is also reported in JDK-8218917. I’m looking into the issue. Thanks, Krishna > On 01-Mar-2019, at 2:45 AM, Sergey Bylokhov > wrote: > > Hi, Sergey. > > Do you have bugid for this issue? > > On 28/02/2019 09:35, Sergey Malenkov

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

2019-02-28 Thread Sergey Bylokhov
Hi, Sergey. Do you have bugid for this issue? On 28/02/2019 09:35, Sergey Malenkov wrote: The following change fixes the critical problem for us, but I do not like this solution. I think that leftAltKeyPressed and altGRPressed should be more consistent. Index: src/java.desktop/macosx/nati

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

2019-02-28 Thread Sergey Malenkov
The following change fixes the critical problem for us, but I do not like this solution. I think that leftAltKeyPressed and altGRPressed should be more consistent. Index: src/java.desktop/macosx/native/libawt_lwawt/awt/AWTEvent.m IDEA additional info: Subsystem: com.intellij.openapi.diff.impl

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

2019-02-28 Thread Sergey Malenkov
ATTENTION! This old fix breaks Java UI 11 on macOS Mojave. If you press RightAlt once, you never receive event with LeftAlt. Note that static altGRPressed = NO is switched to YES, but never to NO. Could you please improve your fix and add a test that Alt-events are not changed after pressing/rele