Re: [12] JDK-8182043: Access to Windows Large Icons

2019-03-01 Thread Phil Race
Alexey, We already nixed this approach See https://mail.openjdk.java.net/pipermail/awt-dev/2019-January/014972.html Shashi is re-thinking it to use MultiResolutionImage. -phil. On 3/1/19 12:25 PM, Alexey Ivanov wrote: Hi Shashi, Sorry for my belated review. On 22/01/2019 18:03, Shashidhara

Re: [12] JDK-8182043: Access to Windows Large Icons

2019-03-01 Thread Alexey Ivanov
Hi Shashi, Sorry for my belated review. On 22/01/2019 18:03, Shashidhara Veerabhadraiah wrote: Hi All, Please review the below new fix compared to earlier webrevs. Now the new api to get the icons of different sizes is being made part of a new class SystemIcon. Please consider this as a diff

Re: RFR: 8212676 AIX's CDE/MWM support

2019-03-01 Thread Ichiroh Takiguchi
Hello. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.01/ I applied following changes: * I added AIX detection code into sun.awt.OSInfo class. It seems CDE's default should be middle colo

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

2019-03-01 Thread Sergey Malenkov
Hello, Sergey! > Do you have bugid for this issue? Not yet. I'll file an issue soon. Regards, SAM On Fri, Mar 1, 2019 at 12:15 AM Sergey Bylokhov wrote: > > Hi, Sergey. > > Do you have bugid for this issue? > > On 28/02/2019 09:35, Sergey Malenkov wrote: > > The following change fixes the criti