Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Thanks for the review Sergey! Need one more reviewer. > On 11-Apr-2019, at 7:40 AM, Sergey Bylokhov > wrote: > > On 10/04/2019 07:51, Krishna Addepalli wrote: >> Hi Sergey Bylokhov/Phil/Prasanta/Jay, >> Could you review the fix for this issue? Here is the webrev: >> http://cr.openjdk.java.ne

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

Hi, Denis. So probably current implementation under discussion can be dropped and replaced by the swing dialog-based? On 31/10/2018 03:08, Denis Fokin wrote: Hi Manajit, Sergey, we use a swing dialog-based implementation in our product. I believe the current terms and behaviour could be impr

Re: creating an ActionEvent with modifiers from an InputEvent

Hi, Alan. That sounds promising, but there are backward compatibility issues. Can you be more specific? I think that on some platforms we already set the InputEvent.modifiers when we create the ActionEvent, so the mask in such ActionEvent contains bits related to both: InputEvent and Action

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

Hi, Ichiroh. Why the fix uses the "defined(MACOSX)" in a few places? I assume this code is never executed on macOS. Should we update the aix version as well? .../java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c On 25/03/2019 09:28, Ichiroh Takiguchi wrote: Hello. Could you review the

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

On 10/04/2019 07:51, Krishna Addepalli wrote: Hi Sergey Bylokhov/Phil/Prasanta/Jay, Could you review the fix for this issue? Here is the webrev: http://cr.openjdk.java.net/~kaddepalli/8218917/webrev00/ Looks fine. -- Best regards, Sergey.

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Hi Sergey Bylokhov/Phil/Prasanta/Jay, Could you review the fix for this issue? Here is the webrev: http://cr.openjdk.java.net/~kaddepalli/8218917/webrev00/ @Sergey Malenkov, I have raised a new bug JDK-879: https://bugs.openjdk.jav