Re: [PATCH] Fix some C++ conformance issues in AWT Windows code

2019-05-28 Thread Philip Race
PS the changes look fine to me. -phil On 5/28/19, 2:16 PM, Philip Race wrote: Andrew's name is on the list already. -phil. On 5/28/19, 2:04 PM, Sergey Bylokhov wrote: Hi, Andrew. Thank you for the patch! We would be glad to accept patches from you. However, you will need to sign an OCA befo

Re: [PATCH] Fix some C++ conformance issues in AWT Windows code

2019-05-28 Thread Philip Race
Andrew's name is on the list already. -phil. On 5/28/19, 2:04 PM, Sergey Bylokhov wrote: Hi, Andrew. Thank you for the patch! We would be glad to accept patches from you. However, you will need to sign an OCA before we can do that: https://www.oracle.com/technetwork/community/oca-486395.html

Re: [PATCH] Fix some C++ conformance issues in AWT Windows code

2019-05-28 Thread Sergey Bylokhov
Hi, Andrew. Thank you for the patch! We would be glad to accept patches from you. However, you will need to sign an OCA before we can do that: https://www.oracle.com/technetwork/community/oca-486395.html On 28/05/2019 13:52, Andrew Luo wrote: Adding an updated patch.  It seems I missed a file.

Re: [PATCH] Fix some C++ conformance issues in AWT Windows code

2019-05-28 Thread Andrew Luo
Adding an updated patch. It seems I missed a file. Testing done: compiled with both /permissive- set and without. Thanks, -Andrew From: awt-dev On Behalf Of Andrew Luo Sent: Monday, May 13, 2019 5:40 PM To: awt-dev@openjdk.java.net Subject: [PATCH] Fix some C++ conformance issues in AWT Wind

Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64

2019-05-28 Thread Jayathirth D V
+1 Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 4:19 PM To: Jayathirth D V; awt-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64 Thanks

Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64

2019-05-28 Thread Prasanta Sadhukhan
Thanks Jay for review. I added it for safety but it seems it is not needed, only the 2nd one is needed. Test still pass with only the 2nd one...So, modified webrev http://cr.openjdk.java.net/~psadhukhan/8224821/webrev.1/ Regards Prasanta On 28-May-19 3:30 PM, Jayathirth D V wrote: Hi Prasanta

Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64

2019-05-28 Thread Jayathirth D V
+1 Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 4:16 PM To: Jayathirth D V; awt-dev@openjdk.java.net Subject: Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64 Thanks J

Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64

2019-05-28 Thread Prasanta Sadhukhan
Thanks Jay for review. I have also added the delay between press/release. Modified webrev http://cr.openjdk.java.net/~psadhukhan/8224830/webrev.1/ Regards Prasanta On 28-May-19 3:38 PM, Jayathirth D V wrote: Hi Prasanta, Changes are fine. Also its better to add delay between input events like

Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64

2019-05-28 Thread Jayathirth D V
Hi Prasanta, Changes are fine. Also its better to add delay between input events like Press & release. Or you can set auto delay on robot. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 2:46 PM To: awt-dev@openjdk.java.net Subject: Re: [13] RFR 82

Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64

2019-05-28 Thread Jayathirth D V
Hi Prasanta, We are already waiting for 2 secs in Util.focusComponent(), do we need the first delay of 2 secs just before that? Second robot.delay() is okay. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Tuesday, May 28, 2019 2:47 PM To: awt-dev@openjdk.java.net Subject

Re: [13] RFR JDK-8224821: java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java fails linux-x64

2019-05-28 Thread Prasanta Sadhukhan
PS: Modified test pass on windows,linux headful mach5 systems, on mac it is problemlisted already. Regards Prasanta On 27-May-19 2:39 PM, Prasanta Sadhukhan wrote: Hi All, Please review a test fix for an issue where it seems focus does not transfer automatically in some case in our headful n

Re: [13] RFR 8224830:test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java fails on linux-x64

2019-05-28 Thread Prasanta Sadhukhan
PS: Modified test pass on windows,linux,mac headful mach5 systems Regards Prasanta On 27-May-19 4:20 PM, Prasanta Sadhukhan wrote: Hi All, Please review a test fix for an issue where it is seen that button click actionlistener was not called leading to an exception. Issue seems to arise from