Re: [8u] RFR 8153732: Windows remote printer changes do not reflect in lookupPrintServices()

2019-06-04 Thread Andrew John Hughes
On 04/06/2019 16:08, Zhengyu Gu wrote: > Ping! > > Thanks, > > -Zhengyu > > On 5/28/19 9:03 AM, Zhengyu Gu wrote: >> Hi, >> >> Could you please review this 8u backport? After JDK-8055705 backport, >> the original patch still does not apply cleanly, due to missing >> following Thread API in JDK

RFR. Repeated words typos in java.desktop

2019-06-04 Thread Andrey Turbanov
Hello. I would like to contribute small patch to fix repeated words typos. Andrey Turbanov diff --git a/src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameManager.java b/src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameManager.java index c2ce10b0e4a..ccd65105699 100644

Re: [8u] RFR 8153732: Windows remote printer changes do not reflect in lookupPrintServices()

2019-06-04 Thread Zhengyu Gu
Hi, Could you please review this 8u backport? After JDK-8055705 backport, the original patch still does not apply cleanly, due to missing following Thread API in JDK8u. public Thread​(ThreadGroup group, Runnable target, String name, long stackSize,

Re: [8u] RFR 8153732: Windows remote printer changes do not reflect in lookupPrintServices()

2019-06-04 Thread Zhengyu Gu
Ping! Thanks, -Zhengyu On 5/28/19 9:03 AM, Zhengyu Gu wrote: Hi, Could you please review this 8u backport? After JDK-8055705 backport, the original patch still does not apply cleanly, due to missing following Thread API in JDK8u. public Thread​(ThreadGroup group,   Runnable t

Re: [13] Review Request: 8214469 [macos] PIT: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java fails

2019-06-04 Thread Sergey Bylokhov
On 04/06/2019 09:50, semyon.sadet...@oracle.com wrote: Taking into account the above, that states all 3 platforms have different behavior, what makes you think that it is a test issue? Because the test assumes that we have only two toolkit implementations platforms Windows and Unix, and it ch

Re: [13] Review Request: 8214469 [macos] PIT: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java fails

2019-06-04 Thread semyon . sadetsky
On 5/31/19 7:09 PM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8214469 Fix: http://cr.openjdk.java.net/~serb/8214469/webrev.00 This test failure on macOS was reported as a possible regression of JDK-6849922, but it is not stri

Re: [13] Review Request: 8214469 [macos] PIT: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java fails

2019-06-04 Thread Prasanta Sadhukhan
looks fine. Regards Prasanta On 01-Jun-19 7:39 AM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8214469 Fix: http://cr.openjdk.java.net/~serb/8214469/webrev.00 This test failure on macOS was reported as a possible regression of