Re: [14] RFR: 8222563: Remove terminally deprecated method netscape.javascript.JSObject::getWindow

2019-07-24 Thread Andy Herrick
looks good to me. /Andy On 6/17/2019 5:11 PM, Kevin Rushforth wrote: Please review the webrev [1] for JDK-8222563 [2] to remove the terminally deprecated netscape.javascript.JSObject::getWindow method. The proposed fix also eliminates the dependency from the jdk.jsobject module on the java.d

RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-24 Thread Claes Redestad
Hi, by adding a method to load libraries with privileges to JavaLangAccess, we can simplify a slew of places where we are currently implementing adhoc privileged actions. This is a tiny but measurable gain on a range of startup tests. Webrev: http://cr.openjdk.java.net/~redestad/8227587/open.00

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-24 Thread Claes Redestad
Hi Roger, On 2019-07-11 16:10, Roger Riggs wrote: Hi Claes, JavaLangAccess.java: 316: Add @param tag done. System.java:  2282, 2287 Runtime.loadLibrary0 makes a second check for a security manager. Is there any potential gain by calling ClassLoader.loadLibrary directly? None of the interna

Replacement for com.apple.eawt.FullScreen*

2019-07-24 Thread DRC
I looked at the code that supposedly implements the new behavior (activating full-screen mode with setExtendedState(MAXIMIZED_BOTH).)  That code appears unchanged in OpenJDK 11 vs. OpenJDK 9, where it was introduced.  I don't see how the code could possibly duplicate the functionality of com.apple.

Re: RFR: 8227587: Add internal privileged System.loadLibrary

2019-07-24 Thread Claes Redestad
Hi, I'm dropping the changes to java.desktop from this RFE. On 2019-07-12 16:14, Philip Race wrote: 3) I've spent spare time over a number of months trying to decrease unnecessary coupling between desktop and base modules. This seems to create additional technical debt there with minimal benefi

Re: Replacement for com.apple.eawt.FullScreen*

2019-07-24 Thread Sergey Bylokhov
On 24.07.2019 14:03, DRC wrote: As far as filing a bug report, I would love to, but the rules for obtaining a bug tracker account are rather stringent, and I doubt that I qualify (https://wiki.openjdk.java.net/display/general/JBS+Overview). I It is not necessary to have an JBS account to creat

Re: Replacement for com.apple.eawt.FullScreen*

2019-07-24 Thread DRC
As far as filing a bug report, I would love to, but the rules for obtaining a bug tracker account are rather stringent, and I doubt that I qualify (https://wiki.openjdk.java.net/display/general/JBS+Overview). I am an application developer that relies upon OpenJDK, and I have some familiarity with

Re: Replacement for com.apple.eawt.FullScreen*

2019-07-24 Thread DRC
I looked at the code that supposedly implements the new behavior (activating full-screen mode with setExtendedState(MAXIMIZED_BOTH).) That code appears unchanged in OpenJDK 11 vs. OpenJDK 9, where it was introduced. I don't see how the code could possibly duplicate the functionality of com.apple.e