Re: RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-30 Thread Phil Race
Hi, I've stared at this fix and all this bit shifting inside ifdefs is hard to believe this is the way you have to use XIM. Also JDK 13 testing is already well under way and a lot of the testing for Linux has already been finished. So *you* are going to have to run (1) all regression tests o

Re: RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-30 Thread Ichiroh Takiguchi
Thanks, Vladimir. I think it's urgent issue for JDK13. Another reviewer is required. And I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi On 2019-07-29 21:49, Vladimir Kempik wrote: Looks good to me. Now need some reviewers to take a look at it. Thanks, Vladimir. 29 июл

Re: [13] Review Request: 8217676 Upgrade libpng to 1.6.37

2019-07-30 Thread Kevin Rushforth
Looks fine to me, too. +1 On 7/29/2019 4:56 PM, Philip Race wrote: OK +1 assuming you ran the small set of PNG SplashScreen tests we have .. -phil. On 7/29/19, 3:51 PM, Sergey Bylokhov wrote: The fix is updated: http://cr.openjdk.java.net/~serb/8217676/webrev.01 On 29.07.2019 13:10, Phil Ra