Re: [14] RFR JDK-8233703:java/awt/Frame/FrameLocation.java fails on mac

2019-11-11 Thread Sergey Bylokhov
On 11/7/19 8:22 pm, Prasanta Sadhukhan wrote: OK. I will also try with more iterations on 18.04. But, one thing is test is calling removeNotify,addNotify which are not supposed to be called directly from programs. Shouldn't we use allowable APIs maybe setVisible(false), setVisible(true)? BTW,

Re: [14] RFR JDK-8233703:java/awt/Frame/FrameLocation.java fails on mac

2019-11-11 Thread Sergey Bylokhov
On 11/7/19 7:48 pm, Prasanta Sadhukhan wrote: On 08-Nov-19 9:07 AM, Sergey Bylokhov wrote: On 11/7/19 7:32 pm, Prasanta Sadhukhan wrote: Hi Sergey, OK. Since the test pass in local ubuntu18.04 system and fail only in mach5 linux system, I thought it's a test issue. Do you know what window ma

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

2019-11-11 Thread Sergey Bylokhov
On 11/10/19 9:15 pm, Jayathirth Rao wrote: Hi Sergey, I tested with get and setLockingKeyState() and it is not supported in all platforms. I got UnsupportedOperationException in Linux and MacOS in our internal test CI system. But on platforms where it is supported, we can use it. Also ther

[8u] RFR: 8221246: NullPointerException within Win32ShellFolder2

2019-11-11 Thread Alex Kashchenko
Hi, Please review the backport of JDK-8221246 to 8u: Bug: https://bugs.openjdk.java.net/browse/JDK-8221246 Original review thread: https://mail.openjdk.java.net/pipermail/awt-dev/2019-June/015273.html 11u changeset: https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/2f95ca679634 8u we

Re: RFC: JDK-8231991: Mouse wheel change focus on awt/swing windows

2019-11-11 Thread Dmitry Markov
Hi Mario, The fix looks good to me. Thanks, Dmitry > On 11 Nov 2019, at 09:42, Mario Torre wrote: > > On Thu, 2019-10-31 at 12:00 +0100, Mario Torre wrote: >> On Wed, 2019-10-30 at 15:45 -0700, Sergey Bylokhov wrote: >>> Looks fine. >> >> Thanks! >> >> I believe I still need a second reviewe

Re: RFC: JDK-8231991: Mouse wheel change focus on awt/swing windows

2019-11-11 Thread Mario Torre
On Thu, 2019-10-31 at 12:00 +0100, Mario Torre wrote: > On Wed, 2019-10-30 at 15:45 -0700, Sergey Bylokhov wrote: > > Looks fine. > > Thanks! > > I believe I still need a second reviewer's approval? (or, is this > rule still in place?) > Ping? Cheers, Mario -- Mario Torre Associate Manager, S

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

2019-11-11 Thread Jayathirth D V
Hi, Please find updated webrev with equalsIgnoreCase(): http://cr.openjdk.java.net/~jdv/8233696/webrev.01/ Thanks, Jay From: Jayathirth Rao Sent: Monday, November 11, 2019 10:45 AM To: Sergey Bylokhov ; Phil Race Cc: awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: