Re: RFR (M) 8223261 "JDK-8189208 followup - remove JDK_GetVersionInfo0 and the supporting code"

Thank you for the review. I'm happy to wait for your fix to go in first - this will make my fix smaller. cheers On 11/13/19 2:05 PM, Langer, Christoph wrote: Hi Gerard, generally it looks like a nice cleanup. I've got a patch prepared though, which I was planning on posting tomorrow. It

RFR (M) 8223261 "JDK-8189208 followup - remove JDK_GetVersionInfo0 and the supporting code"

Hi all, Please review this cleanup, where we remove JDK_GetVersionInfo0 and related code, since we can get build versions directly from within the VM itself: I'm including core-libs and awt in this review because the proposed fix touches their corresponding files. bug: https://bugs.openjd

Re: Update to the proposal on enhancing MouseWheelEvent

Hi Sergey, You may take a look at https://pavelfatin.com/scrolling-with-pleasure and the comments (particularly, https://pavelfatin.com/scrolling-with-pleasure/#comment-68549) for related details. On Sun, Jan 12, 2020 at 1:22 AM Sergey Bylokhov wrote: > Hi, Pavel. > > On 1/5/17 8:21 am, Pavel

Re: RFR (M) 8223261 "JDK-8189208 followup - remove JDK_GetVersionInfo0 and the supporting code"

Thank you for the review, will remove the comment and updated the webrev, but only after Christop Langer gets his fix in - I'm going to wait for him to check in first. cheers On 11/13/19 1:29 PM, Mandy Chung wrote: On 11/13/19 10:50 AM, gerard ziemski wrote: Hi all, Please review this cl

Re: [15] Review request for 8230926: [macosx] Two apostrophes are entered instead of one with "U.S. International - PC" layout

Hi Anton, Thank you for the detailed explanation. The initial version of the fix, (i.e. http://cr.openjdk.java.net/~alitvinov/8230926/jdk15/webrev.00 ) looks good to me. —Dmitry > On 13 Jan 2020, at 17:01, Anton Litvinov wrote:

Re: [15] Review request for 8230926: [macosx] Two apostrophes are entered instead of one with "U.S. International - PC" layout

Hello Dmitry, Thank you for review of this fix. I tried to address your remark and suggest not to encode all 5 modifier keys and leave the fix as is, because the defined character array will be not readable in comparison with its variant in the first fix version. Current variant: "final char

Re: Update to the proposal on enhancing MouseWheelEvent

Hello Sergey, We’ve resumed our work on smooth scrolling. However, this time we started from other end - we’ve implemented support of touch screen devices on Linux and Windows. I think we can extend it on precise scrolling deltas for high precision mouse devices. Currently we have only private