Re: [14] Review Request: 8236953 [macos] JavaFX SwingNode is not rendered on macOS

2020-01-15 Thread Phil Race
OK. Approved. I wonder how much of a hole we have in our testing where code that matters only to FX is not tested anywhere since FX was decoupled. And please file a bug for Linux if there is not one already as noted in my first email. >>and probably should do this on Linux(it is currently wor

Re: [14] Review Request: 8236953 [macos] JavaFX SwingNode is not rendered on macOS

2020-01-15 Thread Sergey Bylokhov
On 1/15/20 9:11 am, Phil Race wrote: You say this is for 14, but it is not a 14 regression. Seems like it would be nice to fix but clearly not many people are running FX on top of the latest JDK. Can you please join the dots for me on how a change of false to true in setBounds> is the way to

Re: [14] Review Request: 8236953 [macos] JavaFX SwingNode is not rendered on macOS

2020-01-15 Thread Phil Race
Hi, You say this is for 14, but it is not a 14 regression. Seems like it would be nice to fix but clearly not many people are running FX on top of the latest JDK. Can you please join the dots for me on how a change of false to true in setBounds is the way to fix it ? It is not obvious. Wha

Re: [14] Review Request: 8236953 [macos] JavaFX SwingNode is not rendered on macOS

2020-01-15 Thread Kevin Rushforth
Looks good to me. I tested it on my Mac with a few SwingNode apps, and they all render correctly with the fix applied. +1 -- Kevin On 1/14/2020 8:10 PM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8236953 Fix: http://cr.openj

Re: Update to the proposal on enhancing MouseWheelEvent

2020-01-15 Thread Denis Konoplev
Hello Sergey, I can enable smooth scrolling on linux via xinput2. As I understand it, correct me if i am wrong, this change don't require change of public API, we can use precise delta? Looking forward to hearing from you, Denis From: Alexey Ushakov > Date: Mon, Jan 13, 2020 at 12:19 PM > Subje