Re: RFR: 7131400 [macosx] Desktop.edit(a directory) should throw IOException

2020-03-24 Thread Sergey Bylokhov
On 3/24/20 5:42 am, Alexey Ivanov wrote: Will the test leave open Finder windows if IOException is not thrown, i.e. in the case where the test fails? Yes if the test will fail it will leave the file manager open. -- Best regards, Sergey.

Re: RFR: 7131400 [macosx] Desktop.edit(a directory) should throw IOException

2020-03-24 Thread Sergey Bylokhov
On 3/24/20 9:23 am, Philip Race wrote: One might consider what is happening on mac to be the preferred behaviour for edit() I am not sure I would consider this a bug to open finder on a folder. How would you be able to achieve that after this change ? Can't we open Explorer on Windows to align

Re: RFR: 7131400 [macosx] Desktop.edit(a directory) should throw IOException

2020-03-24 Thread Philip Race
One might consider what is happening on mac to be the preferred behaviour for edit() I am not sure I would consider this a bug to open finder on a folder. How would you be able to achieve that after this change ? Can't we open Explorer on Windows to align behaviour ? The print() case it seems l

RFR [XXS]: JDK-8241491 : Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java on aix

2020-03-24 Thread Baesken, Matthias
Hello please review this very small fix . Bug https://bugs.openjdk.java.net/browse/JDK-8241228 states we need to problem list https://bugs.openjdk.java.net/browse/JDK-8241228 . This has been done on linux + solaris already with the issue https://bugs.openjdk.java.net/browse/JDK-8241229 but we mi

Re: RFR: 7131400 [macosx] Desktop.edit(a directory) should throw IOException

2020-03-24 Thread Alexey Ivanov
Hi Sergey, On 23/03/2020 09:32, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-7131400 Fix: http://cr.openjdk.java.net/~serb/7131400/webrev.00 The java.awt.Desktop.edit()/print() methods behave differently on macOS and Windows

Re: RFR: JDK-8241463 Move build tools to respective modules

2020-03-24 Thread Magnus Ihse Bursie
On 2020-03-23 23:15, naoto.s...@oracle.com wrote: Hi Magnus, I looked at i18n related changes: make/CopyInterimTZDB.gmk make/ToolsJdk.gmk make/gendata/Gendata-java.base.gmk make/gendata/GendataBreakIterator.gmk make/gendata/GendataTZDB.gmk make/gensrc/GensrcCharacterData.gmk make/gensrc/GensrcE