Re: [16] RFR 8232114: JVM crashed at imjpapi.dll in native code

2020-08-17 Thread Dmitry Markov
Thank you, Sergey! Looking for one more "+1”. Any volunteers? Regards, Dmitry > On 17 Aug 2020, at 21:06, Sergey Bylokhov wrote: > > Looks fine. > > On 17.08.2020 02:32, Dmitry Markov wrote: >> Hi Sergey, >> I have added that information to InvokeInputMethodFunction(). Please find >> the new

Re: [16] RFR 8249183: JVM crash in "AwtFrame::WmSize" method

2020-08-17 Thread Sergey Bylokhov
Hi, Anton. On 14.08.2020 10:00, Anton Litvinov wrote: Could you please review the following fix for the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8249183 Webrev: http://cr.openjdk.java.net/~alitvinov/8249183/jdk16/webrev.00 Maybe we can get rid most part of this native method and do

Re: [16] RFR 8232114: JVM crashed at imjpapi.dll in native code

2020-08-17 Thread Sergey Bylokhov
Looks fine. On 17.08.2020 02:32, Dmitry Markov wrote: Hi Sergey, I have added that information to InvokeInputMethodFunction(). Please find the new webrev here: http://cr.openjdk.java.net/~dmarkov/8232114/webrev.01/ Regards, Dmitry On 15 Aug 2020, at 03:05, Sergey Bylokhov mailto:sergey.bylo

Re: RFR[8250855]: 'Address reliance on default constructors in the Java 2D APIs'

2020-08-17 Thread Philip Race
Neither of awt-dev or jdk-dev is the right list for this fix. Please move the review to 2d-dev. -phil. On 8/17/20, 4:50 AM, Lance Andersen wrote: Hi Daniel On Aug 17, 2020, at 7:30 AM, Daniel Fuchs wrote: On 17/08/2020 12:16, Lance Andersen wrote: The description for almost all of the con

Re: RFR[8250855]: 'Address reliance on default constructors in the Java 2D APIs'

2020-08-17 Thread Daniel Fuchs
On 17/08/2020 12:16, Lance Andersen wrote: The description for almost all of the constructors indicate: Constructor for subclasses to call —— Is the above wording used elsewhere in the JDK? Not sure I like it, I might suggest a little wordsmithing As far as I know that's what Joe

RFR[8250855]: 'Address reliance on default constructors in the Java 2D APIs'

2020-08-17 Thread Conor Cleary
Hi all, Looking for reviewers for JDK-8250855, 'Address reliance on default constructors in the Java 2D APIs'. This patch addresses the reliance on default constructors in the following packages: * java.awt.Image * java.awt.PrintJob * java.awt.font.GlyphVector * java.awt.font.LayoutPath

Re: [16] RFR 8232114: JVM crashed at imjpapi.dll in native code

2020-08-17 Thread Dmitry Markov
Hi Sergey, I have added that information to InvokeInputMethodFunction(). Please find the new webrev here: http://cr.openjdk.java.net/~dmarkov/8232114/webrev.01/ Regards, Dmitry > On 15 Aug 2020, at 03:05, Sergey Bylokhov wrote: > > On