Re: RFR: 8182043 Access to Windows Large Icons

On 29.05.2020 14:35, Alexey Ivanov wrote: The ultimate goal of this API could be to provide an MRI which stores all the available icon sizes and loads dynamically the size that's most appropriate to the current display settings. Raymond Chen has a blog post about the format of the icon resourc

Re: [16] RFR 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

Looks fine then. On 28.08.2020 13:42, Dmitry Markov wrote: Hi Sergey, According to JDK-8232114 the crash may take place if TraslateMessage() (which is executed by the toolkit thread) call the IME API and at the same time we invoke some IME function using SendMessage(). Here we have a differen

Re: [16] RFR 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

OK. Please push to jdk/client. -phil. On 8/28/20, 1:44 PM, Dmitry Markov wrote: Hi Phil, I ran all client test using mach5. All related test passed, see https://mach5.us.oracle.com/mdash/jobs?search=id:dmarkov-jdk-client-20200828-1219-13803609 Regards, Dmitry On 28 Aug 2020, at 21:00

Re: [16] RFR 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

Hi Phil, I ran all client test using mach5. All related test passed, see https://mach5.us.oracle.com/mdash/jobs?search=id:dmarkov-jdk-client-20200828-1219-13803609 <https://mach5.us.oracle.com/mdash/jobs?search=id:dmarkov-jdk-client-20200828-1219-13803609> Regards, Dmitry > On 28

Re: [16] RFR 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

Hi Sergey, According to JDK-8232114 the crash may take place if TraslateMessage() (which is executed by the toolkit thread) call the IME API and at the same time we invoke some IME function using SendMessage(). Here we have a different situation: the toolkit thread cannot run TranslateMessage()

Re: [16] RFR 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

On 28.08.2020 12:54, Dmitry Markov wrote: If DND operation is active then we shouldn’t post the IME messages to the toolkit thread queue and use SendMessage() function instead. But it means that if DnD is active we will crash in the same way as described in JDK-8232114? -- Best regards, Ser

Re: [16] RFR 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

Looks Ok to me but please confirm that all related tests pass. -phil. On 8/28/20, 12:54 PM, Dmitry Markov wrote: Hello, Could you review the fix for JDK 16, please? bug: https://bugs.openjdk.java.net/browse/JDK-8252470 webrev: http://cr.openjdk.java.net/~dmarkov/8252470/webrev.00/

[16] RFR 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

Hello, Could you review the fix for JDK 16, please? bug: https://bugs.openjdk.java.net/browse/JDK-8252470 webrev: http://cr.openjdk.java.net/~dmarkov/8252470/webrev.00/ P

Re: RFR: 8252349 Delete the "sun.awt.X11.checkSTRUT" property

+1 -phil. On 8/26/20, 12:34 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8252349 Fix: http://cr.openjdk.java.net/~serb/8252349/webrev.00 This property was added to the XToolkit as a workaround for the possible bugs cause

IMPORTANT - PLEASE READ - Retiring the jdk/client repo next week

All, Contingent on Project Skara (ie mercurial ->git / githib) going active for the JDK project on schedule on 5th September, we intend to retire the jdk/client repo/forest as part of this transition. In other words, once mercurial is shut down and we move to git there will ONLY be the main

Re: [16] RFR 8249183: JVM crash in "AwtFrame::WmSize" method

Thank you, Sergey, for review and approval of this fix. Hello reviewers, Can anybody else become the second reviewer of this fix? Thank you, Anton On 27/08/2020 03:03, Sergey Bylokhov wrote: Looks fine. On 24.08.2020 16:26, Anton Litvinov wrote: Hi Sergey, Thank you for confirmation about