Integrated: 8253965: Delete the outdated java.awt.PeerFixer class

2020-10-08 Thread Sergey Bylokhov
On Sat, 3 Oct 2020 03:43:42 GMT, Sergey Bylokhov wrote: > This bug is extracted from the JDK-8251123. Instead of specifying this > old/unused class, I suggest to delete it. > > This is the comment added to this class in JDK 1.1.1: > > == > /* > * In JDK 1.1.1, the

Re: RFR: 8182043: Access to Windows Large Icons

2020-10-08 Thread Alexey Ivanov
On Mon, 28 Sep 2020 15:20:33 GMT, Alexander Zuev wrote: > Moving review from Mercurial. See > https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016078.html for > previous > iteration. src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 986: > 984:

Integrated: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2020-10-08 Thread Sergey Bylokhov
On Sat, 3 Oct 2020 00:03:07 GMT, Sergey Bylokhov wrote: > The "discardingMouseEvents" flag in the SunDragSourceContextPeer class is > used on the different threads without any > synchronization. This pull request has now been integrated. Changeset: c2a5de63 Author:Sergey Bylokhov URL:

Re: RFR: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2020-10-08 Thread Aleksey Shipilev
On Wed, 7 Oct 2020 23:35:00 GMT, Sergey Bylokhov wrote: >> As far as I can see, the only effect `volatile` has here is making sure the >> successive calls to `checkEvent` eventually >> get the updated value of `discardingMouseEvents`. This does not seem to >> resolve the original race: calls

Re: RFR: JDK-8234393: [macos] printing ignores printer tray [v2]

2020-10-08 Thread Prasanta Sadhukhan
On Wed, 7 Oct 2020 14:30:26 GMT, Vipin Menon wrote: >> **Issue** >> >> [https://bugs.openjdk.java.net/browse/JDK-8234393](https://bugs.openjdk.java.net/browse/JDK-8234393) >> >> **Problem** >> >> On a multi tray printer, irrespective of what tray is set, Java always >> prints from the last

Re: RFR: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2020-10-08 Thread Sergey Bylokhov
On Wed, 7 Oct 2020 07:13:53 GMT, Aleksey Shipilev wrote: > The iron-clad fix would be to synchronously insert something like > `DiscardMouseEvent` on the beginning of event queue, > and `AcceptMouseEvent` at the end of it, and let the `EventQueue` processor > thread manage the flag -- so that