Re: RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v5]

2020-12-14 Thread Alexander Zuev
On Mon, 14 Dec 2020 21:31:15 GMT, Phil Race wrote: >> This defines some macros to support declaring and initialising statically >> allocated instances of jclass, jmethodID and jfieldID >> and changes many existing uses of JNF macros/functions to use these instead. >> Then calls to JNFCall* and J

Re: RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v3]

2020-12-14 Thread Phil Race
On Mon, 14 Dec 2020 08:52:02 GMT, Alexander Zuev wrote: >> Phil Race has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D >> code >> - 8257853: Remove dependencies

Re: RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v5]

2020-12-14 Thread Phil Race
> This defines some macros to support declaring and initialising statically > allocated instances of jclass, jmethodID and jfieldID > and changes many existing uses of JNF macros/functions to use these instead. > Then calls to JNFCall* and JNFNewObject - etc are updated to directly call > JNI met

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-14 Thread Phil Race
On Mon, 14 Dec 2020 19:48:36 GMT, Andrey Turbanov wrote: > I've added few words in description. > > About testing: as I can see testing is done via Github Actions. tier1 builds > are ok. OK that's better But about testing. The github actions won't run a single test that touches any code with

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-14 Thread Andrey Turbanov
On Sat, 12 Dec 2020 23:05:35 GMT, Phil Race wrote: >> The bug is filed: >> https://bugs.openjdk.java.net/browse/JDK-8258006 > > Whilst this looks "reasonable" I am not impressed by the complete lack of > description of > 1) why this is being proposed > 2) what are the benefits > 3) what testing

Withdrawn: 8257584: [macos] NullPointerException originating from LWCToolkit.java

2020-12-14 Thread Alexander Zuev
On Mon, 14 Dec 2020 18:26:22 GMT, Alexander Zuev wrote: > 8257584: [macos] NullPointerException originating from LWCToolkit.java This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/1769

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-12-14 Thread Andrii Rodionov
On Wed, 9 Dec 2020 01:26:08 GMT, Phil Race wrote: >> No, we produce only one image. The headless/non-headless mode is defined by >> the system property `-Djava.awt.headless=...`. >> Here is a command example for native image generation: >> `$ ~/graalvm-ce-java11-21.0.0-dev/bin/native-image >> -

RFR: 8257584: [macos] NullPointerException originating from LWCToolkit.java

2020-12-14 Thread Alexander Zuev
8257584: [macos] NullPointerException originating from LWCToolkit.java - Commit messages: - 8257584: [macos] NullPointerException originating from LWCToolkit.java - JDK-8256109: Create implementation for NSAccessibilityButton protocol - Merge pull request #5 from openjdk/master -

Integrated: 8255880: UI of Swing components is not redrawn after their internal state changed

2020-12-14 Thread Anton Litvinov
On Wed, 9 Dec 2020 20:14:01 GMT, Anton Litvinov wrote: > Hello colleagues, > > Could you please review the fix for the bug specific to Linux OS and Solaris > OS, which consists in the fact that, if Swing components are changed through > standard public API of these components, while the frame

Re: RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v4]

2020-12-14 Thread Alexander Zuev
On Sat, 12 Dec 2020 22:28:52 GMT, Phil Race wrote: >> I updated this fix with the additional changes for the accessibility files. >> There's a little bit of clean up as some declarations were unused and also >> these files shared a single defintion of some classes across files which >> were mos

Re: RFR: 8255880: UI of Swing components is not redrawn after their internal state changed [v2]

2020-12-14 Thread Sergey Bylokhov
On Sun, 13 Dec 2020 23:56:12 GMT, Anton Litvinov wrote: >> Hello colleagues, >> >> Could you please review the fix for the bug specific to Linux OS and Solaris >> OS, which consists in the fact that, if Swing components are changed through >> standard public API of these components, while the

Re: RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v3]

2020-12-14 Thread Alexander Zuev
On Sat, 12 Dec 2020 18:55:13 GMT, Phil Race wrote: >> This defines some macros to support declaring and initialising statically >> allocated instances of jclass, jmethodID and jfieldID >> and changes many existing uses of JNF macros/functions to use these instead. >> Then calls to JNFCall* and J