RFR: 8257584: [macos] NullPointerException originating from LWCToolkit.java

2020-12-15 Thread Alexander Zuev
8257584: [macos] NullPointerException originating from LWCToolkit.java - Commit messages: - 8257584: [macos] NullPointerException originating from LWCToolkit.java - Merge pull request #5 from openjdk/master - Merge pull request #4 from openjdk/master - Merge pull request #3 from o

Integrated: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-12-15 Thread Andrii Rodionov
On Thu, 8 Oct 2020 12:57:29 GMT, Andrii Rodionov wrote: > The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 > > Starting from version 11.0.9, all JDK libraries also build as static > libraries (JEP 178: Statically-Linked JNI Libraries). > The purpose of using static libra

[jdk16] Integrated: 8258427: Problem List some tests related to FileDialog for MacOS

2020-12-15 Thread Pankaj Bansal
On Tue, 15 Dec 2020 21:08:14 GMT, Pankaj Bansal wrote: > A few tests related to FileDialog have been failing frequency in our CI build > for MacOS. It is better to problem list those tests before they are fixed. > > Following open repository test will be problem listed. > java/awt/FileDialog/Fi

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-15 Thread Bob Vandette
On Mon, 30 Nov 2020 17:53:26 GMT, Andrii Rodionov wrote: >> The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 >> >> Starting from version 11.0.9, all JDK libraries also build as static >> libraries (JEP 178: Statically-Linked JNI Libraries). >> The purpose of using static

Re: [jdk16] RFR: 8258427: Problem List some tests related to FileDialog for MacOS

2020-12-15 Thread Phil Race
On Tue, 15 Dec 2020 21:08:14 GMT, Pankaj Bansal wrote: > A few tests related to FileDialog have been failing frequency in our CI build > for MacOS. It is better to problem list those tests before they are fixed. > > Following open repository test will be problem listed. > java/awt/FileDialog/Fi

Re: [jdk16] RFR: 8258427: Problem List some tests related to FileDialog for MacOS

2020-12-15 Thread Sergey Bylokhov
On Tue, 15 Dec 2020 21:08:14 GMT, Pankaj Bansal wrote: > A few tests related to FileDialog have been failing frequency in our CI build > for MacOS. It is better to problem list those tests before they are fixed. > > Following open repository test will be problem listed. > java/awt/FileDialog/Fi

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-15 Thread Phil Race
On Tue, 15 Dec 2020 17:14:11 GMT, Andrey Turbanov wrote: >>> I've added few words in description. >>> >>> About testing: as I can see testing is done via Github Actions. tier1 >>> builds are ok. >> >> OK that's better But about testing. The github actions won't run a single >> test that touc

[jdk16] RFR: 8258427: Problem List some tests related to FileDialog for MacOS

2020-12-15 Thread Pankaj Bansal
A few tests related to FileDialog have been failing frequency in our CI build for MacOS. It is better to problem list those tests before they are fixed. Following open repository test will be problem listed. java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java - Commit mes

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-15 Thread Phil Race
On Tue, 15 Dec 2020 20:58:44 GMT, Magnus Ihse Bursie wrote: >> Andrii Rodionov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native >> Imag

Re: RFR: 8254850: Update terminology in java.awt.GridBagLayout source code comments

2020-12-15 Thread Alexander Zuev
On Tue, 15 Dec 2020 17:47:54 GMT, Phil Race wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms. > See JDK-8253315 for details. > > This updates a few comments in GridBagLayout to use the terms parent and > child which are > sufficien

Re: RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-15 Thread Magnus Ihse Bursie
On Mon, 30 Nov 2020 17:53:26 GMT, Andrii Rodionov wrote: >> The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 >> >> Starting from version 11.0.9, all JDK libraries also build as static >> libraries (JEP 178: Statically-Linked JNI Libraries). >> The purpose of using static

Re: RFR: 8254850: Update terminology in java.awt.GridBagLayout source code comments

2020-12-15 Thread Kevin Rushforth
On Tue, 15 Dec 2020 17:47:54 GMT, Phil Race wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms. > See JDK-8253315 for details. > > This updates a few comments in GridBagLayout to use the terms parent and > child which are > sufficien

RFR: 8254850: Update terminology in java.awt.GridBagLayout source code comments

2020-12-15 Thread Phil Race
This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms. See JDK-8253315 for details. This updates a few comments in GridBagLayout to use the terms parent and child which are sufficiently descriptive and consistent with lots of other usages.

Re: RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v5]

2020-12-15 Thread Phil Race
On Mon, 14 Dec 2020 22:06:13 GMT, Alexander Zuev wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D >> code > > Accessibility part is perfectly f

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop

2020-12-15 Thread Andrey Turbanov
On Mon, 14 Dec 2020 20:04:05 GMT, Phil Race wrote: >> I've added few words in description. >> >> About testing: as I can see testing is done via Github Actions. tier1 builds >> are ok. > >> I've added few words in description. >> >> About testing: as I can see testing is done via Github Action

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2]

2020-12-15 Thread Andrey Turbanov
> There are few places in code where manual `while` loop is used with > `Iterator` to iterate over `Collection`. > Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle > instead: it's less verbose, makes code easier to read and it's less > error-prone. > It doesn't have an