On Tue, 1 Dec 2020 22:49:08 GMT, Alexander Zuev wrote:
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
This pull request has now been integrated.
Changeset: ae9187d7
Aut
On Thu, 14 Jan 2021 04:54:17 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Thu, 14 Jan 2021 00:17:57 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Replaced #include with #import for consistency
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComp
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Added AWT_
On Tue, 12 Jan 2021 06:08:10 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Wed, 13 Jan 2021 23:20:11 GMT, Sergey Bylokhov wrote:
>> You are correct. This is running in a performOnMainThreadWaiting:NO block.
>> So the JNI call likely already returned to Java before that block gets run
>> on the AppKit thread.
>> But this seems to be the same as before and there was p
On Wed, 13 Jan 2021 21:16:42 GMT, Phil Race wrote:
>>> Since the next line throws NSException everything before this change and
>>> after this change should cause control to reach the COCOA_EXIT macro.
>>
>> It does not, the JNI_COCOA_EXIT macro is executed on a different thread than
>> JNI_CO
On Wed, 13 Jan 2021 20:35:55 GMT, Phil Race wrote:
> One line fix of a missed update
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2066
On Wed, 13 Jan 2021 21:30:24 GMT, Sergey Bylokhov wrote:
>> Fair question but there was no NULL check there before so I assume it isn't
>> expected to be NULL.
>> I could add a NULL check but then we'd skip over the following code and
>> maybe hide something that could be a problem. I don't min
On Wed, 13 Jan 2021 21:24:57 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m
>> line 1456:
>>
>>> 1454:
>>> 1455: id value = nil;
>>> 1456: if ((*env)->IsInstanceOf(env, jparent, jc_Container)) {
>>
>> Not sure, but do we need to c
On Wed, 13 Jan 2021 21:10:46 GMT, Sergey Bylokhov wrote:
>> One line fix of a missed update
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m
> line 1456:
>
>> 1454:
>> 1455: id value = nil;
>> 1456: if ((*env)->IsInstanceOf(env, jparent, jc_Container)) {
On Wed, 13 Jan 2021 06:38:13 GMT, Sergey Bylokhov wrote:
>> Since the next line throws NSException everything before this change and
>> after this change should cause control to reach the COCOA_EXIT macro. I am
>> not aware of anything in between. So this should be OK. The previous JNF
>> cod
On Wed, 13 Jan 2021 20:35:55 GMT, Phil Race wrote:
> One line fix of a missed update
src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m
line 1456:
> 1454:
> 1455: id value = nil;
> 1456: if ((*env)->IsInstanceOf(env, jparent, jc_Container)) {
Not sure, but d
One line fix of a missed update
-
Commit messages:
- 8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
Changes: https://git.openjdk.java.net/jdk/pull/2066/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2066&range=00
Issue: https://bugs.openjdk.java.net/browse/
On Wed, 13 Jan 2021 17:29:09 GMT, Daniel D. Daugherty
wrote:
> This is a trivial fix to ProblemList
> java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java
> on Windows in order to reduce the noise in the JDK16 CI.
This pull request has now been integrated.
Changeset: 8abefdec
Au
On Wed, 13 Jan 2021 17:29:09 GMT, Daniel D. Daugherty
wrote:
> This is a trivial fix to ProblemList
> java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java
> on Windows in order to reduce the noise in the JDK16 CI.
Marked as reviewed by pbansal (Reviewer).
-
PR: http
On Wed, 13 Jan 2021 17:57:44 GMT, Alexander Zuev wrote:
>> This is a trivial fix to ProblemList
>> java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java
>> on Windows in order to reduce the noise in the JDK16 CI.
>
> Marked as reviewed by kizune (Reviewer).
@azuev-java - Thanks for
On Wed, 13 Jan 2021 17:29:09 GMT, Daniel D. Daugherty
wrote:
> This is a trivial fix to ProblemList
> java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java
> on Windows in order to reduce the noise in the JDK16 CI.
Marked as reviewed by kizune (Reviewer).
-
PR: https
This is a trivial fix to ProblemList
java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java
on Windows in order to reduce the noise in the JDK16 CI.
-
Commit messages:
- 8259720: ProblemList
java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java on Windows
On Wed, 13 Jan 2021 06:33:19 GMT, Sergey Bylokhov wrote:
>> I know. But in this case that was not enough - that still caused weird
>> compilation glitches like full compilation works but incremental calculation
>> gives compilation error about usage of non-initialized variables. Guards
>> help
20 matches
Mail list logo
