On Tue, 26 Jan 2021 04:08:44 GMT, Sergey Bylokhov wrote:
> This fix enables display change detection on Linux when the number of
> monitors is changed in the Xinerama mode.
>
> The fix itself is straightforward:
> 1. When we get an event that the root window is changed we assume that it
> coul
On Wed, 20 Jan 2021 01:59:39 GMT, Sergey Bylokhov wrote:
>> I failed to test branches of XDnDDropTargetProtocol::processXdndPosition(..)
>> under condition (xwindow == null) by means of EmbeddedFrame. In addition
>> none of automatic regression tests (test/jdk/java/awt/dnd/,
>> test/jdk/java/a
On Tue, 2 Feb 2021 21:26:28 GMT, Kevin Rushforth wrote:
>> The changes look good to me, but please see my comment from my review about
>> documenting `NormalizedPathNSStringFromJavaString()` API.
>
> The following commit was integrated to jdk master since you created this
> branch:
>
> acbcde8
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway since then it gets the current JDK ones not the ones fr
> Please, review this small fix for drag-n-drop on Linux with HiDPI turned on!
>
> This bug is due to the following reason: while scaling Java recalculates
> resolution (W x H) according to sun.java2d.uiScale (W/SCALE x H/SCALE) and
> works inside these new coordinates but at the same time the e
On Tue, 2 Feb 2021 22:33:09 GMT, Phil Race wrote:
>> I read it and not sure that it is fine to ignore this error, why not throw
>> an exception and signal the CTextPipe_doDrawString that an error occurred
>> like InvalidPipeException or something(Sometimes we wrap other exception
>> like OOM i
On Tue, 2 Feb 2021 22:02:14 GMT, Sergey Bylokhov wrote:
>> I ran some tests embedding JavaFX into Swing and vice versa both with and
>> without `-Djavafx.embed.singleThread=true` and I don't see any regression in
>> behavior.
>
> I am mostly worried about the usage of JNF by someone else's nati
On Tue, 2 Feb 2021 21:48:36 GMT, Sergey Bylokhov wrote:
>> Look a few lines further up at my reply 3 days ago Gerard about this.
>
> I read it and not sure that it is fine to ignore this error, why not throw an
> exception and signal the CTextPipe_doDrawString that an error occurred like
> Inva
On Mon, 1 Feb 2021 23:47:06 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CTextPipe.m line 611:
>>
>>> 609: const jchar *unichars = (*env)->GetStringChars(env, str, NULL);
>>> 610: if (unichars == NULL) {
>>> 611: return;
>>
>> Do not we ne
On Tue, 2 Feb 2021 21:18:42 GMT, Kevin Rushforth wrote:
>> We are just specifying an additional run mode for JDK internal use.
>> It means that when we are saying to process only events for that mode, then
>> only those will be processed.
>> And it is used only for nested event loops.
>> Nothing
On Mon, 1 Feb 2021 18:33:32 GMT, Gerard Ziemski wrote:
>> Marked as reviewed by gziemski (Committer).
>
> The changes look good to me, but please see my comment from my review about
> documenting `NormalizedPathNSStringFromJavaString()` API.
The following commit was integrated to jdk master sin
On Tue, 2 Feb 2021 00:30:07 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libosxapp/ThreadUtilities.m line 53:
>>
>>> 51: @implementation ThreadUtilities
>>> 52:
>>> 53: + (void)initialize {
>>
>> I think we need to check how this new modes will work when the AWT is
>> embedded insi
On Tue, 2 Feb 2021 07:13:03 GMT, Pankaj Bansal wrote:
>> A trivial fix to ProblemList
>> java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
>> in order to reduce the noise in the JDK17 CI.
>
> Marked as reviewed by pbansal (Reviewer).
Thanks for the reviews!
-
P
On Mon, 1 Feb 2021 23:16:18 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
> in order to reduce the noise in the JDK17 CI.
This pull request has now been integrated.
Changeset: defcb042
Author:Daniel D.
On Tue, 26 Jan 2021 04:08:44 GMT, Sergey Bylokhov wrote:
> This fix enables display change detection on Linux when the number of
> monitors is changed in the Xinerama mode.
>
> The fix itself is straightforward:
> 1. When we get an event that the root window is changed we assume that it
> coul
15 matches
Mail list logo
