Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v2]

2021-02-04 Thread Alexander Zuev
> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image > Radio Buttons" and "Image CheckBoxes" Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Test simplification. - Changes: - all: https://git

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v2]

2021-02-04 Thread Alexander Zuev
On Thu, 4 Feb 2021 01:09:42 GMT, Sergey Bylokhov wrote: >> test/jdk/javax/swing/JCheckBox/ImageCheckboxFocus/ImageCheckboxTest.java >> line 68: >> >>> 66: public void performTest() throws Exception { >>> 67: try { >>> 68: BufferedImage imageFocus1 = null; >> >> Probably

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v2]

2021-02-04 Thread Alexander Zuev
On Wed, 3 Feb 2021 23:52:24 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test simplification. > > src/java.desktop/macosx/classes/com/apple/laf/AquaButtonLabeledUI.java line > 178: > >>

RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-04 Thread Ajit Ghaisas
This is the implementation of JEP 382 : New macOS Rendering Pipeline (Metal rendering pipeline) JEP Link - https://bugs.openjdk.java.net/browse/JDK-8238361 - Commit messages: - Project Lanai Patch Changes: https://git.openjdk.java.net/jdk/pull/2403/files Webrev: https://webrevs.o

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-04 Thread Magnus Ihse Bursie
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

RFR: 8261198: [macOS] Incorrect JNI parameters in number conversion in A1Y code.

2021-02-04 Thread Phil Race
we need to specify ()I for the signature of the method that returns int. Additionally number (the instance!) needs to be passed to the method up call. - Commit messages: - 8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code Changes: https://git.openjdk.java.n

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v2]

2021-02-04 Thread Sergey Bylokhov
On Thu, 4 Feb 2021 16:24:56 GMT, Alexander Zuev wrote: >> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image >> Radio Buttons" and "Image CheckBoxes" > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8261198: [macOS] Incorrect JNI parameters in number conversion in A1Y code.

2021-02-04 Thread Sergey Bylokhov
On Fri, 5 Feb 2021 01:27:26 GMT, Phil Race wrote: > we need to specify ()I for the signature of the method that returns int. > Additionally number (the instance!) needs to be passed to the method up call. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v3]

2021-02-04 Thread Alexander Zuev
> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image > Radio Buttons" and "Image CheckBoxes" Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Removing unneeded try/catch block from the test. - C

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v2]

2021-02-04 Thread Alexander Zuev
On Fri, 5 Feb 2021 02:17:33 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test simplification. > > test/jdk/javax/swing/JCheckBox/ImageCheckboxFocus/ImageCheckboxTest.java line > 68: > >>

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v4]

2021-02-04 Thread Alexander Zuev
> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image > Radio Buttons" and "Image CheckBoxes" Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Remove leftovers from last experiments. - Changes:

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v4]

2021-02-04 Thread Sergey Bylokhov
On Fri, 5 Feb 2021 05:12:00 GMT, Alexander Zuev wrote: >> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image >> Radio Buttons" and "Image CheckBoxes" > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v2]

2021-02-04 Thread Sergey Bylokhov
On Fri, 5 Feb 2021 05:06:23 GMT, Alexander Zuev wrote: >> test/jdk/javax/swing/JCheckBox/ImageCheckboxFocus/ImageCheckboxTest.java >> line 68: >> >>> 66: throw new Exception("Changing focus is not visualized"); >>> 67: } >>> 68: } finally { >> >> try/finally

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v2]

2021-02-04 Thread Alexander Zuev
On Fri, 5 Feb 2021 05:26:48 GMT, Sergey Bylokhov wrote: >> No, forgot to remove it. Not that it makes test invalid, but better get rid >> of it. Fixed. > > Looks fine, I assume that this test was checked via mach5 since the fix is in > aqua and the test is cross-platform. Yes, did two separate

Re: RFR: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" [v4]

2021-02-04 Thread Pankaj Bansal
On Fri, 5 Feb 2021 05:12:00 GMT, Alexander Zuev wrote: >> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image >> Radio Buttons" and "Image CheckBoxes" > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > >