On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
Hi,
Please review the fix for the issue of JPasswordField and activated InputMethod
on macOS.
I don't think this condition is usual, but I'd like to avoid crash.
It needs two additional checks in "AWTView
attributedSubstringForProposedRange:actualRange".
Tested test/jdk/java/awt on macOS Catali
On Thu, 11 Mar 2021 07:57:23 GMT, Pankaj Bansal wrote:
> The implementation of NSAccessibilityStaticText protocol
> (https://developer.apple.com/documentation/appkit/nsaccessibilitystatictext)
> has an incorrect function name which results in the function not being called
> by Voice Over. The
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
On Fri, 12 Mar 2021 10:11:27 GMT, Prasanta Sadhukhan
wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>> co
On Fri, 12 Mar 2021 04:55:45 GMT, Prasanta Sadhukhan
wrote:
> Is this only about addition/removal? What about printer name change?
You cannot change the name of a remote printer.
Opening *Printer Properties* dialog from the printer context menu on the local
host and editing its name changes t
On Fri, 12 Mar 2021 11:29:17 GMT, Alexey Ivanov wrote:
>> Is this only about addition/removal? What about printer name change?
>> Shouldn't we get notified in that case as trying to print on printer with
>> old name will not find the printer!!
>> If yes, in that regard I guess REG_NOTIFY_CHANGE
On Fri, 12 Mar 2021 11:38:08 GMT, Prasanta Sadhukhan
wrote:
>>> Is this only about addition/removal? What about printer name change?
>>
>> You cannot change the name of a remote printer.
>>
>> Opening *Printer Properties* dialog from the printer context menu on the
>> local host and editing i
On Wed, 10 Mar 2021 15:38:27 GMT, Alexey Ivanov wrote:
> [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented
> polling for remote printers.
> That bug description also mentions watching the registry for changes and
> links to the article which describes the method yet it
On Fri, 12 Mar 2021 12:30:13 GMT, Alexey Ivanov wrote:
>> I can understand that as a user, you cannot /shouldn't change the name of a
>> remote network printer but a network admin can change the name, so shouldn't
>> we get notification on that name change when this method gets called after
>>
On Fri, 12 Mar 2021 08:16:09 GMT, Toshio Nakamura wrote:
> Hi,
> Please review the fix for the issue of JPasswordField and activated
> InputMethod on macOS.
> I don't think this condition is usual, but I'd like to avoid crash.
>
> It needs two additional checks in "AWTView
> attributedSubstrin
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote:
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2920
SonarCloud reports:
Remove or correct this "removeAll" call.
void removeAll() {
items.removeAll(items); // <--- here
updateScrollbars();
}
Calling `removeAll()` with the same collection risks concurrent modification
exceptions. `clear()` would be correct and more effici
implementation of
JDK-8256145: JEP 398: Deprecate the Applet API for Removal
-
Commit messages:
- 8189198: Add "forRemoval = true" to Applet API deprecations
Changes: https://git.openjdk.java.net/jdk/pull/2920/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2920&range=0
On Fri, 12 Mar 2021 00:25:39 GMT, Alexander Zvegintsev
wrote:
> First steps of the test are:
>
> - display undecorated background window
> - click on it
> - check if the window has received that click
> - ... continue with test ...
>
> Unfortunately on Linux the test makes click before the win
On Fri, 12 Mar 2021 15:44:39 GMT, Aleksey Shipilev wrote:
> SonarCloud reports:
> Remove or correct this "removeAll" call.
>
> void removeAll() {
> items.removeAll(items); // <--- here
> updateScrollbars();
> }
>
> Calling `removeAll()` with the same collection risks c
On Fri, 12 Mar 2021 14:55:06 GMT, Dmitry Markov wrote:
>> Hi,
>> Please review the fix for the issue of JPasswordField and activated
>> InputMethod on macOS.
>> I don't think this condition is usual, but I'd like to avoid crash.
>>
>> It needs two additional checks in "AWTView
>> attributedSub
On Wed, 10 Mar 2021 15:38:27 GMT, Alexey Ivanov wrote:
> [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented
> polling for remote printers.
> That bug description also mentions watching the registry for changes and
> links to the article which describes the method yet it
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote:
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2920
On Fri, 12 Mar 2021 23:34:08 GMT, Sergey Bylokhov wrote:
>> Marked as reviewed by dmarkov (Reviewer).
>
> As far as I understand the JPasswordField is affected because it disables
> InputMethods by default? I wonder why in this case we even try to run
> something in the native code?
I agree th
On Fri, 12 Mar 2021 08:16:09 GMT, Toshio Nakamura wrote:
> Hi,
> Please review the fix for the issue of JPasswordField and activated
> InputMethod on macOS.
> I don't think this condition is usual, but I'd like to avoid crash.
>
> It needs two additional checks in "AWTView
> attributedSubstrin
23 matches
Mail list logo
