Re: RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles [v3]

2021-05-10 Thread Pankaj Bansal
> Create implementation of native accessibility peer for ScrollPane and > ScrollBar Java Accessibility roles. > > There are no direct protocols for these two roles and there is no protocol in > list of role based protocols defined by Apple Accessibility API, which can be > used for these roles

Re: RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Pankaj Bansal
On Mon, 10 May 2021 21:38:37 GMT, Sergey Bylokhov wrote: > An exception occurs when the main thread disposes of the frame while the > other thread still renders to it. The fix joins the main thread to other > threads, so we will dispose of the frame at the end only. Marked as reviewed by pbans

Re: RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Alexander Zuev
On Mon, 10 May 2021 21:38:37 GMT, Sergey Bylokhov wrote: > An exception occurs when the main thread disposes of the frame while the > other thread still renders to it. The fix joins the main thread to other > threads, so we will dispose of the frame at the end only. Marked as reviewed by kizun

Re: RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Alexander Zvegintsev
On Mon, 10 May 2021 21:38:37 GMT, Sergey Bylokhov wrote: > An exception occurs when the main thread disposes of the frame while the > other thread still renders to it. The fix joins the main thread to other > threads, so we will dispose of the frame at the end only. Marked as reviewed by azveg

RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Sergey Bylokhov
An exception occurs when the main thread disposes of the frame while the other thread still renders to it. The fix joins the main thread to other threads, so we will dispose of the frame at the end only. - Commit messages: - Initial fix Changes: https://git.openjdk.java.net/jdk/pu

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-05-10 Thread Tejpal Rebari
On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari wrote: > Hi All, > Please review the following fix for jdk17. > > Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full > Screen when the System Preference -> General -> Prefer Tabs is set to "Full > Screen". It is also free

Integrated: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline

2021-05-10 Thread Jayathirth D V
On Tue, 4 May 2021 11:02:40 GMT, Jayathirth D V wrote: > We have many if else conditions to select OpenGL/Metal pipeline objects. > Apart from initialization phase we should not fetch these objects everytime > checking whether we are using OpenGL/Metal pipeline. This pull request has now been i

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

2021-05-10 Thread Jayathirth D V
On Mon, 10 May 2021 10:14:40 GMT, Jayathirth D V wrote: >> You can add a new abstract method to the parent class: getRenderQueue(), and >> override it in subclasses to call MTLRenderQueue/OGL.getInstance(); In this >> way, you can push to the parent more methods by calling just this new >> get

Re: RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

2021-05-10 Thread Jayathirth D V
On Fri, 7 May 2021 19:44:31 GMT, Sergey Bylokhov wrote: >> In dispose() we call validate which internally calls corresponding >> RenderQueue's of OpenGL/Metal, thats why it is not moved to CFLayer. >> For other getters since initialization of peer was happening in individual >> subclasses(which