RFR: 8266949: Check possibility to disable OperationTimedOut on Unix

2021-05-14 Thread Sergey Bylokhov
Our implementation of realSync on Unix is not straightforward, we try to move the awt root window and catch the ConfigureNotify. The problem is that the request to move the awt root window can be ignored, and it is possible that the notification will not come. In this case, we throw non-specifie

Re: RFR: 8182043: Access to Windows Large Icons [v7]

2021-05-14 Thread Alexey Ivanov
On Fri, 14 May 2021 19:46:03 GMT, Alexander Zuev wrote: >> Fix updated after first round of review. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Slight change of wording in javadoc > Fixed Win32ShellFolder2.getSystem

Re: RFR: 8182043: Access to Windows Large Icons [v7]

2021-05-14 Thread Alexander Zuev
> Fix updated after first round of review. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Slight change of wording in javadoc Fixed Win32ShellFolder2.getSystemIcon scaling issue - Changes: - all: https://git.openj

Re: RFR: 8182043: Access to Windows Large Icons [v4]

2021-05-14 Thread Alexander Zuev
On Fri, 14 May 2021 13:41:31 GMT, Alexey Ivanov wrote: >> I see - but still it has to be solved in the getShell32Icon method - which >> i'm going to do in a moment. > > `Win32ShellFolder2.getSystemIcon` is still affected, the return value should > be wrapped into MR-icon if its size is not equa

Re: RFR: 8182043: Access to Windows Large Icons [v6]

2021-05-14 Thread Alexander Zuev
On Fri, 14 May 2021 13:30:13 GMT, Alexey Ivanov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make getShell32Icon method return multi-resolition image in case of >> requested icon size and actual icon size mi

RFR: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"

2021-05-14 Thread Anton Litvinov
Hello, Could you please review the following fix for the bug specific to macOS. The bug consists in the fact that if the method "java.awt.print.Printable.print​(Graphics, PageFormat, int)" throws "java.awt.print.PrinterException" or "java.lang.RuntimeException" during the call "java.awt.print.

Re: RFR: 8182043: Access to Windows Large Icons [v4]

2021-05-14 Thread Alexey Ivanov
On Tue, 11 May 2021 21:34:59 GMT, Alexander Zuev wrote: >> No, it isn't wrapped: if `getShell32Icon` is called in `getIcon(final >> boolean getLargeIcon)`, the returned value is immediately returned to the >> caller, see lines 1157–1163 in the updated code: >> >> if (hI

Re: RFR: 8182043: Access to Windows Large Icons [v6]

2021-05-14 Thread Alexey Ivanov
On Tue, 11 May 2021 21:41:15 GMT, Alexander Zuev wrote: >> Fix updated after first round of review. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Make getShell32Icon method return multi-resolition image in case of > r

Re: RFR: 8182043: Access to Windows Large Icons [v4]

2021-05-14 Thread Alexey Ivanov
On Tue, 11 May 2021 19:36:12 GMT, Alexey Ivanov wrote: >> I will create a separate bug to track this - i do not know if library >> loading gets cached on some level and what impact on performance will we >> have if we release it every call. But i will check it out separately. > > Sure! I just w