On Tue, 18 May 2021 22:22:06 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Locale's class description modification
>
> src/java.base/share/classes/java/util/Locale.java line 462:
>
>> 460: *
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intends to flip the
> normalization towards the current codes, providing a system
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intends to flip the
>
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.security.manager=allow` when launched. This PR covers such
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP,
On Tue, 18 May 2021 18:38:52 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/java/security/AccessController.java line 877:
>>
>>> 875: @CallerSensitive
>>> 876: public static T doPrivileged(PrivilegedExceptionAction
>>> action,
>>> 877:
On Fri, 14 May 2021 21:26:33 GMT, Sergey Bylokhov wrote:
> Our implementation of realSync on Unix is not straightforward, we try to move
> the awt root window and catch the ConfigureNotify. The problem is that the
> request to move the awt root window can be ignored, and it is possible that
>
On Sun, 16 May 2021 01:29:59 GMT, Sergey Bylokhov wrote:
>> Our implementation of realSync on Unix is not straightforward, we try to
>> move the awt root window and catch the ConfigureNotify. The problem is that
>> the request to move the awt root window can be ignored, and it is possible
>>
On Tue, 18 May 2021 17:36:55 GMT, Alan Bateman wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Sun, 16 May 2021 01:29:59 GMT, Sergey Bylokhov wrote:
>> Our implementation of realSync on Unix is not straightforward, we try to
>> move the awt root window and catch the ConfigureNotify. The problem is that
>> the request to move the awt root window can be ignored, and it is possible
>>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Tue, 18 May 2021 15:19:21 GMT, Alan Bateman wrote:
>> It includes both:
>> ![Screen Shot 2021-05-18 at 8 41 11
>> AM](https://user-images.githubusercontent.com/35072269/118652730-dfb35400-b7b4-11eb-83ee-92be9136fea2.jpg)
>
> Thanks for checking, I assumed that was the case so wondering if it
On Tue, 18 May 2021 12:42:08 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/lang/SecurityManager.java line 315:
>>
>>> 313: *
>>> 314: * @since 1.0
>>> 315: * @deprecated The Security Manager is deprecated and subject to
>>> removal in a
>>
>> Javadoc will prefix, in bold,
On Tue, 18 May 2021 14:50:23 GMT, Alexander Zuev wrote:
> > The bug is a confidential issue. Either the bug should not be confidential
> > or this review should not be done here.
>
> I do not see any potential reason why this issue might be confidential. It is
> not security related, can be
On Tue, 18 May 2021 13:25:04 GMT, Pankaj Bansal wrote:
> Could you please give some details about how you have tested this?
I used the SwingSet2 first demo - internal frame - and made sure that
components that were previously reported as groups - internal frame, button
group and such - are
On Tue, 18 May 2021 09:30:28 GMT, Pankaj Bansal wrote:
> The bug is a confidential issue. Either the bug should not be confidential or
> this review should not be done here.
I do not see any potential reason why this issue might be confidential. It is
not security related, can be reproduced
On Tue, 18 May 2021 05:48:56 GMT, Alan Bateman wrote:
> The changes look okay but a bit inconsistent on where -Djava...=allow is
> inserted for tests that already set other system properties or other
> parameters. Not a correctness issue, just looks odd in several places, e.g.
>
>
On Tue, 18 May 2021 11:12:00 GMT, Daniel Fuchs wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>>
On Mon, 17 May 2021 08:22:59 GMT, Alexander Zuev wrote:
> Initial implementation.
Could you please give some details about how you have tested this?
-
PR: https://git.openjdk.java.net/jdk/pull/4046
On Tue, 18 May 2021 06:31:06 GMT, Alan Bateman wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
>
On Tue, 18 May 2021 00:29:21 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed documentation based on CSR review feedback
Marked as reviewed by
On Tue, 18 May 2021 09:05:10 GMT, Alexander Zuev wrote:
> Added accessibilityIndex function that correctly returns the index of a
> child in parent container
The bug is a confidential issue. Either the bug should not be confidential or
this review should not be done here.
-
PR:
Added accessibilityIndex function that correctly returns the index of a
child in parent container
-
Commit messages:
- 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example,
unable to navigate to all items, with VO on
Changes:
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
31 matches
Mail list logo