Integrated: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Alexander Zuev
On Mon, 24 May 2021 11:03:35 GMT, Alexander Zuev wrote: > Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. This pull request has now been integrated. Changeset: d86f9164 Author:Alexander Zuev URL: ht

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v2]

2021-05-24 Thread Pankaj Bansal
On Tue, 25 May 2021 06:36:27 GMT, Alexander Zuev wrote: >> Made all implementing classes return their roles directly. >> Change nullability attributes to the singular style across new classes. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the la

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v2]

2021-05-24 Thread Alexander Zuev
On Tue, 25 May 2021 05:38:19 GMT, Pankaj Bansal wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed old style nullability attributes in StaticTextAccessibility.h > > src/java.desktop/macosx/native/libawt_lwawt/

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v2]

2021-05-24 Thread Alexander Zuev
> Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Fixed old style nullability attributes in StaticT

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Pankaj Bansal
On Mon, 24 May 2021 11:03:35 GMT, Alexander Zuev wrote: > Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.h line 39: > 37: - (NSAcce

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Pankaj Bansal
On Mon, 24 May 2021 11:03:35 GMT, Alexander Zuev wrote: > Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h line 32: > 30: }; > 31:

Re: RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Pankaj Bansal
On Mon, 24 May 2021 11:03:35 GMT, Alexander Zuev wrote: > Made all implementing classes return their roles directly. > Change nullability attributes to the singular style across new classes. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CheckboxAccessibility.h line 32: > 30: }; > 31: -

Re: RFR: 8267521: Post JEP 411 refactoring: maximum covering > 50K [v3]

2021-05-24 Thread Weijun Wang
On Mon, 24 May 2021 09:00:07 GMT, Daniel Fuchs wrote: > Thanks for taking in my suggestions for FtpClient. I have also reviewed the > changes to java.util.logging and JMX. I wish there was a way to handle > doPrivileged returning void more nicely. Maybe component maintainers will be > able to

Integrated: 8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager

2021-05-24 Thread Weijun Wang
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote: > Please review the test changes for [JEP > 411](https://openjdk.java.net/jeps/411). > > With JEP 411 and the default value of `-Djava.security.manager` becoming > `disallow`, tests calling `System.setSecurityManager()` need > `-Djava.secu

Re: RFR: 8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager [v4]

2021-05-24 Thread Weijun Wang
> Please review the test changes for [JEP > 411](https://openjdk.java.net/jeps/411). > > With JEP 411 and the default value of `-Djava.security.manager` becoming > `disallow`, tests calling `System.setSecurityManager()` need > `-Djava.security.manager=allow` when launched. This PR covers such

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v4]

2021-05-24 Thread Weijun Wang
On Sun, 23 May 2021 16:35:43 GMT, Sean Mullan wrote: >> src/java.base/share/classes/java/lang/SecurityManager.java line 104: >> >>> 102: * method will throw an {@code UnsupportedOperationException}). If the >>> 103: * {@systemProperty java.security.manager} system property is set to >>> the >

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v4]

2021-05-24 Thread Weijun Wang
> Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 > The essential change for this JEP, incl

Integrated: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-24 Thread Alexander Zuev
On Tue, 18 May 2021 09:05:10 GMT, Alexander Zuev wrote: > Added accessibilityIndex function that correctly returns the index of a > child in parent container This pull request has now been integrated. Changeset: 49f622c9 Author:Alexander Zuev URL: https://git.openjdk.java.net/jdk/co

Re: RFR: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-24 Thread Pankaj Bansal
On Tue, 18 May 2021 09:05:10 GMT, Alexander Zuev wrote: > Added accessibilityIndex function that correctly returns the index of a > child in parent container Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4084

RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly

2021-05-24 Thread Alexander Zuev
Made all implementing classes return their roles directly. Change nullability attributes to the singular style across new classes. - Commit messages: - 8267066: New NSAccessibility peers should return they roles and subroles directly Changes: https://git.openjdk.java.net/jdk/pull/4

Re: RFR: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on

2021-05-24 Thread Alexander Zuev
On Thu, 20 May 2021 12:29:10 GMT, Pankaj Bansal wrote: > What I am asking is why the same issue is not observed in JList. In JList it is observed differently because there the multiple selection is allowed and because of that fever events about items selected/deselected and focus change being

Re: RFR: 8267521: Post JEP 411 refactoring: maximum covering > 50K [v3]

2021-05-24 Thread Daniel Fuchs
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote: >> The code change refactors classes that have a `SuppressWarnings("removal")` >> annotation that covers more than 50KB of code. The big annotation is often >> quite faraway from the actual deprecated API usage it is suppressing, and >> with