On Thu, 1 Apr 2021 12:48:52 GMT, Andrey Turbanov
wrote:
>> Looks like this change goes beyond of simple replacement of StringBuffer
>> with StringBuilder. Please update the description of the bug and PR
>> description.
>
> I've updated PR description, but I don't have rights to update JIRA.
On Mon, 29 Mar 2021 20:50:14 GMT, Andrey Turbanov
wrote:
> Found by IntelliJ IDEA inspection `Java | Java language level migration aids
> | Java 5 | 'StringBuffer' may be 'StringBuilder'`
> As suggested in
> https://github.com/openjdk/jdk/pull/1507#issuecomment-757369003 I've created
>
On Fri, 12 Mar 2021 15:44:39 GMT, Aleksey Shipilev wrote:
> SonarCloud reports:
> Remove or correct this "removeAll" call.
>
> void removeAll() {
> items.removeAll(items); // <--- here
> updateScrollbars();
> }
>
> Calling `rem
ification
> exceptions. `clear()` would be correct and more efficient.
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2974/files
- new: https
SonarCloud reports:
Remove or correct this "removeAll" call.
void removeAll() {
items.removeAll(items); // <--- here
updateScrollbars();
}
Calling `removeAll()` with the same collection risks concurrent modification
exceptions. `clear()` would be correct and more
On Tue, 3 Nov 2020 08:21:22 GMT, Magnus Ihse Bursie wrote:
> The variable BUILD_HEADLESS_ONLY is no longer set. And sun/applet does not
> exist anymore.
Looks fine and trivial.
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1031
On Wed, 7 Oct 2020 23:35:00 GMT, Sergey Bylokhov wrote:
>> As far as I can see, the only effect `volatile` has here is making sure the
>> successive calls to `checkEvent` eventually
>> get the updated value of `discardingMouseEvents`. This does not seem to
>> resolve the original race: calls
On Sat, 3 Oct 2020 00:03:07 GMT, Sergey Bylokhov wrote:
> The "discardingMouseEvents" flag in the SunDragSourceContextPeer class is
> used on the different threads without any
> synchronization.
As far as I can see, the only effect `volatile` has here is making sure the
successive calls to
On Fri, 18 Sep 2020 01:16:06 GMT, Sergey Bylokhov wrote:
> The list of client test groups in "TEST.groups" is synchronized with the list
> of othervm.dirs in "TEST.ROOT"
There seems to be the single test in that package, `DefaultMenuBarTest.java`.
It sets system properties and thus is
safer
