Re: Review request for 8146317: Memory leak in wcstombsdmp

2016-01-27 21:36 GMT-07:00 Ambarish Rapte : > Hi Alex, > This patch is committed, and 8146317 is resolved. Thanks! I didn't notice the commit because I was looking at the "dev" tree instead of the "client" tree. I will make sure to check both trees in the future. -Alex

Re: Review request for 8146317: Memory leak in wcstombsdmp

Ambarish, Prasanta, and Semyon have all approved this patch. Why is it not committed yet? -Alex

[PATCH resend3] 8146317: Fix memory leak in wcstombsdmp

# HG changeset patch # User Alex Henrie # Date 1448324612 25200 # Mon Nov 23 17:23:32 2015 -0700 # Node ID cbe4975f3f6ff997256340d7233f97ec93b5c034 # Parent 398904912c77deb6257c8d6b7bfa36192aeffe6a 8146317: Fix memory leak in wcstombsdmp If a character cannot be represented in the current

[PATCH resend2] Fix memory leak in wcstombsdmp

# HG changeset patch # User Alex Henrie # Date 1448316746 25200 # Mon Nov 23 15:12:26 2015 -0700 # Node ID c12ad61a6e05f4c6af14812a9049f46ddac542d2 # Parent 6dca8affef8a4566dfaa36faeb7a14fc4086843a Fix memory leak in wcstombsdmp If a character cannot be represented in the current locale

[PATCH resend] Fix memory leak in wcstombsdmp

# HG changeset patch # User Alex Henrie # Date 1448316746 25200 # Mon Nov 23 15:12:26 2015 -0700 # Node ID 50c079e1d06b196368da9edeb4ba9c8e9b8cf913 # Parent 8c9484fe1bb22b13e873ef8fcaeeff234e4dabca Fix memory leak in wcstombsdmp If a character cannot be represented in the current locale

[PATCH] Fix memory leak in wcstombsdmp

# HG changeset patch # User Alex Henrie # Date 1448324612 25200 # Mon Nov 23 17:23:32 2015 -0700 # Node ID af70128e2f70c246dae3a8d51e70fa097c97a552 # Parent e9b7db0341f63a8835e5d7da155683c004454b25 Fix memory leak in wcstombsdmp If a character cannot be represented in the current locale

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

2014-09-03 14:40 GMT-06:00 Alexander Zvegintsev : > Actually no action needed from your side, I've created a backport for jdk7 > [1], and it looks like they already have a decision. > > [1] https://bugs.openjdk.java.net/browse/JDK-8057158 OK. Thanks again for all the help! -Alex

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

2014-09-03 7:50 GMT-06:00 Alexander Zvegintsev : > Sure, your fix should be available in 8u40, as for 7u-dev it will be decided > by sustaining team. Thanks! So, should I send the JDK 7 patch to the jdk7u-dev mailing list for their consideration? -Alex

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

Thank you for pushing my patch to JDK 9! Can this fix be backported to Java 8 and Java 7 as well? The diff below applies cleanly to jdk8u-dev/jdk and jdk7u-dev/jdk. -Alex diff --git a/src/solaris/classes/sun/awt/X11/XWindow.java b/src/solaris/classes/sun/awt/X11/XWindow.java --- a/src/solaris/cl

[PATCH] Fix right-click detection in Linux and Solaris

With this patch applied, only clicks on the mouse's right button and not clicks to the mouse's forward or back buttons trigger a context menu (MouseEvent.isPopupTrigger() == true). Class XWindow tried to map physical mouse buttons to logical mouse buttons, but this unnecessary because that mapping