Re: 8177137: 8175293 breaks Windows build on Vs2010

The fix looks good to me. Thanks, Alexandr. On 3/20/2017 6:36 PM, Thomas Stüfe wrote: Hi all, please review this tiny fix: https://bugs.openjdk.java.net/browse/JDK-8177137 http://cr.openjdk.java.net/~stuefe/webrevs/8177137-8175293-breaks-windows-build-on-vs2010/webrev.00/webrev/

Re: [9] Review Request: 8160270 dual-screen issue with java.awt.Choice

It all looks plausible .. so +1 assuming no problems with the tests. -phil. On 03/16/2017 12:20 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 3/16/2017 7:44 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. This bug was caused by the change in JDK81

Re: Java_Swings/AWT Native Interface give error in 32-bit window OS

Forwarded to the awt-dev alias. Thanks, Alexandr. On 3/7/2017 8:50 AM, mahendrag gajera wrote: Hello All, I follow step as mention in below link and create .dll and java application. https://en.wikibooks.org/wiki/Java_Swings/AWT. Every things work fine in window 7/8 64-bit OS. In

[9] Review request for 8175301 Java GUI hangs on Windows when Display set to 125%

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8175301 webrev: http://cr.openjdk.java.net/~alexsch/8175301/webrev.00 D3DSurfaceData.swapBuffers() is updated to scale passed bounds on HiDPI display. Thanks, Alexandr.

Re: [9] Review request for 8176097 Window set location to a display with different DPI does not properly work

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8176097/webrev.02 - sysX and sysY values are kept the the same as the passed x and y values. Thanks, Alexandr. On 3/3/2017 8:19 PM, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix: http

Re: [9] Review request for 8176097 Window set location to a display with different DPI does not properly work

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8176097/webrev.01 - sysX and sysY values are updated in the same way as x and y in the WWindowPeer.setBounds(...) method. Thanks, Alexandr. On 3/2/2017 10:13 PM, Sergey Bylokhov wrote: Hi, Alex. Looks like

[9] Review request for 8176097 Window set location to a display with different DPI does not properly work

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8176097 webrev: http://cr.openjdk.java.net/~alexsch/8176097/webrev.00 Suppose the system has two displays with different DPI. A user can create a window on the first screen and set the windows bounds from

Re: [9] Review Request: 8176009 The awt robot use incorrect location in a multi-screen environment

The fix looks good to me. Thanks, Alexandr. On 3/1/2017 4:51 PM, Alexander Zvegintsev wrote: +1 -- Thanks, Alexander. On 01.03.2017 12:55, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. The fix reverts the changes which were introduced in JDK-8145784(the test

Re: [9] Review Request: 8168307 Toolkit.getScreenSize() returns incorrect size on unix in multiscreen systems

The fix looks good to me. Thanks, Alexandr. On 2/28/2017 8:21 PM, Sergey Bylokhov wrote: Hi, Alexander. The XToolkit.getDefaultScreenWidth()/getDefaultScreenHeight() methods are supposed to return the width/height in the user space. Could you rename them and the screenWidth/screenHeight

Re: [9] Review Request: 8168307 Toolkit.getScreenSize() returns incorrect size on unix in multiscreen systems

The XToolkit.getDefaultScreenWidth()/getDefaultScreenHeight() methods are supposed to return the width/height in the user space. Could you rename them and the screenWidth/screenHeight variables to emphasize the fact that now they work with values in the device space? Thanks, Alexandr. On

[9] Review request for 8175293 Window size is not updated after setting location to display with different DPI

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8175293 webrev: http://cr.openjdk.java.net/~alexsch/8175293/webrev.00 The fix for the JDK-8147440 shifts a window position while it is dragging from one display to another. This causes that sometimes there

Re: [9] Review request for JDK-8173876 Fast precise scrolling and DeltaAccumulator fix for macOS Sierra 10.12.2

The fix looks good to me. Thanks, Alexandr. On 2/7/2017 8:17 PM, Sergey Malenkov wrote: Hello, Could you please review the following fix: bug: http://bugs.openjdk.java.net/browse/JDK-8173876 webrev: http://cr.openjdk.java.net/~alexsch/sergey.malenkov/8173876/webrev-all.00 It improves

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

e we finalize the signature and behavior, I shall update the patch and send it for review. Regards, Prem *From:*Philip Race *Sent:* Wednesday, January 25, 2017 11:44 PM *To:* Alexandr Scherbatiy *Cc:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net <m

Re: [9] Review request for 8147440 HiDPI (Windows): Swing components have incorrect sizes after changing display resolution

- changing window size according to DPI when a window is moved from one display to another is added - window size updating is moved to the native side Thanks, Alexandr. On 10/25/2016 5:32 PM, Sergey Bylokhov wrote: On 25.10.16 14:11, Alexandr Scherbatiy wrote: Could you review the

Re: RFR: 8173409: make setMixingCutoutShape public and remove jdk.desktop

The fix looks good to me. Thanks, Alexandr. On 1/31/2017 11:28 AM, Sergey Bylokhov wrote: Looks fine. Bug: https://bugs.openjdk.java.net/browse/JDK-8173409 Webrev: http://cr.openjdk.java.net/~prr/8173409/ In OpenJDK the jdk.desktop module (not java.desktop) has only one method. It is the

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

Prem *From:*Alexandr Scherbatiy *Sent:* Friday, January 20, 2017 4:50 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 1/19/2017 3:57 PM, Prem Balakrishnan wrote: H

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

I Display There should be mention that this argument value is ignored when a screenshot is taken on non-HiDPI display Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Thursday, January 12, 2017 2:39 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

The fix looks good to me. Thanks, Alexandr. On 12/19/2016 10:29 PM, Sergey Bylokhov wrote: 19 дек. 2016 г., в 22:28, Sergey Bylokhov > написал(а): Hello. Please review an updated version of the fix. - The comments are

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

esolution which returns Best Resolution Image while capturing screen using CGWindowListCreateImage() method. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Tuesday, January 10, 2017 1:08 AM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race *Subject:* Re: Review Re

Re: [9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data flavor

tently on Windows and Mac. Regards, Ajit *From:*Alexandr Scherbatiy *Sent:* Wednesday, September 14, 2016 8:33 PM *To:* Ajit Ghaisas; Yuri Nesterenko; awt-dev@openjdk.java.net *Subject:* Re: [9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data

Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

The fix looks good to me. Thanks, Alexandr. On 11/23/2016 5:20 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Support of WM_MOUSEHWHEEL for Swing was added (AWT components were not touched), which mostly the code symmetric to the WM_MOUSEWHEEL, except that I changed the

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

added an explanation what is the content of the first and the second resolution variant. Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Thursday, November 03, 2016 4:05 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: Review Request JDK:-8162959

Re: RFR: 8155874: Fix java.desktop deprecation warnings about Class.newInstance

The fix looks good to me. Thanks, Alexandr. On 11/7/2016 10:12 PM, Sergey Bylokhov wrote: Looks fine. On 07.11.16 21:49, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8155874 Webrev: http://cr.openjdk.java.net/~prr/8155874/ This hits all across the desktop module, hence the

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

The fix looks good to me. Thanks, Alexandr. On 10/31/2016 9:31 PM, Jim Graham wrote: Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews.

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

On 11/2/2016 1:57 PM, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch. http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.01/ Added a new public API “*Image createHiDPIScreenCapture(Rectangle screenRect)”.*

Re: Review Request: 8159132 : [PIT][TEST_BUG] java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java fails

The fix looks good to me. Thanks, Alexandr. On 10/27/2016 2:46 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8159132 Webrev: http://cr.openjdk.java.net/~pkbalakr/8159132/webrev.00/

Re: [9] Review request for 8147440 HiDPI (Windows): Swing components have incorrect sizes after changing display resolution

. On 3/21/2016 11:33 PM, Alexandr Scherbatiy wrote: On 2/10/2016 5:32 AM, Sergey Bylokhov wrote: On 05.02.16 10:52, Alexandr Scherbatiy wrote: The first approach is to rescale only frame size on native level so newNativeWindow.size = newScale * javaWindow.size What location

Re: Review Request for 8167288: [TEST_BUG] Consistent failure on Unity of WarningWindowDisposeTest.java

The fix looks good to me. Thanks, Alexandr. On 10/17/2016 9:46 AM, Semyon Sadetsky wrote: Looks good. --Semyon On 10/17/2016 5:54 AM, Ambarish Rapte wrote: Hi, Please review this test bug fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8167288

Re: [9] Review request: 8167159 [PIT][TEST_BUG] java/awt/image/multiresolution/MultiResolutionIcon/MultiResIconTest.java

The Windows OS is not listed in the test @requires tag but the test should work on Windows as well. Thanks, Alexandr. On 10/14/2016 7:02 PM, Andrey Rusakov wrote: Hello, please review the fix http://cr.openjdk.java.net/~arusakov/8167159/webrev.00 for the issue

[8u-dev] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

Just corrected the subject to 8u-dev. Thanks, Alexandr. 05.10.2016 22:46, Alexandr Scherbatiy пишет: Hello, Could you review the backport of the fix to the JDK8u-dev: http://cr.openjdk.java.net/~alexsch/8166591/webrev-jdk8.00 This is just the same fix as for the JDK 9 (see [1

[8-dev] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

Hello, Could you review the backport of the fix to the JDK8u-dev: http://cr.openjdk.java.net/~alexsch/8166591/webrev-jdk8.00 This is just the same fix as for the JDK 9 (see [1]). There are some style differences between JDK 8u-dev and JDK 9 which I needed to merge manually. All logic

Re: [9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data flavor

On 9/14/2016 1:14 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8134612 Issue : In this test, exportToClipboard() does not export anything to the clipboard due to incorrect text passed to TransferHandler. Obviously, when we do clipboard.getData() - it throws

Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some ambiguity for Window.setIconImages

.01/> Regards, Rajeev Chamyal *From:*Alexandr Scherbatiy *Sent:* 05 September 2016 16:04 *To:* Rajeev Chamyal; Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some amb

Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some ambiguity for Window.setIconImages

On 9/2/2016 2:37 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8149371 Webrev: http://cr.openjdk.java.net/~rchamyal/8149371/webrev.00/ Issue:

Re: RFR (XXS) 8165269: (doc) Toolkit.isDynamicLayoutActive(): orphan '0' in first sentence

The fix looks good to me. Thanks, Alexandr. On 9/1/2016 11:46 PM, Iris Clark wrote: Hi. Let's try this again. Please review the following one character change to remove an unnecessary ')' in the first sentence of Toolkit.isDynamicLayoutActive(). The matching '(' was removed during

Re: [9] Review request for 8159432: [hidpi] Linux: display-wise scaling factor issues

The fix looks good to me. The bug id in the email subject should be updated to 8163100. Thanks, Alexandr. On 8/30/2016 4:26 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163100 webrev:

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

should have a simple description in other case the compilation fails because of enabled javadoc warning errors. Thanks, Alexandr. Thank you in advance. With Regards, Avik Niyogi On 29-Aug-2016, at 5:55 pm, Alexandr Scherbatiy <alexandr.scherba...@oracle.com <mailto:alex

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

On 8/29/2016 9:52 AM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviver reviews. *http://cr.openjdk.java.net/~aniyogi/8138771/webrev.01/ * There is the {@inheritDoc} which

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

-Original Message- From: Alexandr Scherbatiy Sent: 25 August 2016 22:07 To: Rajeev Chamyal; Philip Race Cc: awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention On 8/22/2016 2:13 PM, Rajeev Chamyal wrote: Hello

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

. Regards, Rajeev Chamyal -Original Message- From: Alexandr Scherbatiy Sent: 25 August 2016 22:14 To: Rajeev Chamyal Cc: Phil Race; awt-dev@openjdk.java.net; Sergey Bylokhov; Victor Dyakov Subject: Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention Hi

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

of 'as' variable which is of type AccelSurface object to SurfaceData is always VALID. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Wednesday, August 17, 2016 4:42 PM *To:* Prem Balakrishnan; Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey Bylokhov *Subject:* Re: Review Request: JDK-8144735 [hidpi

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

/~pkbalakr/8144735/webrev.02/ <http://cr.openjdk.java.net/%7Epkbalakr/8144735/webrev.02/> Is it always true that the 'as' variable which has type AccelSurface in the fix is always instance of SurfaceData? Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Tuesday, Aug

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

fter setting the scaled image sizes in the fix? - Region.clipScale() which is used in many places rounds values. The usual rule is to use Math.floor() for image coordinates rounding and Math.ceil() for sizes. Should the same rule be applicable here? Thanks, Alexandr. Regards, Prem *Fr

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

ace; Sergey Bylokhov *Subject:* Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention On 10/08/16 19:24, Alexandr Scherbatiy wrote: On 8/9/2016 11:18 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

On 8/9/2016 11:18 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8151787 Webrev: http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/ Issue: Currently

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

Calling getNativeScaleFactor(NULL) leads that "com.ubuntu.user-interface" "scale-factor" and "com.canonical.Unity.Interface" "text-scale-factor" properties are just skipped in getDesktopScale(char *output_name) method from systemScale.c file. Should there be provided some default output

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

On 8/3/2016 10:04 AM, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, *Bug:*https://bugs.openjdk.java.net/browse/JDK-8144735 *Webrev:*http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.00/ *Issue:*

Re: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 12:03 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, *Bug:* https://bugs.openjdk.java.net/browse/JDK-8144709 *Webrev:* http://cr.openjdk.java.net/~pkbalakr/8144709/webrev.00/

Re: [9] Review Request JDK-8144594 HiDPI: awt.Choice looks improperly (Win 8)

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 11:21 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8144594 Webrev : http://cr.openjdk.java.net/~rchamyal/8144594/webrev.00

Re: [9] Review request for 8161273: [hidpi] The frame insets size is wrong on Linux HiDPI because it is not scaled.

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 9:34 AM, Semyon Sadetsky wrote: On 7/19/2016 2:36 PM, Alexandr Scherbatiy wrote: On 7/15/2016 10:24 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8036915 webrev: http

Re: [9] Review request for 8161195: Regression: closed/javax/swing/text/FlowView/LayoutTest.java

The fix looks good to me. Thanks, Alexandr. On 7/14/2016 1:05 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161195 webrev: http://cr.openjdk.java.net/~ssadetsky/8161195/webrev.00/ The IMN_SETCOMPOSITIONWINDOW message is

Re: [9] Review request for 8161007: GPL header missing comma in year - not swapped in licensee bundles

The fix looks good to me. Thanks, Alexandr. On 7/15/2016 2:46 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161007 webrev: http://cr.openjdk.java.net/~ssadetsky/8161007/webrev.00/ --Semyon

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

The fix looks good to me. Thanks, Alexandr. On 7/16/2016 2:55 AM, David Holmes wrote: Can I please get someone from AWT to approve this. Thanks, David On 14/07/2016 2:25 PM, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we

Re: [9] Review Request for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

The fix looks good to me. Thanks, Alexandr. On 7/14/2016 2:47 PM, Alexander Zvegintsev wrote: Hi Semyon, The fix looks good to me. Thanks, Alexander. On 07/13/2016 01:28 PM, Semyon Sadetsky wrote: Please review an updated version of the fix:

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

is used in some places. Please review the modified code. http://cr.openjdk.java.net/~mhalder/8160266/webrev.01/ <http://cr.openjdk.java.net/%7Emhalder/8160266/webrev.01/> Thanks, Manajit On 08-Jul-2016, at 3:57 pm, Alexandr Scherbatiy <alexandr.scherba...@oracle.com <mailto:alex

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

The fix looks good to me. Thanks, Alexandr. On 7/12/2016 6:04 PM, Semyon Sadetsky wrote: Looks good to me. --Semyon On 12.07.2016 17:42, Alexander Zvegintsev wrote: Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

The fix looks good to me. Thanks, Alexandr. On 7/12/2016 3:12 PM, Robin Stevens wrote: Hello Mikhail, thanks for the review. Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ? I have no commit rights, so I cannot do it myself.

Re: Review request for 4908075: Press shift and another key using robot does not trigger events properly

The fix looks good to me. Thanks, Alexandr. On 7/8/2016 3:09 PM, Oliver Bendig wrote: Ping It would be very nice if somebody could have a look at this webrev. Thanks and kind regards, Oliver Oliver Bendig hat am 29. Juni 2016 um 15:54 geschrieben: Hi, here is

Re: Taking screenshots on x11 composite desktop produce wrong result

The fix looks good to me. Thanks, Alexandr. On 7/11/2016 6:02 PM, Mario Torre wrote: On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy <alexandr.scherba...@oracle.com> wrote: On 7/4/2016 3:14 PM, Mario Torre wrote: On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre <neug...@redhat.c

Re: Review request for 8143064 Icons are not properly rendered with Windows L on HiDPI display

/screenshots/checkbox-compare-00.png [2] http://cr.openjdk.java.net/~alexsch/8143064/screenshots/combobox-compare-00.png Thanks, Alexandr. --Semyon On 05.07.2016 16:53, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143064/webrev.02

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

Is it possible to get rid of the RobotUtilities class? Methods like RobotUtilities.pressKey(int num)/releaseKey(int num) are just direct calls to the corresponding methods in Robot. Other necessary methods can be added to test/java/awt/regtesthelpers/Util.java Thanks, Alexandr. On 7/7/2016

Re: Taking screenshots on x11 composite desktop produce wrong result

On 7/4/2016 3:14 PM, Mario Torre wrote: On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote: Ping? Ping Ping? Just a question. The isGtkSupported is moved to be a local variable. It seems its value can't be changed in the 'if' condition on the line 60. Thanks,

Re: [8] Review request JI-9041413: [macosx]"text/uri-list" dataflavor concats the first two strings

on this email, correct the bug id and provide the webrev link. Thanks, Alexandr. Robin On Thu, Jul 7, 2016 at 9:36 AM, Alexandr Scherbatiy <alexandr.scherba...@oracle.com <mailto:alexandr.scherba...@oracle.com>> wrote: The issue is recorded under id JDK-8160941 &q

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 11:46 PM, Alexander Zvegintsev wrote: Still looks good. -- Thanks, Alexander. On 06.07.2016 21:42, Semyon Sadetsky wrote: Thanks, Alexander. Please see the updated webrev http://cr.openjdk.java.net/~ssadetsky/8149115

Re: [8] Review request JI-9041413: [macosx]"text/uri-list" dataflavor concats the first two strings

The issue is recorded under id JDK-8160941 "text/uri-list" dataflavor concats the first two strings https://bugs.openjdk.java.net/browse/JDK-8160941 The webrev is uploaded to http://cr.openjdk.java.net/~alexsch/robin.stevens/8160941/webrev.00 Thanks, Alexandr. On 7/7/2016

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

, "g_settings_schema_has_key"), NULL); CHECH_NULL_RETURN(fp_g_settings_new_full = dlsym(lib_handle, "g_settings_new_full"), NULL); On 7/6/16 5:27 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 4:46 PM, Semyon Sadetsky wrote:

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Thanks, Alexandr. On 7/6/2016 4:46 PM, Semyon Sadetsky wrote: On 7/6/2016 12:26 PM, Alexandr Scherbatiy wrote: On 7/5/2016 9:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8149115 webrev: http

Re: Review Request For 8160764: [TEST_BUG] java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java

The fix looks good to me. Thanks, Alexandr. On 7/6/2016 3:10 PM, Ambarish Rapte wrote: Hi, Please review this test bug fix, Webrev: http://cr.openjdk.java.net/~arapte/8160764/webrev.00/

Re: [9] Review request for 8159374 : Taskbar.setIconBadge() spec omits mention of exception for ICON_BADGE_TEXT feature

). If this is not the acceptable solution, we might consider to add setIconBadge(long badge) method. -- Thanks, Alexander. On 07/06/2016 10:25 AM, Alexandr Scherbatiy wrote: On 7/5/2016 5:54 PM, Alexander Zvegintsev wrote: We have two cases: 1. Underlying system(Linux) supports only numbers

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

On 7/5/2016 9:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8149115 webrev: http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.00/ Currently the hidpi support on linux only reads GDK_SCALE environment variable to get the

Re: [9] Review request for 8159374 : Taskbar.setIconBadge() spec omits mention of exception for ICON_BADGE_TEXT feature

, Alexandr. On 7/5/16 5:32 PM, Alexandr Scherbatiy wrote: On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8159374 Should the "checkFeatureSu

Re: [9] Review request for 8155515 : Desktop.moveToTrash() javadoc issue

The fix looks good to me. Thanks, Alexandr. On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8155515/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8155515

Re: Review request for 8143064 Icons are not properly rendered with Windows L on HiDPI display

requests the multi-resolution image size which leads that the base resolution image is recreated each time. I fixed it overridden the getWidth()/getHeight() methods. Thanks, Alexandr. Yet another question: why not use the actual scaling factor for the resolution variant instead of fixed 2

Re: [9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

The fix looks good to me. Thanks, Alexandr. On 7/3/2016 10:08 PM, Manajit Halder wrote: Hi Alexandr, Thank you for your review comment. I have changed the if condition to chars.trim().isEmpty(). Please review the modified code: http://cr.openjdk.java.net/~mhalder/7156316/webrev.01/

Re: [9] Review request for 8160623: [PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java

The fix looks good to me. Thanks, Alexandr. On 6/30/2016 5:38 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160623 webrev: http://cr.openjdk.java.net/~ssadetsky/8160623/webrev.00/ This a regression from JDK-8139189. The wchar

Re: [9] Review request for JDK-8160650: Couple awt and swing tests have wrong require jtreg arguments

The fix looks good to me. Thanks, Alexandr. On 6/30/2016 4:01 PM, mikhail cherkasov wrote: Hi all, jbs: https://bugs.openjdk.java.net/browse/JDK-8160650 webrev:http://cr.openjdk.java.net/~mcherkas/8160650/9/webrev/ Couple awt and swing tests have wrong require jtreg arguments, the following

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

On 6/28/2016 11:14 AM, Manajit Halder wrote: Hi All, Gentle remainder. Please review the changes. It is better to use "if (leftAltKeyPressed)" instead of "if (leftAltKeyPressed == YES)" and "if (!altGRPressed)" instead of "if (altGRPressed == NO)". Thanks, Alexandr. Thanks, Manajit

Re: [9] Review request for 8117886: There is no tooltip while moving the mouse on the tray icon.

On 6/29/2016 7:55 PM, Semyon Sadetsky wrote: Hi Alexander, On 6/29/2016 2:27 PM, Alexandr Scherbatiy wrote: On 6/14/2016 5:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8117886 webrev: http://cr.openjdk.java.net/~ssadetsky

Re: Review request for 8143064 Icons are not properly rendered with Windows L on HiDPI display

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143064/webrev.01 The MultiResolutionImage image is used for the icons painting. Thanks, Alexandr. On 11/16/2015 7:07 PM, Sergey Bylokhov wrote: Hi, Alexander. 109 AffineTransform tx = ((Graphics2D)

Re: [9] Review request for 8117886: There is no tooltip while moving the mouse on the tray icon.

On 6/14/2016 5:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8117886 webrev: http://cr.openjdk.java.net/~ssadetsky/8117886/webrev.00/ gnome3 DE got a new DE notifications bar, so the tooltips for tray icons have gone. Just

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

The change looks good to me. Thanks, Alexandr. On 6/17/2016 4:54 PM, Volker Simonis wrote: On Fri, Jun 17, 2016 at 3:40 PM, Alexandr Scherbatiy <alexandr.scherba...@oracle.com> wrote: On 6/17/2016 4:17 PM, Lindenmaier, Goetz wrote: Hi Alexandr, yes, you are right, the test you m

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

other way almost all AWT/Swing tests should be marked by "headful" keyword. Thanks, Alexandr. Best regards, Goetz. -----Original Message- From: Alexandr Scherbatiy [mailto:alexandr.scherba...@oracle.com] Sent: Freitag, 17. Juni 2016 14:53 To: Volker Simonis <volke

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

On 6/17/2016 11:36 AM, Volker Simonis wrote: On Thu, Jun 16, 2016 at 5:55 PM, Alexandr Scherbatiy <alexandr.scherba...@oracle.com> wrote: On 6/16/2016 5:40 PM, Lindenmaier, Goetz wrote: Hi, we have test machines without X server. On these many of the jdk jtreg tests fail with a he

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

On 6/16/2016 5:40 PM, Lindenmaier, Goetz wrote: Hi, we have test machines without X server. On these many of the jdk jtreg tests fail with a headless exception. We grepped for this exception in the test output and identified about 450 tests. In these tests, we added with another script

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

The fix looks good to me. Thanks, Alexandr. On 6/9/2016 12:43 PM, Sergey Bylokhov wrote: +1 On 08.06.16 10:57, Hendrik Schreiber wrote: Hey Alexandr, On Jun 7, 2016, at 17:44, Alexandr Scherbatiy <alexandr.scherba...@oracle.com> wrote: I slightly updated your fix to return a

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

The fix looks good to me. Thanks, Alexandr. On 6/9/2016 8:58 PM, Daniil Titov wrote: Thank you, Mandy! The long line is corrected. Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.03 http://cr.openjdk.java.net/~dtitov/8156960/webrev.03 Bug:

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

Hello Hendrik, I slightly updated your fix to return a multi-resolution image with base icon size when icon size is greater than the real icon size. This allows to draw a high-resolution icon to the same bounds on JOptionPane.

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

be done in 8u. -phil. On 5/30/16, 4:22 AM, Alexandr Scherbatiy wrote: On 5/28/2016 2:20 AM, Phil Race wrote: -Phil. On May 27, 2016, at 2:37 PM, Alexandr Scherbatiy <alexandr.scherba...@oracle.com> wrote: On 5/28/2016 12:23 AM, Alexandr Scherbatiy wrote: The following article claims tha

Re: [PATCH] 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

On 5/30/2016 9:55 PM, Sergey Bylokhov wrote: On 30.05.16 21:48, Alexandr Scherbatiy wrote: But the patch for the test definitely also can be contributed. I have loaded it to: http://cr.openjdk.java.net/~alexsch/robin.stevens/8158178/webrev.00 What about jdk8? It seems it is affected also

Re: [PATCH] 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

Hello Robin, Your bug report has been recorded under id: JDK-8158178 java.awt.SplashScreen.getSize() returns incorrect size for high dpi splash screens https://bugs.openjdk.java.net/browse/JDK-8158178 Thank you for the contribution. The described issue has been fixed in JDK

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

On 5/28/2016 2:20 AM, Phil Race wrote: -Phil. On May 27, 2016, at 2:37 PM, Alexandr Scherbatiy<alexandr.scherba...@oracle.com> wrote: On 5/28/2016 12:23 AM, Alexandr Scherbatiy wrote: The following article claims that DPI virtualization of not DPI–aware applications is availabl

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

On 5/28/2016 12:23 AM, Alexandr Scherbatiy wrote: The following article claims that DPI virtualization of not DPI–aware applications is available from Windows Vista: https://msdn.microsoft.com/en-us/library/windows/desktop/dn469266%28v=vs.85%29.aspx I just tried to set dpiAware=false

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

ing API is something we should also be considering but I don't know that this bug is the place to address that change which may cause more problems as well as fix some .. -phil. On 05/27/2016 11:14 AM, Alexandr Scherbatiy wrote: On 5/27/2016 8:14 PM, Phil Race wrote: From what I read on the

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

or later by now. Of course you will need to find a way to test this hypothesis : probably on a windows 10 desktop with 125% scaling to see what happens with the Win L -phil. On 05/27/2016 09:44 AM, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net

[8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8157838 webrev: http://cr.openjdk.java.net/~alexsch/8157838/webrev.00 This is the regression from the fix JDK-8076545 in the JDK 8u. There was a request JDK-8152980 to backport the fix to JDK 8u because a

Re: [9] Review request for 8157163: AWT FileDialog does not inherit icon image from parent Frame

The fix looks good to me. Thanks, Alexandr. On 5/24/2016 2:05 PM, Sergey Bylokhov wrote: Looks fine. As a following fix we can try to implement setSize as well. On 24.05.16 9:18, Semyon Sadetsky wrote: It seems sensible to add it: http://cr.openjdk.java.net/~ssadetsky/8157163/webrev.01/

Re: [9] Review request for 8075516: Deleting a file from either the open or save java.awt.FileDialog hangs.

The fix looks good to me. Thanks, Alexandr. On 5/20/2016 6:22 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8075516 webrev: http://cr.openjdk.java.net/~ssadetsky/8075516/webrev.00/ In Windows 8 OFN dialog starts to use COM

Re: [9] Review request for 8139189: VK_OEM_102 dead key detected as VK_UNDEFINED

The fix looks good to me. Thanks, Alexandr. On 5/17/2016 12:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8139189 webrev: http://cr.openjdk.java.net/~ssadetsky/8139189/webrev.00/ The Programmer Dvorak keyboard layout uses

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

The fix looks good to me. Thanks, Alexandr. On 5/13/2016 9:53 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8022810 webrev: http://cr.openjdk.java.net/~ssadetsky/8022810/webrev.00/ Xrandr's XRRGetScreenInfo cannot be used to get

Re: Review request for 6429675: getMaximumsize() size of the frame less than the minimumsize of Frame.

The fix looks good to me. Thanks, Alexandr. On 5/5/2016 1:55 PM, Sergey Bylokhov wrote: Looks fine. On 29.04.16 17:09, Ambarish Rapte wrote: Hi, Please review the fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-6429675

  1   2   3   >