Re: [9] Review request for JDK-8160453: [macosx] scary native stack trace in closed/java/awt/FileDialog/FileDialogBufferOverflowTest/FileNameTest.java

. This is just a recommendation though. With Regards, Avik Niyogi > On 10-Nov-2016, at 11:00 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > Kindly review the fix for JDK9. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8160453 > <http

Re: [9] Review request for JDK-8165680: [macosx] Enhance handling of UTF-8 characters in CDataTransfer.java

ed to the issue > https://bugs.openjdk.java.net/browse/JDK-8156099 > <https://bugs.openjdk.java.net/browse/JDK-8156099>. > > Regards, > Manajit > >> On 10-Nov-2016, at 3:40 pm, Avik Niyogi <avik.niy...@oracle.com >> <mailto:avik.niy...@oracle.com>> wrote:

Re: [9] Review request for JDK-8165680: [macosx] Enhance handling of UTF-8 characters in CDataTransfer.java

Code change looks good to me. But just a query, any test cases that fail before the enhancement or this is purely cosmetic? Does charset lookup affect performance? With Regards, Avik Niyogi > On 07-Nov-2016, at 8:53 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: >

Re: [9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

Looks good to me. > On 03-Nov-2016, at 6:24 pm, Sergey Bylokhov > wrote: > > Looks fine. > > On 03.11.16 14:13, Manajit Halder wrote: >> Hi Sergey, >> >> Thank you for the review comment. Code is modified as per the comment. >> Please review the modified webrev: >>

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. cr.openjdk.java.net/~aniyogi/8138771/webrev.05/ <http://cr.openjdk.java.net/~aniyogi/8138771/webrev.05/> Thank you in advance. With Regards, Avik Niyogi > On 28-Oct-2016, at 1:18 am, J

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.04/ <http://cr.openjdk.java.net/~aniyogi/8138771/webrev.04/> Thank you in advance. With Regards, Avik Niyogi > On 27-Oct-2016, at 2:3

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviver reviews. cr.openjdk.java.net/~aniyogi/8138771/webrev.03/ <http://cr.openjdk.java.net/~aniyogi/8138771/webrev.03/> Thank you in advance. With Regards, Avik Niyogi

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

Looks good to me. > On 06-Oct-2016, at 4:20 pm, Sergey Bylokhov > wrote: > > Looks fine. > > On 05.10.16 12:57, Manajit Halder wrote: >> Hi Sergey, >> >> Thanks for the comments. Please review the updated webrev. >>

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/> Thank you in advance. With Regards, Avik Niyogi > On 29-Aug-2016, a

Re: Swing Dev>[9] Review Request JDK-8161913 [PIT] java/awt/Window/8159168/SetShapeTest.java mostly fails

Looks good to me. With Regards, Avik Niyogi > From: Alexandr Scherbatiy > Sent: 16 August 2016 22:55 > To: Rajeev Chamyal; Sergey Bylokhov; awt-dev@openjdk.java.net > <mailto:awt-dev@openjdk.java.net> > Subject: Re: Swing Dev>[9] Review Request JDK-8161913 [PIT] &

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

Hi, The fix looks good to me. A small query though, line 281 - 290 is required at that position, looks like it was moved. With Regards, Avik Niyogi > From: Manajit Halder > Sent: Monday, June 20, 2016 1:56 AM > To: Sergey Bylokhov; Semyon Sadetsky > Cc: awt-dev@openjdk.java.net <

Re: [9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention

Message- > From: Rajeev Chamyal > Sent: 02 May 2016 14:24 > To: Hendrik Schreiber > Cc: awt-dev@openjdk.java.net; Avik Niyogi > Subject: Re: [9] Review request for JDK-8151787 Unify the HiDPI > splash screen image naming convention > > Hello Hendrik, > > Than

Re: [9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi > On 14-Mar-2016, at 2:42 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi Semyon & Avik, > > Thanks to both of you for the review. > > Please review the modified the code. > http://c

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi > On 09-Mar-2016, at 7:13 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > Please review webrev.01 updated with Avik’s review comments. > > http://cr.openjdk.java.net/~arapt

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

. With Regards, Avik Niyogi > On 09-Mar-2016, at 2:52 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > Kindly review the fix for JDK9. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8149456 > <https://bugs.openjdk.java.net/brow

Re: [9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

The updated fix looks good to me. > On 24-Feb-2016, at 11:02 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > On 11.02.16 8:52, Avik Niyogi wrote: >> Here is my two cents: >> >> * As of Xcode 7, Rich Text Font Document attributes h

Re: Review request for 8147834: [macosx] KeyEvents for function keys F17, F18, F19 return keyCode 0

Looks fine with this file change. > On 16-Feb-2016, at 9:58 pm, Sergey Bylokhov > wrote: > > Looks fine. > > On 12.02.16 15:37, Manajit Halder wrote: >> Hi All, >> >> Kindly review the fix for JDK9. >> >> *Bug: * >>

Re: [9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

ilable) https://developer.apple.com/library/mac/releasenotes/AppKit/RN-AppKit/ <https://developer.apple.com/library/mac/releasenotes/AppKit/RN-AppKit/> With Regards, Avik Niyogi > On 10-Feb-2016, at 11:46 pm, Chris Bensen <chris.ben...@oracle.com> wrote: > >> On Feb 10, 2

Re: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi All, Please find below the web rev with inputs from comments. http://cr.openjdk.java.net/~aniyogi/8019280/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8019280/webrev.02/> With Regards, Avik Niyogi > On 24-Nov-2015, at 5:16 pm, Avik Niyogi <avik.niy...@oracle.com> wrote:

Re: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi Semyon, I checked the rest of the JDK and found out that there is no localisation bundle so there is no need for NSLocalizedString. I will change that and create new webrev. Trailing white space is used because the button size is not sufficient. With Regards, Avik Niyogi > On 24-Nov-2

Re: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi All, Please find below the webrev with inputs from comments. http://cr.openjdk.java.net/~aniyogi/8019280/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8019280/webrev.01/> With Regards, Avik Niyogi > On 23-Nov-2015, at 2:54 pm, Ambarish Rapte <ambarish.ra...@oracle.com> wrot

Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

UI guidelines. Cause: Incorrect implementation within CFileDialog.m Fix:Added logic to setPrompt when opening a directory selection File Dialog With Regards, Avik Niyogi

Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

to Mac OSX UI guidelines. Cause: Incorrect implementation within CFileDialog.m Fix:Added logic to setPrompt when opening a directory selection File Dialog With Regards, Avik Niyogi