Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: RFR(M) : 8210039 : move OSInfo to top level testlibrary

Igor, > On 31 Aug 2018, at 19:42, Igor Ignatyev wrote: > > Alan, Chris, > > thanks for looking at it, I went w/ the alternative suggested by Chris. that > required a sprinkle of doPrivileged in the testlibrary, but now > Sockets/policy.* files grant the minimal required permissions to the

Re: RFR(M) : 8210039 : move OSInfo to top level testlibrary

> On 30 Aug 2018, at 08:51, Alan Bateman wrote: > > On 28/08/2018 17:50, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html >>> 698 lines changed: 114 ins; 240 del; 344 mod >> Hi all, >> >> could you please review this clean up of jdk testlibrary? >>

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

On 11 May 2016, at 22:59, Mandy Chung wrote: > >> On May 11, 2016, at 2:55 PM, Alexander Scherbatiy >> wrote: >> >> On 12/05/16 01:50, Phil Race wrote: >>> Alexander ... I am concurrently deleting GThreadHelper (see webrev I just >>>

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

On 11 May 2016, at 22:42, Phil Race wrote: > Bug: http://cr.openjdk.java.net/~prr/8154546/ > Webrev: http://cr.openjdk.java.net/~prr/8154546/ > > The options were move this or delete it. > There is some discussion in the bug report about GLIB versions > but the only

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

On 11 May 2016, at 21:15, Mandy Chung wrote: > >> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy >> wrote: >> >> >> Hello, >> >> Could you review the fix: >> bug: https://bugs.openjdk.java.net/browse/JDK-8154539 >> webrev:

Re: RFR(XS): 8155156: Remove remaining sun.misc.* imports from the jdk repo

On 26 Apr 2016, at 18:33, Volker Simonis wrote: > Hi, > > can I please have a review for this trivial change: > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8155156/ > https://bugs.openjdk.java.net/browse/JDK-8155156 Thank you Volker. Reviewed. -Chris. >

Re: RFR: 8147544: Remove sun.misc.ManagedLocalsThread from java.desktop

On 1 Apr 2016, at 23:19, Phil Race wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8147544 > Fix: http://cr.openjdk.java.net/~prr/8147544/ Your changes look ok to me. Thanks for doing this Phil. -Chris. > ManagedLocalThreads is now superseded by a standard >

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

:30 AM, Chris Hegarty<chris.hega...@oracle.com> wrote: Webrev updated in-place, moved to sun.awt.utli ( desktop module ) http://cr.openjdk.java.net/~chegar/8146735/ This looks fine. Good to see it moved to java.desktop. Mandy

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

Webrev updated in-place, moved to sun.awt.utli ( desktop module ) http://cr.openjdk.java.net/~chegar/8146735/ -Chris. On 11 Jan 2016, at 22:44, Chris Hegarty <chris.hega...@oracle.com> wrote: > >> On 11 Jan 2016, at 21:27, Mandy Chung <mandy.ch...@oracle.com> wrote: &

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

> On 11 Jan 2016, at 21:27, Mandy Chung <mandy.ch...@oracle.com> wrote: > > On Jan 10, 2016, at 1:19 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: >> >> In preparation for JEP 260, and as per the suggestion over on the core >> libs[1], >&g

RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

In preparation for JEP 260, and as per the suggestion over on the core libs[1], sun.misc.PerformanceLogger should be moved to sun.util.logging. http://cr.openjdk.java.net/~chegar/8146735/ -Chris [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-January/037959.html

Re: RFR [9] Remove sun.misc.Queue and replace usages with standard Collections

r? -Chris. > On 11/12/15 20:22, Chris Hegarty wrote: >> More technical debt in sun.misc… >> >> Java SE has had support for Queues in Collections for many major releases, >> sun.misc.Queue seems to predate that. I cannot find any usages outside of the >> JDK, and

Fwd: RFR [9] 8140606: Update library code to use internal Unsafe

Forwarding to additional area specific mailing lists, as there are changes in the webrev that affect their area. -Chris. Begin forwarded message: > From: Chris Hegarty <chris.hega...@oracle.com> > Subject: RFR [9] 8140606: Update library code to use internal Unsafe > Date: 28 Oct

Re: [9] Review Request: 8136858 Examine the usage of ThreadGroup.stop() in sun.awt.AppContext

Thanks Sergey, this looks good to me. -Chris. On 6 Oct 2015, at 13:42, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk9. > > In the fix the call to ThreadGroup.stop() was wrapped in privileged block. > The new test is provided, I have checked that

Re: AWT Dev [Preliminary] RFR JDK-8064925: URLConnection::getContent needs to be updated to work with modules

Pavel, The latest changes look good to me. Can you please add a license header to the service descriptor file ( I know we don't do this consistently ). -Chris On 24 Jun 2015, at 13:20, Pavel Rappo pavel.ra...@oracle.com wrote: Thanks Alan. Both issues are fixed now, webrev updated in

Re: AWT Dev [9] Review Request: 8078658 Make custom Cursors available for modular build

On 17 Jun 2015, at 18:58, Alan Bateman alan.bate...@oracle.com wrote: On 17/06/2015 18:47, Sergey Bylokhov wrote: On 27.05.15 19:03, Sergey Bylokhov wrote: Hi, Alan. On 27.05.15 18:51, Alan Bateman wrote: A minor comment on the usage of ByteArrayOutputStream is that you should be able to

Re: AWT Dev Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

Alexander, On 13 May 2015, at 16:46, Alexander Kulyakhtin alexander.kulyakh...@oracle.com wrote: Hi Chris, I suspect that these changes are best going directly into jdk9/dev, as opposed to a a downstream forest. Yes, they are going directly to jdk9/dev, I forgot to add the group,

Re: AWT Dev Proposal: Make JNU_Throw* clear a pending exception

On 25/02/14 11:26, Petr Pchelko wrote: Hello, Alan. I can see how this might be attractive but doesn't it mean you are suppressing an important exception? In case we’ve already got into the JNU_Throw we will throw a new exception and override the original one anyway. However I agree that

Re: AWT Dev [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

On 26 Nov 2013, at 18:08, Iris Clark wrote: So overall it looks good to me and should be pushed to the staging forest once you hear from others that commented previously. I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan, please correct me if I'm wrong. I'm

Re: AWT Dev [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

On 27/04/2012 21:37, Jim Graham wrote: Thanks, sorry, I missed the part where this was responding to a change that is already under way in the new build system... Right, but it would be nice to trivially cleanup (remove these files) from FILES_export list in the old build system. -Chris.

Re: AWT Dev Request for Review: Remove import of empty JNI header files

[ cc'ing awt-dev 2d-dev ] The change looks fine Magnus, though it may be best to push through the awt or 2d forest. Members of these groups, cc'ed, are in a better position to comment on this. Oh, just to clarify, I agree and approve this change (as much as my approval counts ;-) ). Just

AWT Dev hg: jdk8/awt/jdk: 7144475: fix some warnings in java.awt, javax.print.attribute.standard, and sun.beans.infos

Changeset: a3b50244bd10 Author:chegar Date: 2012-02-10 11:03 + URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a3b50244bd10 7144475: fix some warnings in java.awt, javax.print.attribute.standard, and sun.beans.infos Reviewed-by: chegar, prr, alanb, anthony Contributed-by:

Re: AWT Dev Warning Fixes from LJC Hack Session

Michael, Looks good to me. Trivially, the generic type in ComponentBeanInfo could simply be Class?, since the actual type is not used. But, what you have is fine. Thanks for this contribution. I'm sure Stuart will do the integration for you. -Chris. On 02/ 4/12 07:48 AM, Michael Barker

Re: AWT Dev Warning Fixes from LJC Hack Session

On 04/02/2012 11:12, Alan Bateman wrote: I skimmed through this and just wonder about the changes to java.beans.beancontext.BeansSupportContext. It's a public type so adding a type parameter to the protected bcmListeners may be an issue. Oh, good catch Alan, I missed this. This part of

Re: AWT Dev Warning Fixes from LJC Hack Session

I think you should just drop the changes to this file. -Chris. Michael Barker mike...@gmail.com wrote: Oh, good catch Alan, I missed this. This part of the change should be reversed ( at least in the context of warnings cleanup ). Should I switch it to a wild card (protected transient

Re: AWT Dev [OpenJDK 2D-Dev] Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

Ananiev wrote: Hi, Chris, the fix looks fine. Thanks, Artem On 11/9/2011 4:28 PM, Chris Hegarty wrote: Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside in the same directory as libawt. xawt/libmawt.so - libawt_xawt.so headless/libmawt.so

Re: AWT Dev Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

, statbuf) == -1 errno == ENOENT) { /* No - this is a reduced-headless-jre so use special HToolkit */ Sorry I didn't think of this earlier. Thanks, David On 9/11/2011 10:28 PM, Chris Hegarty wrote: Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside

AWT Dev Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside in the same directory as libawt. xawt/libmawt.so - libawt_xawt.so headless/libmawt.so - libawt_headless.so The proposed new library names are prefixed with 'libawt' since they are