Re: RFR: 8262446: DragAndDrop hangs on Windows

2021-03-05 Thread Ichiroh Takiguchi
On Thu, 4 Mar 2021 10:36:56 GMT, Dmitry Markov wrote: > The IME functions and the DND operation must be executed on the toolkit > thread. If the DND operation is in progress, the IME API is invoked via > SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The > flag isInDoDr

Re: RFR: 8262446: DragAndDrop hangs on Windows

2021-03-04 Thread Ichiroh Takiguchi
On Thu, 4 Mar 2021 10:36:56 GMT, Dmitry Markov wrote: > The IME functions and the DND operation must be executed on the toolkit > thread. If the DND operation is in progress, the IME API is invoked via > SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The > flag isInDoDr

Re: RFR: 8261231: Windows IME was disabled after DnD operation

2021-02-08 Thread Ichiroh Takiguchi
On Mon, 8 Feb 2021 16:51:21 GMT, Alexander Zuev wrote: >> The function InvokeInputMethodFunction() is responsible for invocation of >> IME API. Typically it uses PostMessage() to execute corresponding IME >> function on the toolkit thread but if DnD operation takes place >> SendMessage() is us

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-22 Thread Ichiroh Takiguchi
On Thu, 21 Jan 2021 21:41:09 GMT, Dmitry Markov wrote: >> Marked as reviewed by aivanov (Reviewer). > >> Hi, >> >> AWT's `TextComponent` is a `peered` input client, and Swing's >> `JTextComponent` is an `active` input client. Thus it is OK to behave >> differently. I would expect that AWT's on

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
On Wed, 20 Jan 2021 05:43:51 GMT, Sergey Bylokhov wrote: > How do the native components work in that case like awt textarea or external > apps like notepad? I tested TextField+TextField, TextArea+TextArea, TextArea+TextField. Without fix: Preedit string was cancel by input focus change. With fi

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
On Tue, 19 Jan 2021 16:31:58 GMT, Ichiroh Takiguchi wrote: >>> > Fix: >>> > It is necessary to take care of unconfirmed composition string once the >>> > IME is going to be disabled. >>> >>> The fix commits the unconfirmed composition st

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
On Tue, 19 Jan 2021 13:18:22 GMT, Dmitry Markov wrote: >>> Fix: >>> It is necessary to take care of unconfirmed composition string once the IME >>> is going to be disabled. >> >> The fix commits the unconfirmed composition string. Committing is better >> than discarding. Is it possible to pres

Re: [EXTERNAL] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
Hello Dmitry. The bugid seems to be private, so I don't know the details. I think the current code can change the candidate string after getting the focus. If possible, could you show me the test instructions ? Thanks, Ichiroh Takiguchi On 2021-01-19 20:16, Dmitry Markov wrote: Pr

Re: RFR: 8239583 [AIX] simplify the native references in X input methods

2020-02-26 Thread Ichiroh Takiguchi
Hello Sergey. Sorry, I'm late. I tested your fix on several AIX boxes with different graphic adapter. I could not find out any side effect. Please let me know if you have any question. Thanks, Ichiroh Takiguchi On 2020-02-21 19:47, Ichiroh Takiguchi wrote: Hello Sergey, Oh OK, I got

Re: RFR: 8239583 [AIX] simplify the native references in X input methods

2020-02-21 Thread Ichiroh Takiguchi
Hello Sergey, Oh OK, I got your point. I will test your code on AIX box and reply to you. Please give me a few more days. Thanks, Ichiroh Takiguchi On 2020-02-21 17:00, Langer, Christoph wrote: Hi Sergey, your change looks good from eyeballing it. I'll put it into our CI and let you

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2020-02-20 Thread Ichiroh Takiguchi
t the doc. Ichiroh Takiguchi IBM Japan, Ltd. On 2020-02-20 14:10, Sergey Bylokhov wrote: Hello, Christoph. Could you shed some light on the changes below: -statusWindow->fgGC = XCreateGC(dpy, status, valuemask, &values); +statusWindow->fgGC = create_gc(status, FALSE);

Re: RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-31 Thread Ichiroh Takiguchi
Many thanks, Phil. I just became committer. Can someone help me push the fix [1] to avoid some mistakes in urgent situations ? I really appreciate your help. [1] https://cr.openjdk.java.net/~itakiguchi/8227919/webrev.02/ Thanks, Ichiroh Takiguchi On 2019-08-01 09:47, Philip Race wrote

Re: RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-31 Thread Ichiroh Takiguchi
Thanks Phil and Vladimir. I just put fix request into 8227919 [1] against JDK13. [1] https://bugs.openjdk.java.net/browse/JDK-8227919 Thanks, Ichiroh Takiguchi On 2019-08-01 02:45, Phil Race wrote: Ok, that looks a lot more sane. You (Ichiroh) will need to follow the JDK 13 fix request

Re: RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-31 Thread Ichiroh Takiguchi
an minimize the side effect for OpenJDK testing. I'll open another bugid for Linux s390x issue. I'm not sure which is the best or better on this situation... Thanks, Ichiroh Takiguchi On 2019-07-31 05:23, Phil Race wrote: Hi, I've stared at this fix and all this bit shifting inside if

Re: RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-30 Thread Ichiroh Takiguchi
Thanks, Vladimir. I think it's urgent issue for JDK13. Another reviewer is required. And I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi On 2019-07-29 21:49, Vladimir Kempik wrote: Looks good to me. Now need some reviewers to take a look at it. Thanks, Vla

Re: RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-29 Thread Ichiroh Takiguchi
ttps://bugs.openjdk.java.net/browse/JDK-8227919 Change: https://cr.openjdk.java.net/~itakiguchi/8227919/webrev.01/ It changes: * 0xL is changed to 0xUL * defined(__linux__) is added into defined(_LP64) line Thanks, -- Ichiro Takiguchi IBM Japan Ltd. "awt-dev" wrote on 2019/

RFR [13] 8227919: 8213232 causes crashes on solaris sparc64

2019-07-26 Thread Ichiroh Takiguchi
long instead of unsigned int on 64bit Big endian. It's same as Java8. I think Solaris SPARC's issue can be fixed by this fix. Vladimir, I appreciate your great help. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2019-07-23 20:00, Vladimir Kempik wrote: Hello it still crashes with "

Re: 8227919: 8213232 causes crashes on solaris sparc64

2019-07-22 Thread Ichiroh Takiguchi
[2] https://fedoraproject.org/wiki/I18N/InputMethods Thanks, Ichiroh Takiguchi On 2019-07-22 23:58, Vladimir Kempik wrote: Hello I’m getting Bus Error on startup with XMODIFIERS=@im=local ./xim_root nothing yet in log at that moment. Thanks, Vladimir 22 июля 2019 г., в 15:12, Ichiroh T

Re: 8227919: 8213232 causes crashes on solaris sparc64

2019-07-22 Thread Ichiroh Takiguchi
d current code did not work on even if Linux s390x platform. Thanks, Ichiroh Takiguchi On 2019-07-19 23:29, Vladimir Kempik wrote: Hello I’m probably missing something about XIM on X side here, using ssh -X from ubuntu(with Xserver) to solaris11 sparc64 machine the output is fevent = 0x3

8227919: 8213232 causes crashes on solaris sparc64

2019-07-19 Thread Ichiroh Takiguchi
output into JDK-8227919 [1] or post it into mailing list. I really appreciate if you are using XIM like IIIMF. [1] https://bugs.openjdk.java.net/browse/JDK-8227919 [2] https://cr.openjdk.java.net/~itakiguchi/8227919/xim_root.c Thanks, Ichiroh Takiguchi

Re: RFR: 8221082 Unexpected working behavior when using AIX's dtwm/mwm

2019-05-22 Thread Ichiroh Takiguchi
hiroh Takiguchi IBM Japan, Ltd. On 2019-05-02 10:09, Sergey Bylokhov wrote: Hi, Ichiroh. On 25/04/2019 04:08, Ichiroh Takiguchi wrote: dtwm (CDE's window manager) and mwm (motif window manager) cannot handle non focusable window properly. (Java cannot control input focus via WM_TAKE_FOCUS) I

RFR: 8218054 Infinity loop happened on Ubuntu 18.04 XVNC4 with depth 32

2019-05-21 Thread Ichiroh Takiguchi
olor issue, could you solve this one, please ? Xserver is loaded "Extended-Visual-Information" extension [2]. Since xcolors command output is properly, I think the issue is not related VNC viewer side. [1] https://bugs.openjdk.java.net/browse/JDK-8218054 [2] https://www.x.org/releases/X1

Re: RFR: 8211826: StringIndexOutOfBoundsException happens via GetStringUTFRegion()

2019-05-07 Thread Ichiroh Takiguchi
the buffer on swing_GTKEngine.c by memset() I wrote the testcase for swing_GTKEngine.c. (It's in JDK-8211826) It's not easy to detect buffer overflow... Ichiroh Takiguchi On 2019-04-03 06:55, Sergey Bylokhov wrote: Hi, Ichiroh. On 28/03/2019 06:27, Ichiroh Takiguchi w

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2019-04-28 Thread Ichiroh Takiguchi
Hello. I built the new fixed code by GCC 8.2.1. It worked fine. Thanks, Ichiroh Takiguchi On 2019-04-26 23:04, Ichiroh Takiguchi wrote: Hello Sergey. See "Preedit State Callbacks" section on Xlib manual [1] Return code for PreeditStartCallback should be int instead of

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2019-04-26 Thread Ichiroh Takiguchi
PreeditStartCallback, +(XIMProc)(void *)&PreeditStartCallback, [1] https://www.x.org/releases/X11R7.6/doc/libX11/specs/libX11/libX11.html Thanks, Ichiroh Takiguchi On 2019-04-26 08:14, Sergey Bylokhov wrote: Hi, Ichiroh. I got this build error when I tried to test this patch: open/src/

RFR: 8221082 Unexpected working behavior when using AIX's dtwm/mwm

2019-04-25 Thread Ichiroh Takiguchi
platform. (src/java.desktop/unix/classes/sun/awt/X11/XWM.java) This fix was required for above fix to detect AIX's mwm. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Re: RFR: 8212676 java.awt.SystemColor setting on CDE

2019-04-18 Thread Ichiroh Takiguchi
Hello. Sorry for disturb you again. Another reviewer is required for this fix. Bug:https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.02/ And I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi On 2019-

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2019-04-18 Thread Ichiroh Takiguchi
es(pX11IMData->current_ic, XNPreeditAttributes, pr_atrb, NULL); 2190 XFree((void *)pr_atrb); 2191 AWT_UNLOCK(); Thanks, Ichiroh Takiguchi On 2019-04-11 11:19, Sergey Bylokhov wrote: Hi, Ichiroh. Why the fix uses the "defined(MACOSX)" in a few places? I assume this code is nev

Re: RFR: 8211826: StringIndexOutOfBoundsException happens via GetStringUTFRegion()

2019-04-02 Thread Ichiroh Takiguchi
Hello Sergey. Thank you for your reviewing. I added testcase. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211826 Change: https://cr.openjdk.java.net/~itakiguchi/8211826/webrev.02/ I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Taki

RFR: 8221741 [AIX] Unexpected X11 bitmap fonts are loaded because of fontconfig.properties

2019-04-02 Thread Ichiroh Takiguchi
ld be supported. To SAP representative, I have a question about copyright year on make/data/fontconfig/aix.fontconfig.properties. Please let me know how I should write down copyright year. Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Re: RFR: 8211826: StringIndexOutOfBoundsException happens via GetStringUTFRegion()

2019-03-28 Thread Ichiroh Takiguchi
for swing_GTKEngine.c. * On swing_GTKEngine.c, maximum length size for String data is arranged. -static char conversionBuffer[CONV_BUFFER_SIZE]; +static char conversionBuffer[(CONV_BUFFER_SIZE - 1) * 3 + 1]; I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi On 20

Re: RFR: 8212676 java.awt.SystemColor setting on CDE

2019-03-25 Thread Ichiroh Takiguchi
this issue. Thanks, Ichiroh Takiguchi On 2019-03-21 07:56, Sergey Bylokhov wrote: Looks fine. Thank you for contribution! On 19/03/2019 10:22, Ichiroh Takiguchi wrote: Hello Sergey. Thank you for your suggestion. I changed Subject. From: AIX's CDE/MWM support To: AWT SystemColor setting on

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2019-03-25 Thread Ichiroh Takiguchi
Hello. Could you review the fix and give me your suggestion, please ? I really appreciate your feedback. Currently, UnsupportedOperationException happens because of invalid usage by input method operation. And I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi On

Re: RFR: 8212676 java.awt.SystemColor setting on CDE

2019-03-19 Thread Ichiroh Takiguchi
guchi/8212676/webrev.02/ For AIX dtwm/mwm issue, I opened JDK-8221082 [1]. [1] https://bugs.openjdk.java.net/browse/JDK-8221082 Thanks, Ichiroh Takiguchi On 2019-03-19 08:42, Sergey Bylokhov wrote: Hi, Ichiroh. It looks fine, but I have one general comment: this fix is not about some general su

Re: RFR: 8212676 AIX's CDE/MWM support

2019-03-11 Thread Ichiroh Takiguchi
Hello. Could you review the fix and give me your suggestion, please ? Thanks, Ichiroh Takiguchi On 2019-03-01 22:16, Ichiroh Takiguchi wrote: Hello. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2019-03-11 Thread Ichiroh Takiguchi
Hello. Could you review the fix and give me your suggestion, please ? Thanks, Ichiroh Takiguchi On 2019-02-26 22:08, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232

Re: RFR: 8212676 AIX's CDE/MWM support

2019-03-01 Thread Ichiroh Takiguchi
I checked Linux's MWM working behavior on RHEL6. I applied AIX's code into Linux side, but it was bad. Working behavior became worse. So AIX detection feature is still required. (JDK-8212676 was also updated) I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Taki

Re: RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2019-02-26 Thread Ichiroh Takiguchi
s/libX11/libX11.html Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-12-04 11:22, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8213232 Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.00/ This issue is relat

Re: RFR: 8212678 Windows IME related patch

2019-02-04 Thread Ichiroh Takiguchi
Hello. Could you review the fix and give me your suggestion, please ? JDK-8212678 [1] has screen shots and movies. Please check them also. [1] https://bugs.openjdk.java.net/browse/JDK-8212678 Thanks, Ichiroh Takiguchi On 2019-01-23 21:18, Ichiroh Takiguchi wrote: Hello. Could you review the

Re: RFR: 8212678 Windows IME related patch

2019-01-23 Thread Ichiroh Takiguchi
Hello. Could you review the fix and give me your suggestion ? Thanks, Ichiroh Takiguchi On 2019-01-16 20:13, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212678 Change: https://cr.openjdk.java.net/~itakiguchi/8212678/webrev.01

Re: RFR: X11 default visual support for IM status window on VNC

2019-01-21 Thread Ichiroh Takiguchi
Hello Sergey. Sorry, code conflict was there. I fixed code conflict and modified Copyright year. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212677 Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.01/ Thanks, Ichiroh Takiguchi IBM Japan

Re: RFR: 8212678 Windows IME related patch

2019-01-16 Thread Ichiroh Takiguchi
check them. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-11-18 22:22, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212678 Change: http://cr.openjdk.java.net/~aleonard/winime/webr

Re: RFR: 8211267: StackOverflowError happened by TextField.setFont(...) & Add non interactive test case for JDK-8211267

2018-12-12 Thread Ichiroh Takiguchi
Hello. I'm very sorry. I forgot to put @test tag into FontChangeTest.java testcase. (Thanks, Phil) Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211267 Change: https://cr.openjdk.java.net/~itakiguchi/8211267/webrev.03/ Thanks, Ichiroh Takiguchi On 20

Re: RFR: 8212676 AIX's CDE/MWM support

2018-12-05 Thread Ichiroh Takiguchi
Hello Phil. I heard some of AIX users used RealVNC VNC Enterprise Edition for AIX maintenance. [1] I assume they still use CDE. [1] https://www.realvnc.com/en/connect/download/vnc/aix/#older-versions Thanks, Ichiroh Takiguchi On 2018-12-05 15:44, Philip Race wrote: . and I think I need to

Re: RFR: 8212676 AIX's CDE/MWM support

2018-12-04 Thread Ichiroh Takiguchi
ually, all key events were forwarded to middle window if user clicked inside of right window. [1] https://bugs.openjdk.java.net/secure/attachment/79986/aix-focusable.png Thanks, Ichiroh Takiguchi On 2018-12-05 03:06, Phil Race wrote: I haven't evaluated the merits of this proposal

Re: RFR: 8212676 AIX's CDE/MWM support

2018-12-04 Thread Ichiroh Takiguchi
Hello again. Could you give me review comment and/or suggestion ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/ Thanks, Ichiroh Takiguchi On 2018-11-26 21:27, Ichiroh Takiguchi wrote: Hello. Could you review the

RFR: 8213232 Unix/X11 setCompositionEnableNative issue

2018-12-03 Thread Ichiroh Takiguchi
exception happened with Xlib bundled input method. Test instructions is in JDK-8213232. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-19 02:15, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute Unix/X11 setCompositionEnableNative

Re: RFR: 8211267: StackOverflowError happened by TextField.setFont(...) & Add non interactive test case for JDK-8211267

2018-12-03 Thread Ichiroh Takiguchi
takiguchi/8211267/webrev.02/ Thanks, Ichiroh Takiguchi On 2018-12-01 09:35, Sergey Bylokhov wrote: Hello, I think that you can use invokeAndWait instead of invokeLater(), which will wait while the code is executed on EDT, and I am not sure that you need to interrupt the main thread of the test.

RFR: 8214298 Add non interactive test case for JDK-8211267

2018-11-26 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Issue: JDK-8211267 requires non interactive test case Bug:https://bugs.openjdk.java.net/browse/JDK-8214298 Change: https://cr.openjdk.java.net/~itakiguchi/8214298/webrev.00/ I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM

RFR: X11 default visual support for IM status window on VNC

2018-11-26 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212677 Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.00/ Screen shots are in JDK-8212677. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-

RFR: 8212676 AIX's CDE/MWM support

2018-11-26 Thread Ichiroh Takiguchi
to avoid unexpected working behavior on AIX platform. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-18 18:57, Ichiroh Takiguchi wrote: Hello. This fix is really required for AIX's GUI. System color setting and window manager

RFR: 8212678 Windows IME related patch

2018-11-18 Thread Ichiroh Takiguchi
hiroh Takiguchi IBM Japan, Ltd. On 2018-06-15 02:26, Phil Race wrote: This should go to i18n-dev as well. -phil. On 06/14/2018 10:14 AM, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute Windows IME related Java Input Method Framework patch to OpenJDK project. Issue: This patch ca

Re: Fwd: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-14 Thread Ichiroh Takiguchi
I'm very sorry for your confusion, please ignore previous mail. I posted it on wrong mailing list. Ichiroh Takiguchi On 2018-11-15 03:11, Ichiroh Takiguchi wrote: Hello. Martin Buchholz suggested me via bugs.openjdk.java.net, I should not touch non AIX side. So I rewrote another code.

Fwd: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-14 Thread Ichiroh Takiguchi
want to touch non AIX side code, but I need to rename 3 files to avoid compilation issue. IBM33722.java -> IBM33722.java.template IBM964.java -> IBM964.java.template SimpleEUCEncoder.java -> SimpleEUCEncoder.java.template Thanks, Ichiroh Takiguchi IBM Japan, Ltd. Or

Re: RFR: 8213614 DnD operation change feature does not work with 64bit big endian CPU

2018-11-14 Thread Ichiroh Takiguchi
ere are no any objections. BTW we have some other places where we use the similar approach: "(int)Native.getLong()", I assume we need to update it also? On 09/11/2018 04:01, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute this patch to OpenJDK project. Bug:    https://bugs.

RFR: 8213614 DnD operation change feature does not work with 64bit big endian CPU

2018-11-09 Thread Ichiroh Takiguchi
code picks up it for 64bit data and casted for 32bit data. This operation works on little endian CPU, but it does not work on BIG endian CPU. Test instruction is in JDK-8213614. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Re: RFR: 8211267 StackOverflowError happened by TextField.setFont(...)

2018-10-30 Thread Ichiroh Takiguchi
t run. -phil. On 10/30/2018 10:39 AM, Ichiroh Takiguchi wrote: Hello. Additional reviewer is required. Please let me know if you have question and suggestion. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-10-05 06:21, Sergey Bylokhov wrote: Looks fine. On 02/10/2018 03:44, Ichiroh Takiguchi

Re: RFR: 8211826 getGTKIcon with Unicode chars got StringIndexOutOfBoundsException

2018-10-30 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? It's fixed invalid usage for JNI's data size calculation. Small testcase is in JDK-8211826. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-10-08 11:46, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:https://bugs.openjd

Re: RFR: 8211267 StackOverflowError happened by TextField.setFont(...)

2018-10-30 Thread Ichiroh Takiguchi
Hello. Additional reviewer is required. Please let me know if you have question and suggestion. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-10-05 06:21, Sergey Bylokhov wrote: Looks fine. On 02/10/2018 03:44, Ichiroh Takiguchi wrote: Hello Sergey. I appreciate your suggestion. Yeah

Re: RFR: 8211810 X11 Time stamp data should be unsigned

2018-10-25 Thread Ichiroh Takiguchi
) & 0xL; It is necessary to cast the values ​​from "long" to "int". What do you think ? Ichiroh Takiguchi On 2018-10-25 08:16, Sergey Bylokhov wrote: Hi, Ichiroh. I think you can simplify the fix a little bit by using Integer.toUnsignedLong(int). On 07/10/201

RFR: 8211826 getGTKIcon with Unicode chars got StringIndexOutOfBoundsException

2018-10-07 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211826 Change: https://cr.openjdk.java.net/~itakiguchi/8211826/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-19 21:33, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute a patch to

RFR: 8211810 X11 Time stamp data should be unsigned

2018-10-07 Thread Ichiroh Takiguchi
Hello. (Sorry, I put wrong bug id, please ignore previous mail) Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211810 Change: https://cr.openjdk.java.net/~itakiguchi/8211810/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-10-08 11:20, Ichiroh

Re: Proposal: X11 Time stamp data should be unsigned

2018-10-07 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211826 Change: https://cr.openjdk.java.net/~itakiguchi/8211826/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-19 22:22, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute a patch to

RFR[12]: 8211393 Memory leak issue on awt_InputMethod.c

2018-10-02 Thread Ichiroh Takiguchi
Hello. Could you review memory leak fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211393 Change: https://cr.openjdk.java.net/~itakiguchi/8211393/webrev.00/ I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-07-23 21:24, Ichiroh Taki

Re: RFR: 8211267 StackOverflowError happened by TextField.setFont(...)

2018-10-02 Thread Ichiroh Takiguchi
validate? It is also necessary to check that the call to validate(which use TreeLock) under StateLock will not cause a deadlock. On 01/10/2018 04:52, Ichiroh Takiguchi wrote: Hello. Could you review fix and testcase ? Bug:    https://bugs.openjdk.java.net/browse/JDK-8211267 Change: https

RFR: 8211267 StackOverflowError happened by TextField.setFont(...)

2018-10-01 Thread Ichiroh Takiguchi
Hello. Could you review fix and testcase ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211267 Change: https://cr.openjdk.java.net/~itakiguchi/8211267/webrev.00/ I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-09-05 23:08, Ichiroh Taki

Re: StackOverflowError happened by TextField.setFont(...)

2018-09-05 Thread Ichiroh Takiguchi
e to see this issue in jdk12 repo on Ubuntu. But this issue is not reproducible on Windows. So, I guess the fix has to be specific to Linux. Thanks, Krishna -Original Message- From: Ichiroh Takiguchi Sent: Monday, September 3, 2018 4:26 PM To: Krishna Addepalli Subject: Re: StackOverflowErro

Re: StackOverflowError happened by TextField.setFont(...)

2018-08-26 Thread Ichiroh Takiguchi
ined, but I'm not able to reproduce the issue you are seeing. Could you try with the latest jdk12 repo? Thanks, Krishna -Original Message- From: Ichiroh Takiguchi Sent: Friday, August 24, 2018 1:42 PM To: awt-dev@openjdk.java.net Subject: StackOverflowError happened by Text

StackOverflowError happened by TextField.setFont(...)

2018-08-24 Thread Ichiroh Takiguchi
r != null) { f = getFont(); if (f != null) { +peerFont = f; peer.setFont(f); -peerFont = f; } } } = I'm not sure, it's good or not... Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

RFR: 8208996 X11 icon window color handing bug

2018-08-06 Thread Ichiroh Takiguchi
Thanks Sergey. Hello. Could you review it ? Bug:https://bugs.openjdk.java.net/browse/JDK-8208996 Change: http://cr.openjdk.java.net/~aleonard/8208996/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-08-05 10:10, Sergey Bylokhov wrote: Hello. I was able to reproduce the bug as

Re: [12] Proposal: Memory leak issue on awt_InputMethod.c

2018-07-23 Thread Ichiroh Takiguchi
Hello. I'd like to change target to "JDK12". I'd like to obtain a sponsor for this patch. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-28 22:13, Ichiroh Takiguchi wrote: Hello. In my investigation, this issue only happens on 64 bit build only... On 2018-06-28 06

Re: Proposal: Memory leak issue on awt_InputMethod.c

2018-06-28 Thread Ichiroh Takiguchi
Hello. In my investigation, this issue only happens on 64 bit build only... On 2018-06-28 06:06, Phil Race wrote: On 06/27/2018 06:45 AM, Ichiroh Takiguchi wrote: Hello, I should post this mail before starting JDK11 RDP1. Already too too late for that, but although this looks like a bug

Proposal: Memory leak issue on awt_InputMethod.c

2018-06-27 Thread Ichiroh Takiguchi
le[cnt] = text->feedback[cnt]; (*env)->SetIntArrayRegion(env, style, 0, text->length, (jint *)tmpstyle); +free(tmpstyle); } } } Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

RFR: 4475138 getBestCursorSize and XFree86 4.1.0

2018-06-21 Thread Ichiroh Takiguchi
Thanks Sergey. Hello. Could you review it ? Bug:https://bugs.openjdk.java.net/browse/JDK-4475138 Change: http://cr.openjdk.java.net/~aleonard/4475138/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-21 11:42, Sergey Bylokhov wrote: Looks like the bug is known: https

Re: Proposal:X11 default visual support for IM status window on VNC

2018-06-21 Thread Ichiroh Takiguchi
-normal--16-120-100-100-c-80-jisx0201.1976-0 [L][5] -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso10646-1 === [M] means "Missing" font, [L] means "Loaded". On 2018-06-20 23:14, Philip Race wrote: My question has not been answered. I don't think this is ready to

Re: Proposal:X11 default visual support for IM status window on VNC

2018-06-20 Thread Ichiroh Takiguchi
create bugid and handle it. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-20 04:59, Naoto Sato wrote: Please change the comment in line 680, which should also mention 13 point font. Naoto On 6/19/18 12:54 PM, Naoto Sato wrote: Looks OK wrt awt_InputMethod.c change. Naoto On 6/19/18

Proposal: DnD cursor is too big on AIX

2018-06-19 Thread Ichiroh Takiguchi
dth, preferredWidth); +d.height = Math.min(d.height, preferredHeight); +} } finally { XToolkit.awtUnlock(); ---- Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Proposal: X11 Time stamp data should be unsigned

2018-06-19 Thread Ichiroh Takiguchi
ine("client messags = " + xce); } -long timestamp = xce.get_data(0); +long timestamp = xce.get_data(0) & 0xL; long atom = xce.get_data(1); long owner = xce.get_data(2); long data = xce.get_data(3); -- Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Proposal: getGTKIcon with Unicode chars got StringIndexOutOfBoundsException

2018-06-19 Thread Ichiroh Takiguchi
a.desktop/unix/native/libawt_xawt/awt/swing_GTKEngine.c has same kind of code. But buffer handling is not same, so I could not determine, I need to change swing_GTKEngine.c or not. Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Proposal: Input Method switch popup menu patch

2018-06-19 Thread Ichiroh Takiguchi
ple%20Code [2] http://javadesktop.org/articles/InputMethod/index.html Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Proposal: Unix/X11 setCompositionEnableNative issue

2018-06-18 Thread Ichiroh Takiguchi
k please, and how I would go about obtaining a sponsor and contributor? Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Re: Proposal:AIX's CDE/MWM support

2018-06-18 Thread Ichiroh Takiguchi
Hello. This fix is really required for AIX's GUI. System color setting and window manager's working behavior are very important. I appreciate any feedback, and how I would go about obtaining a sponsor and contributor ? On 2018-05-25 11:02, Ichiroh Takiguchi wrote: Hello Phil. w

Proposal: Windows IME related patch

2018-06-14 Thread Ichiroh Takiguchi
ttp://cr.openjdk.java.net/~aleonard/winime/webrev.00/ I appreciate any feedback please, and how I would go about obtaining a sponsor and contributor? [1] http://unicode.org/cgi-bin/GetUnihanData.pl?codepoint=2000B Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Proposal: X11 icon window color handing patch

2018-06-13 Thread Ichiroh Takiguchi
conWindow.java I appreciate any feedback please, and how I would go about obtaining a sponsor and contributor? Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Re: Proposal:X11 default visual support for IM status window on VNC

2018-06-06 Thread Ichiroh Takiguchi
Hello Sergey. Thank you for your review. Could you review following patch ? http://cr.openjdk.java.net/~aleonard/defvis/webrev.01/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-06 07:15, Sergey Bylokhov wrote: Hi, Ichiroh. The approach looks fine, but maybe it is possible to decrees

Proposal:X11 default visual support for IM status window on VNC

2018-05-24 Thread Ichiroh Takiguchi
ed fonts.) webrev files are in http://cr.openjdk.java.net/~aleonard/defvis/ I appreciate any feedback please, and how I would go about obtaining a sponsor and contributor? Thanks, Ichiroh Takiguchi IBM Japan, Ltd.

Re: Proposal:AIX's CDE/MWM support

2018-05-24 Thread Ichiroh Takiguchi
Hello Phil. webrev file was extracted. Please see http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev.00/ On 2018-05-19 02:48, Ichiroh Takiguchi wrote: Hello Phil. Webrev.zip file is stored into http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev-aixgui.zip Test programs are also stored

Re: Proposal:AIX's CDE/MWM support

2018-05-18 Thread Ichiroh Takiguchi
rather than adding to it. -phil. On 05/17/2018 04:18 AM, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute AIX's CDE (Common Desktop Environment) DTWM (Desktop Window Manager) /MWM (Motif Window Manager) support to OpenJDK project. I'd like contribute following 5

Proposal:AIX's CDE/MWM support

2018-05-17 Thread Ichiroh Takiguchi
eciate any feedback please, and how I would go about obtaining a sponsor and contributor ? Thanks, Ichiroh Takiguchi IBM Japan, Ltd. [1] https://docs.oracle.com/cd/E19253-01/806-7492/fontsandcolors-15233/index.html

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-14 Thread Ichiroh Takiguchi
Hello Christoph. Our team tested your fixed code on Linux (RHEL7) and AIX (7.1). resetCompositionState() was missing in src/java.desktop/aix/classes/sun/awt/X11InputMethod.java --- a/src/java.desktop/aix/classes/sun/awt/X11InputMetho

Re: Proposal:AIX's IME support

2018-04-18 Thread Ichiroh Takiguchi
ture. /Magnus I'll try to update your patch a bit to integrate better with the common codebase. Best regards Christoph -Original Message- From: awt-dev [mailto:awt-dev-boun...@openjdk.java.net] On Behalf Of Ichiroh Takiguchi Sent: Montag, 16. April 2018 19:42 To: Ser

Re: Proposal:AIX's IME support

2018-04-16 Thread Ichiroh Takiguchi
py" action. It was reported by, http://mail.openjdk.java.net/pipermail/webrev-dev/2018-April/000145.html So above webrev file should be fine. Please let me know if you have any question and suggestion about webrev file for AIX's IME support. Thanks, Ichiroh Takiguchi On 2018

Re: Proposal:AIX's IME support

2018-04-10 Thread Ichiroh Takiguchi
ev on cr.openjdk.java.net? On 09/04/2018 02:09, Ichiroh Takiguchi wrote: Hello, IBM would like to propose another Input Method Framework (IMF) implementation against IBM AIX platform. Same IMF implementation was used by IBM Java8 for AIX. IBM would like to contribute this IMF implementation to OpenJDK pr

Proposal:AIX's IME support

2018-04-09 Thread Ichiroh Takiguchi
d appreciate any feedback please, and how I would go about obtaining a sponsor and contributor? Thanks, Ichiroh Takiguchi IBM Japan, Ltd.