Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v8]

2021-06-01 Thread Joe Wang
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e384

Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current [v2]

2021-05-18 Thread Joe Wang
On Tue, 18 May 2021 23:35:12 GMT, Naoto Sato wrote: >> test/jdk/java/util/Locale/LocaleTest.java line 683: >> >>> 681: * @bug 4052404 4778440 8263202 >>> 682: */ >>> 683: public void TestChangedISO639Codes() { >> >> Could probably be simplified with a DataProvider. > > That would

Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current [v2]

2021-05-18 Thread Joe Wang
On Tue, 18 May 2021 23:39:37 GMT, Naoto Sato wrote: >> Please review the changes to the subject issue. java.util.Locale class has a >> long-standing issue for those obsolete ISO 639 languages where its >> normalization ends up in the obsolete codes. This change intends to flip the >> normaliza

Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current

2021-05-18 Thread Joe Wang
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote: > Please review the changes to the subject issue. java.util.Locale class has a > long-standing issue for those obsolete ISO 639 languages where its > normalization ends up in the obsolete codes. This change intends to flip the > normalization

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Joe Wang
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28