Re: FYI: new javadoc tag to document system properties

2018-11-14 Thread Joseph D. Darcy
Hello, For future CSR requests involving system properties, please document the properties using these javadoc facilities. Thanks, -Joe On 11/14/2018 2:27 PM, Jonathan Gibbons wrote: This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (

Re: JDK 12 RFR of JDK-8203263: Remove unnecessary throws clauses from serialization-related methods

2018-07-18 Thread Joseph D. Darcy
I suspect it might have been a copy-and-paste issue since the declaration for readObject has those two exception types: private void readObject(ObjectInputStream stream) throws IOException, ClassNotFoundException; and (to date) we haven't have programmatic checks of this aspect of the seri

JDK 12 RFR of JDK-8203263: Remove unnecessary throws clauses from serialization-related methods

2018-07-17 Thread Joseph D. Darcy
Hello, A few classes in awt and beans have writeObject methods declared to throw extra exception types. The serialization spec requires the following declaration for a writeObject method: private void writeObject(ObjectOutputStream stream) throws IOException; https://docs.oracle.c

Re: JDK 9 RFR of JDK-8129822: Define "headful" jtreg keyword

2015-06-24 Thread Joseph D. Darcy
PS Discussion of the next iteration of tiered testing: http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html Thanks, -Joe On 6/24/2015 4:42 PM, joe darcy wrote: Hello, To support the next iteration of tiered testing in JDK 9, with an eye toward running client library tests,

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java

2010-01-26 Thread Joseph D. Darcy
Pavel Tisnovsky wrote: Hi Anthony, thank you for the tip, I'll try to use realSync(), it seems to be the best solution. If the fix is approved by the awt team, I'm happy for the test change to go back into OpenJDK 6. -Joe

Re: Code review request to fix awt javadoc build warnings in JDK 7

2009-08-28 Thread Joseph D. Darcy
Anthony Petrov wrote: Hi Joe, The patch looks great. Thanks for fixing that. Approved. -- best regards, Anthony On 8/28/2009 12:46 AM Joseph D. Darcy wrote: I pushed the fix for 6877122 "Many javadoc warnings from java.awt.Window, other awt classes" into TL: http://hg.openjd

Code review request to fix awt javadoc build warnings in JDK 7

2009-08-27 Thread Joseph D. Darcy
Greetings. While doing some other documentation work, I noticed there were dozens of javadoc build warnings coming out of java.awt.*. I'm submitting the patch below for your review; the patch corrects all those warnings from awt,. If approved, I will file a bug and commit the changes back t

Re: Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-30 Thread Joseph D. Darcy
Oleg Sukhodolsky wrote: Hi, just a short question: do we really have to change the launcher? Why we can not add the changes to AWT's native code (somewhere near LoadLibrary())? Yes, it would be preferable if the launcher did not change for this. -Joe Oleg. On Wed, Jul 29, 2009 at 3:13

Re: Request for review: 6832386 Fix JTreg test: java/awt/Graphics/DrawImageBG/SystemBgColorTest.java

2009-05-06 Thread Joseph D. Darcy
Anthony Petrov wrote: awt-dev: please review the fix for 6open and 7 at: http://cr.openjdk.java.net/~anthony/6open-1-systemExitNotNeeded-6832386.0/ and http://cr.openjdk.java.net/~anthony/7-10-systemExitNotNeeded-6832386.0/ (should admit the webrevs are quite identical :) ) The correspondin