Re: [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

2015-10-08 Thread Renjith Alexander
Hi All, I still need two approvals for this. Could somebody please review this? Regards, Renjith. -Original Message- From: Renjith Alexander Sent: Monday, October 05, 2015 3:13 PM To: Yuri Nesterenko; awt-dev@openjdk.java.net Subject: Re: [awt-dev] Request for Approval and Review: JDK

Re: [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

2015-10-05 Thread Renjith Alexander
Hi All, Please find the updated webrev at: http://cr.openjdk.java.net/~pchopra/8136592/webrev.01/ Regards, Renjith. -Original Message- From: Yuri Nesterenko Sent: Wednesday, September 30, 2015 5:20 PM To: Renjith Alexander; awt-dev@openjdk.java.net Subject: Re: [awt-dev] Request for

[awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

2015-09-29 Thread Renjith Alexander
open. One round of review has been finished for the changes for these tests in crucible. -- Regards, Renjith Alexander

Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

2015-09-21 Thread Renjith Alexander
Hi All, I need one more approval for this item. Could somebody please review it? Regards, Renjith. From: Renjith Alexander Sent: Tuesday, September 15, 2015 2:33 PM To: Andrei Eremeev; awt-dev@openjdk.java.net Subject: Re: Review request for JDK-8132380: Do not create LaF instance

Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

2015-09-15 Thread Renjith Alexander
Hi Andrei, Please see the updated version: http://cr.openjdk.java.net/~pchopra/8132380/webrev.01/ Regards, Renjith. From: Andrei Eremeev Sent: Friday, September 11, 2015 6:34 PM To: Renjith Alexander; awt-dev@openjdk.java.net Subject: Re: Review request for JDK-8132380: Do not

Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

2015-09-11 Thread Renjith Alexander
Hi all, Please review the fix for the bug: JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java BUG ID - https://bugs.openjdk.java.net/browse/JDK-8132380 The webrev is: http://cr.openjdk.java.net/~pchopra/8132380/webrev.00/ -- Regards, Renjith

Review request for JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation

2015-09-03 Thread Renjith Alexander
closed to open(the new files in the webrev), for which review request (for identifying the differences), is raised internally. -- Regards, Renjith Alexander

[awt-dev] Request for Review: JDK-8133539 - [TEST_BUG] Split java/awt/image/MultiResolutionImageTest.java in two to allow restricted access

2015-09-03 Thread Renjith Alexander
/     -- Regards, Renjith Alexander      

Re: [awt-dev] Request for Approval and Review: JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation

2015-08-30 Thread Renjith Alexander
A gentle reminder…   Regards, Renjith.   From: Renjith Alexander Sent: Thursday, August 27, 2015 10:26 AM To: awt-dev@openjdk.java.net Subject: RE: [awt-dev] Request for Approval and Review: JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation   Hi

Re: [awt-dev] Request for Approval and Review: JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation

2015-08-26 Thread Renjith Alexander
Hi All,   I need +1 for this review. This is a simple fix. Can someone please review it. Regards, Renjith.   From: Renjith Alexander Sent: Thursday, August 20, 2015 1:39 PM To: awt-dev@openjdk.java.net Subject: [awt-dev] Request for Approval and Review: JDK-8133027: [Jigsaw] Test java

Re: [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-25 Thread Renjith Alexander
: Renjith Alexander Cc: awt-dev@openjdk.java.net Subject: Re: [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API On 8/24/2015 12:27 PM, Renjith Alexander wrote: > Hi All, > > Please r

Re: [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-24 Thread Renjith Alexander
/ Regards, Renjith. -Original Message- From: Alexander Scherbatiy Sent: Thursday, August 20, 2015 7:53 PM To: Renjith Alexander Cc: awt-dev@openjdk.java.net Subject: Re: [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to

[awt-dev] Request for Approval and Review: JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation

2015-08-20 Thread Renjith Alexander
new in the previous webrev) has been moved from ‘closed’ to ‘open’. The difference for those files in the closed repo can be found in the webrev:   http://cr.openjdk.java.net/~pchopra/8133027/webrev.01/ -- Regards, Renjith Alexander      

Re: [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-17 Thread Renjith Alexander
. -Original Message- From: Alexander Scherbatiy Sent: Monday, August 10, 2015 7:24 PM To: Renjith Alexander Cc: awt-dev@openjdk.java.net Subject: Re: [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific

[awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-07 Thread Renjith Alexander
(which are shown as new in the previous webrev) have been moved from ‘closed’ to ‘open’. The difference for those files in the closed repo can be found in the webrev:   http://cr.openjdk.java.net/~sgupta/8132376/webrev.00/   -- Regards, Renjith Alexander      

[awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-07 Thread Renjith Alexander
(which are shown as new in the previous webrev) have been moved from ‘closed’ to ‘open’. The difference for those files in the closed repo can be found in the webrev:   http://cr.openjdk.java.net/~sgupta/8132376/webrev.00/   -- Regards, Renjith Alexander      

[awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-07 Thread Renjith Alexander
(which are shown as new in the previous webrev) have been moved from ‘closed’ to ‘open’. The difference for those files in the closed repo can be found in the webrev:   http://cr.openjdk.java.net/~sgupta/8132376/webrev.00/ -- Regards, Renjith Alexander