Re: RFR: 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java

2017-08-16 Thread Tim Bell
Phil: On 08/16/2017 11:09 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8186259/ I'll take any reviewer on this which just fixes the JTREG test so that jtreg does not blow up. Looks good. Approved. Tim

Re: AWT Dev RFR: JDK-8074096 Disable (most) native warnings in JDK on a per-library basis

2015-03-04 Thread Tim Bell
Magnus: Looks good to me as well. Tim On 03/04/15 05:31, Erik Joelsson wrote: Hello, Really nice to finally see this patch getting done! Only one comment: flags.m4: In the grep expression, could you move the extra [] outside of the actual command line options to grep so that the command

Re: AWT Dev RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-31 Thread Tim Bell
Hi Erik Looks good to me as well. Tim Looks good to me. /Magnus On 27 mar 2014, at 12:47, Erik Joelsson erik.joels...@oracle.com wrote: Further testing revealed some more issues. New webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ I had to break out the devkit/sysroot