Re: RFR: 8221741 [AIX] Unexpected X11 bitmap fonts are loaded because of fontconfig.properties

On Tue, Apr 2, 2019 at 1:52 PM Ichiroh Takiguchi wrote: > > Hello. > > Could you review the fix ? > > Bug:https://bugs.openjdk.java.net/browse/JDK-8221741 > Change: https://cr.openjdk.java.net/~itakiguchi/8221741/webrev.00/ > > I'd like to obtain a sponsor for this issue. > > On AIX platform,

Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

On Mon, Mar 25, 2019 at 7:50 PM Thomas Stüfe wrote: > > > > On Mon 25. Mar 2019 at 19:42, Volker Simonis wrote: >> >> Hi Thomas, Christoph, >> >> thanks for looking into my fix. I hope I've addressed all your >> concerns with my new webrev: >>

Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

dlsym at 456. You want > to make sure dlerror() is not stale at the point where you call it, since it > would return NULL. > > Cheers, Thomas > > > > On Mon, Mar 18, 2019 at 3:17 PM Volker Simonis > wrote: >> >> Ping... >> >> Can I please

Re: RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

Ping... Can I please also get a review from the awt/2d group? Thanks, Volker On Wed, Mar 13, 2019 at 11:09 AM Volker Simonis wrote: > > Hi, > > can I please have a review for the following change which fixes > Xinerama and Xrender support on AIX: > > http://cr.openjdk.java

RFR(XS): 8214120: [REDO] Fix sun.awt.nativedebug on X11 platforms

Hi, so here's a reworked version of my previous change: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214120/ https://bugs.openjdk.java.net/browse/JDK-8214120 In addition to my initial change (which unfortunately broke the Solaris build) the new version has to JNIEXPORT the following methods

RFR(XXS): 8214007: Fix sun.awt.nativedebug on X11 platforms

Hi, can I please have a review for the following trivial fix: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214007/ https://bugs.openjdk.java.net/browse/JDK-8214007 AWT supports some kind of native logging which can be enabled with "-Dsun.awt.nativedebug=true -Dawtdebug.ctrace=true". Unfort

RFR(XS): 8213151: [AIX] Some class library files are missing the Classpath exception

Hi, can I please have a review for the following tiny change which fixes the license header on a few AIX-specific files: http://cr.openjdk.java.net/~simonis/webrevs/2018/8213151/ https://bugs.openjdk.java.net/browse/JDK-8213151 These files have been wrongly integrated (without the Classpath Exce

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

t a jdk-submit would be prudent .. > I did start Solaris and AIX builds before I left the office. I can certainly also submit a job to JDK-submit, but at least hs-submit wasn’t working at all (i.e. didn’t return any results). > -phil. > > On 04/13/2018 09:22 AM, Volker Simonis wrote: >

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

gt; > The change looks good, but now that we no longer link against > libawt_headless, we should also remove the make dependency a few lines down. > (Should have been done already for Solaris.) > > /Erik > > > > On 2018-04-13 06:28, Volker Simonis wrote: >> >>

RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Hi, can I please have a review for this tiny AIX cleanup: http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524/ https://bugs.openjdk.java.net/browse/JDK-8201524 This is a follow up change of JDK-8196516 which discovered that on AIX libfontmanager is always linked against libawt_headless at b

Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols

Hi Severin, I'm currently looking at the AIX-side of this bug. The problem I see with your solution is that it uses LDFLAGS (which is generic) to filter out Linux specific linker flags. If we would extend this to AIX, we would have to add yet another substitution for AIX which filters out "-Wl,be

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

Hi Magnus, thanks for addressing this long standing issue! I haven't looked at the changes, but just want to share some general and historical notes: - Compiling with "-fvisibility=hidden" which hides all symbols expect the ones explicitly exported with "__attribute__((visibility("default")))" ha

Re: [9] RFR(XXS): 8178911: Building of awt_Window.cpp fails on Windows with VS2010

Cool! I totally forgot about the jdk9-client repository :) I'll close the new bug as duplicate. Thanks, Volker On Wed, Apr 19, 2017 at 3:32 PM, Sergey Bylokhov wrote: > Hi, Volker. > It seems that it was fixed already by > https://bugs.openjdk.java.net/browse/JDK-8177137 > Will be available in

[9] RFR(XXS): 8178911: Building of awt_Window.cpp fails on Windows with VS2010

Hi, I'd kindly like to request the inclusion of the following trivial fix into jdk9 to keep it buildable with VS2010: http://cr.openjdk.java.net/~simonis/webrevs/2017/8178911/ https://bugs.openjdk.java.net/browse/JDK-8178911 I know that VS2010 isn't Oracle's default compiler for Windows, but oth

Fwd: [PATCH]: few memory errors fixes

Hi David, thanks for your contribution. Your fixes look reasonable. I'm forwarding your mail to to core-libs-dev and awt-dev for reviewing. Regards, Volker -- Forwarded message -- From: David CARLIER Date: Mon, Dec 5, 2016 at 10:10 PM Subject: [PATCH]: few memory errors fixes T

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

ee that we should provide that instead of NULL. Regards, Volker > I am not sure that the fix can be pushed to the jdk9/dev repository. The > usual practice is to always push it to the jdk9/client first. > > Thanks, > Alexandr. > > > On 8/9/2016 10:37 AM, Volker Simonis wr

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

nd is the following mail thread on the GCC mailing list: https://gcc.gnu.org/ml/gcc-patches/2013-04/threads.html#00363 Regards, Volker On Wed, Aug 10, 2016 at 4:31 PM, Sergey Bylokhov wrote: > Looks fine. > > > On 09.08.16 10:37, Volker Simonis wrote: >> >> I've jus

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

awt-dev alias. > > > On 08/08/16 22:36, Volker Simonis wrote: >> >> Hi, >> >> can I please have a review for the following trivial fix: >> >> http://cr.openjdk.java.net/~simonis/webrevs/2016/8163408/ >> https://bugs.openjdk.java.net/browse/JDK-8163

Re: Review request for 4908075: Press shift and another key using robot does not trigger events properly

On Tue, Jul 26, 2016 at 1:28 AM, Sergey Bylokhov wrote: > On 15.07.16 17:05, Volker Simonis wrote: >> >> However, I'm a little bit worried about the test. Even on Windows, the >> various tested key-combination may get be partially intercepted by >> other applicati

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi Götz, your change looks good. Thanks a lot for cleaning up all these tests! I only found one problem which you should fix: test/java/awt/Frame/MiscUndecorated/RepaintTest.java @@ -1,6 +1,6 @@ -/* +\/* Seems like there's an extra backslash at the beginning of the first line. You may also wa

Re: Review request for 4908075: Press shift and another key using robot does not trigger events properly

Hi Oliver, your fix looks good and I can sponsor it. However, I'm a little bit worried about the test. Even on Windows, the various tested key-combination may get be partially intercepted by other applications and this can leave the whole system in an inconsistence state. For example on my Window

Re: [OpenJDK 2D-Dev] RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

Hi Goetz, it would be really interesting to see the use case where this has been a performance issue. But even without that I agree with your comments in the bug. Phil's fear that you introduce an extra 'instanceof' check for the positive case is unfounded. I've attached a small example program t

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

e trough the initial pain of marking all headful test, the future development should then be straightforward and simple. > In other way almost all AWT/Swing tests should be marked by "headful" > keyword. > > Thanks, > Alexandr. > > >> >> Best re

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

On Thu, Jun 16, 2016 at 5:55 PM, Alexandr Scherbatiy wrote: > On 6/16/2016 5:40 PM, Lindenmaier, Goetz wrote: > > Hi, > > > > we have test machines without X server. On these many of the jdk > > jtreg tests fail with a headless exception. > > We grepped for this exception in the test output and id

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

Hi Goetz, the change looks good. Thanks for doing this Sisyphean task! We should nevertheless wait for another review from somebody from the AWT/Swing team. Regards, Volker On Thu, Jun 16, 2016 at 4:40 PM, Lindenmaier, Goetz wrote: > Hi, > > > > we have test machines without X server. On thes

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

Hi Phil, Sergey, @Sergey: thaks for the review Please see my other comments inline: On Sat, May 7, 2016 at 1:45 AM, Phil Race wrote: > On 05/06/2016 04:33 PM, Volker Simonis wrote: > > Hi Phil, > > Thanks for looking at this problem. > > On Saturday, May 7, 2016, Phil

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

we (or I) approved since it was the >> latest >> obviously >> http://mail.openjdk.java.net/pipermail/swing-dev/2016-April/005684.html >> >> but this looks like the v5 webrev was pushed : >> http://mail.openjdk.java.net/pipermail/swing-dev/2016-April/005678.html &

RFR(XS): 8155156: Remove remaining sun.misc.* imports from the jdk repo

Hi, can I please have a review for this trivial change: http://cr.openjdk.java.net/~simonis/webrevs/2016/8155156/ https://bugs.openjdk.java.net/browse/JDK-8155156 The fix for "8153737: Unsupported Module" moved sun.misc to the jdk.unsupported module and removed sun.misc.* imports. Unfortunately

Re: RFR(xs): 8153727: AIX jdk build broken after 8145174

Hi Thomas, thanks for doing this fix. It looks good. I've also forwarded your request to build-dev as this is a build change. Just one question: do we pass the new test test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java which came in with 8145174 on AIX or d

Re: [OpenJDK 2D-Dev] Request for review: 8026385: [macosx] (awt) setjmp/longjmp changes the process signal mask on OS X

Hi everybody, I've analyzed this issue on AIX (and HPUX) and came to the conclusion that it is not a problem on these platforms. Just to make sure I got everything right, I'll summarize my understanding of the problem here: On MacOS, setjmp() saves the signal mask of the current thread BUT resto

Re: CFV: New jdk9 Committer: David DeHaven

Vote: yes On Mon, May 19, 2014 at 9:51 PM, Anthony Petrov wrote: > I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 > Committer > > David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, he > has reviewed many fixes that went into those releases. The AWT G

Re: [OpenJDK 2D-Dev] Request for review: 8026385: [macosx] (awt) setjmp/longjmp changes the process signal mask on OS X

Wow, sometimes it really makes sense to read apparently unrelated email-threads on Friday afternoon:) It seems that AIX/HPUX have exactly the same problem like MacOS X. >From the AIX setjmp man-page: "The setjmp and longjmp subroutines save and restore the signal mask sigmask (2), while _setjmp a

Re: Review request for 8034218: AIX: Provide a better fontconfig.properties file

Hi Jonathan, thanks for submitting this patch. Overall it looks good, but I don't think we should reference the fonts under $JRE_LIB_FONTS/ in the OpenJDK version of fontconfig.properties (at least not until IBM will not also contribute the corresponding fonts :) I would also find it helpful to

Re: RFR(XS): 8042416: X11GraphicsEnvironment.isDisplayLocal() throws NoSuchElementException if DISPLAY host has more IP addresses than a local interface

Thanks Anthony, Volker On Wed, May 7, 2014 at 9:03 PM, Anthony Petrov wrote: > Hi Volker, > > The fix looks fine to me, too. > > -- > best regards, > Anthony > > > On 5/5/2014 10:07 PM, Volker Simonis wrote: >> >> Hi, >> >> could you please

Re: RFR(XS): 8042416: X11GraphicsEnvironment.isDisplayLocal() throws NoSuchElementException if DISPLAY host has more IP addresses than a local interface

webrev itself, but the patch[1] > under jdk.changeset link > has it. > > [1] http://cr.openjdk.java.net/~simonis/webrevs/8042416/jdk.changeset > > > Thanks, > > Alexander. > > On 05/05/2014 10:07 PM, Volker Simonis wrote: >> >> Hi, >> >>

RFR(XS): 8042416: X11GraphicsEnvironment.isDisplayLocal() throws NoSuchElementException if DISPLAY host has more IP addresses than a local interface

Hi, could you please review this tiny fix: http://cr.openjdk.java.net/~simonis/webrevs/8042416/ https://bugs.openjdk.java.net/browse/JDK-8042416 X11GraphicsEnvironment.isDisplayLocal() calls X11GraphicsEnvironment._isDisplayLocal() whihc in turn iterates over all IP addressees of the DISPLAY hos

RFR(XS): 8032578: [TESTBUG] Fix tests which use SecurityConstants.AWT

Hi, could you please review the following trivial test changes: http://cr.openjdk.java.net/~simonis/webrevs/8032578/ for jdk9 which fix the two tests: com/sun/awt/SecurityWarning/CustomSecurityManager.java javax/swing/JPopupMenu/6694823/bug6694823.java They were broken after change "8029886: C

RFR(S): JDK-8031134 : PPC64: implement printing on AIX

Hi, could somebody please review the following small change: http://cr.openjdk.java.net/~simonis/webrevs/8031134/ It's the straight forward implementation of the basic printing infrastructure on AIX and shouldn't have any impact on the existing platforms. As always, this change is intended for t

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

will now call 'aix_close_init()' as suggested by Alan. The changes to src/solaris/native/com/sun/ management/UnixOperatingSystem_md.c are now in src/solaris/native/sun/management/OperatingSystemImpl.c because that file was moved by an upstream change. On Wed, Nov 20, 2013 at 7:26 PM, Volk

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

tps://bugs.openjdk.java.net/browse/JDK-8024900) This change only contains the additional make changes which became necessary after I started to move AIX-specific files into their own jdk/src/aix/ directory. Everything else is already in place. I'll prepare and test a finaly webrev with all t

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

6997010 > > Thanks, > Sean > > On 11/20/2013 01:26 PM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on >> AIX<https://bugs.openjdk.java.net/browse/

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

again, Volker > > Thanks, > > Artem > > On 11/20/2013 10:26 PM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on AIX >> <https://bugs.openjdk.jav

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

e AWT/2D guys. As far as I understood, you've now reviewed the 'core-lib'/'net' parts right? That would mean that I'll still need a review from the AWT/2D and the Security group - any volunteers:). Once again thanks a lot for your help, Volker On Fri, Nov 22, 2

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

/sun/management/OperatingSystemImpl.c. Fortunately, my changes to UnixOperatingSystem_md.c described in the webrev apply cleanly to the new file (I've tested this locally). I'll update the webrev accordingly once I've collected some more feedback. Thank you and best regards, Volker On Wed, Nov 20, 2

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi Alan, thanks a lot for the fast review and your valuable comments. Please find my answers inline: On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman wrote: > On 20/11/2013 18:26, Volker Simonis wrote: > > Hi, > > this is the second review round for "8024854: Basic changes

RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi, this is the second review round for "8024854: Basic changes and files to build the class library on AIX". The previous reviews can be found at the end of this mail in the references section. I've tried to address all the comments and suggestio

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

> That's a good idea. Done. > >> extern int dladdr(void *addr, Dl_info *info); // use the HotSpot >> implementation from libjvm.so > > Did you ever get an opinion on this from the libraries or hotspot teams ? > No, I didn't got any opinions on that topic. I&#

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

ibjvm will always be loaded at the point in AWT where it is used. Another solution would be to re-implement the functionality in the class library and I don't like code duplication either. > -phil. > > > > > On 9/16/2013 12:30 PM, Volker Simonis wrote: > >> Resending thi

RFR(L): 8024854: Basic changes and files to build the class library on AIX

://wiki.openjdk.java.net/display/PPCAIXPort http://openjdk.java.net/jeps/175 Please send reviews to all currently included recipients. Thank you and best regards, Volker -- Forwarded message -- From: *Volker Simonis* Date: Monday, September 16, 2013 Subject: RFR(L): 8024854: Basic changes

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

? If someone else (hotspot, core-libs) already assented > to this > then I guess I could too but I'd like to hear for sure that hotspot and > core-libs > teams both agree to this approach and whether there is an alternative. > > -phil. > > > On 9/19/13 4:29 AM,