Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v9]

On Mon, 2 Aug 2021 09:00:14 GMT, Artem Semenov wrote: >> 8267385: Create NSAccessibilityElement implementation for >> JavaComponentAccessibility >> This pull request contains solutions for the following tickets: >> * JDK-8267385 Create NSAccessibilityElement implementation for >> JavaComponent

[13] Review Request: 8225118 Robot.createScreenCapture() returns black image on HiDPI linux with gtk3

Hi All! Please review the fix for JDK 13: Bug: https://bugs.openjdk.java.net/browse/JDK-8225118 Fix: http://cr.openjdk.java.net/~ant/JDK-8225118/webrev.0 The problem with Robot.createScreenCapture() on gtk3 is in the following function call (quoting from gtk3_interface.h): fp_gdk_pixbuf_get_from

Re: [11] Review request for 8202084: [win] IME candidate window wrong position

Reviewed on swing-dev: http://mail.openjdk.java.net/pipermail/swing-dev/2018-April/008574.html On 4/20/2018 6:51 PM, Anton Tarasov wrote: Hello! Could you please review the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8202084 webrev: http://cr.openjdk.java.net/~ant/JDK-8202084/webrev

Re: [11] Review request for 8202084: [win] IME candidate window wrong position

. -- Kevin [1] http://mail.openjdk.java.net/pipermail/swing-dev/2018-March/008462.html On 4/20/2018 9:28 AM, Anton Tarasov wrote: Hi Kevin, Thanks for pointing (I didn't find it). Closed it as duplicate. Regards, Anton. On 4/20/2018 7:19 PM, Kevin Rushforth wrote: I think the first of

Re: [11] Review request for 8202084: [win] IME candidate window wrong position

as a duplicate if so? Thanks. -- Kevin On 4/20/2018 8:51 AM, Anton Tarasov wrote: Hello! Could you please review the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8202084 webrev: http://cr.openjdk.java.net/~ant/JDK-8202084/webrev.0 There are two problems: 1) IME candidate window x/y i

[11] Review request for 8202084: [win] IME candidate window wrong position

Hello! Could you please review the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8202084 webrev: http://cr.openjdk.java.net/~ant/JDK-8202084/webrev.0 There are two problems: 1) IME candidate window x/y is not scaled. 2) The ancestor window for IME is not the current window when it's "a si

Re: [9] Request for review: JDK-8140525 AwtFrame::WmShowWindow() may steal focus

Hi Sergey, On 11/23/2016 4:57 PM, Sergey Bylokhov wrote: Hi, Anton. On 23.11.16 13:08, Anton Tarasov wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8140525 webrev: http://cr.openjdk.java.net/~ant/JDK-8140525/webrev.0 Please find the description in the bug. This comment explains the fix

[9] Request for review: JDK-8140525 AwtFrame::WmShowWindow() may steal focus

Hello, Please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8140525 webrev: http://cr.openjdk.java.net/~ant/JDK-8140525/webrev.0 Please find the description in the bug. This comment explains the fix: https://bugs.openjdk.java.net/browse/JDK-8140525?focusedCommentId=13865151&pag

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

Hi all, The changes look fine to me. On 4/26/2016 3:49 PM, Philip Race wrote: > In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able to *specify* the cause as proposed by this change.

Re: Review request for 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent

But it returns an array which is an object and you don’t have the original unboxing issue. Anton. > On 27 Sep 2016, at 15:57, Pete Brunet wrote: > > Anton, It looks like you need to also update getInitialAttributeStates. > -Pete > > On 9/16/16 12:49 PM, Anton Tarasov wrot

Re: [8u/9] Review request 8156116 : [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Hi Sergey, Sure, I’ll send a request. Anton. > On 19 Sep 2016, at 22:51, Sergey Bylokhov wrote: > > Hi, Anton. > Should we backport it to jdk8u? > > On 20.05.16 12:12, Anton Tarasov wrote: >> Thank you! >> >> Anton. >> >>> On 18 M

Re: Review request for 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent

On 9/16/2016 1:32 PM, Sergey Bylokhov wrote: On 15.09.16 14:48, Anton Tarasov wrote: Yes, and my suggestion was to use the new method and default values everywhere instead of invokeAndWait(Callable,Component). But the default value for a reference would be null, there's no need to re

Re: Review request for 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent

On 9/15/2016 1:50 PM, Sergey Bylokhov wrote: On 15.09.16 13:38, Anton Tarasov wrote: The difference is that getAccessibleParent may return "null" to native which is expected and handled, whereas getAccessibleIndexInParent may throw NPE which is unexpected and not handled. The prob

Re: Review request for 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent

ll return null? Probably the old invokeAndWait(Callable,Component) should be updated to use this def value? The new invokeAndWait returns _requested_ default value which seems better in general. Anton. On 15.09.16 12:45, Anton Tarasov wrote: Hello, Please review the fix: bug: https://bugs.o

Re: Review request for 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent

On 9/15/2016 12:45 PM, Anton Tarasov wrote: Hello, Please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8165829 webrev: http://cr.openjdk.java.net/~ant/JDK-8165829/jdk9/webrev.0 <http://cr.openjdk.java.net/%7Eant/JDK-8165829/jdk9/webrev.0> (The bug is currently clo

Review request for 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent

Hello, Please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8165829 webrev: http://cr.openjdk.java.net/~ant/JDK-8165829/jdk9/webrev.0 (The bug is currently closed as “

Re: [9] Review Request: 8165717 Various memory leaks in jdk9

Hi Sergey, The fix looks correct to me. On 9/14/2016 6:35 PM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. Note that I plan to backport it to jdk8: That would be really good, thanks! Regards, Anton. NSApplicationAWT class have a special method which posts event to

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

On 9/5/2016 8:11 PM, Sergey Bylokhov wrote: On 01.09.16 17:22, Anton Tarasov wrote: but both frames are still visible. This is why I wonder, how did you close it in the app. You probably missed the fact the dialog is modal. O_o, correct. No more comments from me. Looks fine. Thanks for the

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

Hi Sergey, On 9/1/2016 5:22 PM, Anton Tarasov wrote: On 01 Sep 2016, at 14:31, Sergey Bylokhov wrote: On 01.09.16 12:51, Anton Tarasov wrote: On 31 Aug 2016, at 21:04, Sergey Bylokhov wrote: On 30.08.16 18:18, Anton Tarasov wrote: As I wrote in JIRA, the problem is caused by the fact that

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

On 01 Sep 2016, at 14:31, Sergey Bylokhov wrote: > > On 01.09.16 12:51, Anton Tarasov wrote: >> On 31 Aug 2016, at 21:04, Sergey Bylokhov wrote: >>> >>> On 30.08.16 18:18, Anton Tarasov wrote: >>>>>> As I wrote in JIRA, the problem is caused by t

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

On 31 Aug 2016, at 21:04, Sergey Bylokhov wrote: > > On 30.08.16 18:18, Anton Tarasov wrote: >>>> As I wrote in JIRA, the problem is caused by the fact that a native >>>> window (for a modal dialog) is shown before the peer starts to show. >>>> (This

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

On 8/30/2016 7:05 PM, Semyon Sadetsky wrote: On 8/30/2016 6:18 PM, Anton Tarasov wrote: Hi Semyon, On 8/29/2016 9:08 PM, Semyon Sadetsky wrote: On 8/29/2016 8:29 PM, Anton Tarasov wrote: Hi Semyon, As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

Hi Semyon, On 8/29/2016 9:08 PM, Semyon Sadetsky wrote: On 8/29/2016 8:29 PM, Anton Tarasov wrote: Hi Semyon, As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal dialog) is shown before the peer starts to show. (This seems strange, and you can

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

at 19:30, Semyon Sadetsky wrote: > > Hi Anton, > > is it really OS X only problem? It seems on other platforms the peer > focusability is updated in the same way. > > --Semyon > > > On 6/29/2016 9:04 PM, Anton Tarasov wrote: >> Hello, >>

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

cusableWindowState() from the > initializeImpl()? initializeImpl() is a place where we init the peer before > make it visible, but after constructor of the peer was called. > > On 29.06.16 21:04, Anton Tarasov wrote: >> Hello, >> >> Please review the fix: >

Review request for 8160570: [mac] modal dialog can skip the activation/focus events

Hello, Please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8160570 webrev: http://cr.openjdk.java.net/~ant/JDK-8160570/webrev.0 The problem is that a modal dialog can skip the activation/focus events on OSX. The fix is to c

Re: CFV: New AWT Group Lead: Sergey Bylokhov

Vote: YES > On 10 Jun 2016, at 18:39, Artem Ananiev wrote: > > Hi, AWT team, > > I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to AWT Group Lead > [1]. > > Sergey is a member of Java Client group at Oracle. He has been one of the > most active contributors to AWT (and other J

Re: [8u/9] Review request 8156116 : [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Thank you! Anton. > On 18 May 2016, at 18:54, Alexander Zvegintsev > wrote: > > Looks fine to me too. > > Thanks, > > Alexander. > > On 05/17/2016 06:36 PM, Anton Tarasov wrote: >> Would anyone else please review the fix? >> >> Thanks >&g

Re: [8u/9] Review request: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Would anyone else please review the fix? Thanks Anton. On 5/5/2016 12:45 PM, Sergey Bylokhov wrote: Looks fine. On 05.05.16 10:50, Anton Tarasov wrote: Hello, Please, review a simple fix: webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk9/webrev.0 bug: https://bugs.openjdk.java.net

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

dk.java.net/browse/JDK-8156116> Regards, Anton. >> >> -phil. >> >> On 5/4/16, 7:08 AM, Sergey Bylokhov wrote: >>> On 04.05.16 16:07, Anton Tarasov wrote: >>>> Hi Sergey, >>>> >>>> As you fixed the surface leak separately (thanks!)

[8u/9] Review request: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Hello, Please, review a simple fix: webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk9/webrev.0 bug: https://bugs.openjdk.java.net/browse/JDK-8156116 Thanks, Anton.

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

> On 04 May 2016, at 17:08, Sergey Bylokhov wrote: > > On 04.05.16 16:07, Anton Tarasov wrote: >> Hi Sergey, >> >> As you fixed the surface leak separately (thanks!) should I create a >> dedicated CR for the unrelated JNI ones? > > Can you please clari

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

Hi Sergey, As you fixed the surface leak separately (thanks!) should I create a dedicated CR for the unrelated JNI ones? Regards Anton. > On 29 Apr 2016, at 18:19, Sergey Bylokhov wrote: > > On 29.04.16 18:01, Anton Tarasov wrote: >> [CC’ing to 2d-dev to discuss the issue] &g

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

about nullifying it in invalidate()? Will we face the same synchronisation issue? Anton. > > On 29.04.16 15:00, Anton Tarasov wrote: >> Hi Sergey, Alexander, >> >> Please review the fix: >> >> bug: JDK-8028486 [TEST_BUG] [macosx] >> java/awt/Window/Window

[8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

Hi Sergey, Alexander, Please review the fix: bug: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails webrev: http://cr.openjdk.java.net/~ant/JDK-8028486/webrev.0 I’m copying my comment from CR: Please open the attached screenshot [*], made with YourKit, where a

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

> On 13.04.16 19:52, Anton Tarasov wrote: >> Hi Sergey, >> >> update: http://cr.openjdk.java.net/~ant/JDK-8145984/jdk8u/webrev.3 >> >> >>> On 12 Apr 2016, at 15:49, Sergey Bylokhov >> <mailto:sergey.bylok...@oracle.com>> wrote: &

Re: [9] Review request for 8080729: [macosx] java 7 and 8 JDialogs on multiscreen jump to parent frame on focus

l concept to process parent-child relationship. Ok, got it, sounds reasonable to me. > > On 28/04/2016 17:08, Anton Tarasov wrote: >> Ok, thanks for the explanation. My assumption about putting "main/key” >> window to the floating level was wrong. >> >> Can you p

Re: [9] Review request for 8080729: [macosx] java 7 and 8 JDialogs on multiscreen jump to parent frame on focus

net/~dmarkov/8080729/webrev.02/> > Summary of change: > - Renamed orderChilds() and iconifyChilds() to orderChildWindows() and > iconifyChildWindows() accordingly > - Added some comments to orderChildWindows() Ok, looks fine to me. Regards Anton. > > Thanks, > Dmitry >

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

o jdk9 and wait at least one build before back-porting > to jdk8. > > On 13.04.16 19:52, Anton Tarasov wrote: >> Hi Sergey, >> >> update: http://cr.openjdk.java.net/~ant/JDK-8145984/jdk8u/webrev.3 >> >> >>> On 12 Apr 2016, at 15:49, Sergey Bylo

Re: [9] Review request for 8080729: [macosx] java 7 and 8 JDialogs on multiscreen jump to parent frame on focus

t; http://cr.openjdk.java.net/~dmarkov/8080729/webrev.01/ > > Thanks, > Dmitry > On 27/04/2016 13:46, Anton Tarasov wrote: >> Hi Dmitry, >> >> The fix looks fine to me, still I have some concern... >> >> Say, we have windows with the following relationshi

Re: [9] Review request for 8080729: [macosx] java 7 and 8 JDialogs on multiscreen jump to parent frame on focus

Hi Dmitry, The fix looks fine to me, still I have some concern... Say, we have windows with the following relationship: A<-B<-C (owner<-child). Then the ordering is executed for A: - We’ve got a sequence: A, B, C. - A is skipped, B is ordered above A, C is ordered above A Am I right that C wil

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

leaks, but still it can leak as well). Thanks, Anton. > On 22 Dec 2015, at 17:10, Anton Tarasov wrote: > > Hi guys! > > Could you please review the problem I’ve filed and the suggested fix? > > bug: JDK-8145984 <https://bugs.openjdk.java.net/browse/JDK-8145984> >

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

Hi Sergey, update: http://cr.openjdk.java.net/~ant/JDK-8145984/jdk8u/webrev.3 <http://cr.openjdk.java.net/~ant/JDK-8145984/jdk8u/webrev.3> > On 12 Apr 2016, at 15:49, Sergey Bylokhov wrote: > > Hi, Anton. > On 10.01.16 13:12, Anton Tarasov wrote: >> >> http:

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

did you change CAccessible.dispose() from protected to public? > Shouldn't it be left protected? -Pete I did that due to introducing an interface with dispose() method. But with the latest fix, there’s no that change anymore. Regards, Anton. > > On 12/22/15 3:45 PM, Anton Tarasov wrote:

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

e (in the chain on the java side) from reclamation. > > On 30/12/15 19:25, Anton Tarasov wrote: >> Well, I tried that. However, there’re problems. >> >> 1) Java accessible objects are strongly referenced from the native code. >> This will prevent those objects from en

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

w Year! =) Anton. > > On 23/12/15 10:59, Anton Tarasov wrote: >> Sure, I would also appreciate if someone could apply the fix and do a >> sanity check on your side. >> >> (Yes, I’m aware that Android Studio team is working extensively on a11y >> support.

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

hanges as I am not > very familiar with that code (but am starting to because I'm looking into > fixing some accessibility issues raised by the Andriod Studio team). -Pete > > On 12/22/15 3:45 PM, Anton Tarasov wrote: >> Hi Pete, >> >> Thanks for the

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

ed? If you mean to call AC.dispose() than - yes, I think so. We rather don’t want to dispose the context until the Component goes out of the UI hierarchy, which is when Component.removeNotify() is _always_ getting called (for hw & lw components). Anton. > > Pete > > On 12/2

[9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

Hi guys! Could you please review the problem I’ve filed and the suggested fix? bug: JDK-8145984 sun.lwawt.macosx.CAccessible leaks webrev: http://cr.openjdk.java.net/~ant/JDK-8145984/jdk9/webrev.0 (This is to be addressed in 8u/9. The webrev fo

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

So, it looks fine to me now. Thanks. Anton. On 20/05/15 17:12, Semyon Sadetsky wrote: Hi Anton, http://cr.openjdk.java.net/~ssadetsky/8003399/webrev.02/ I have added the macro you requested. --Semyon On 5/20/2015 3:34 PM, Anton V. Tarasov wrote: Hi Semyon, I'm fine with it, but don't you w

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

. On 3/20/2015 1:34 AM, Anton Tarasov wrote: On 19/03/15 16:19, Alexander Scherbatiy wrote: On 3/19/2015 2:03 PM, Anton V. Tarasov wrote: Hi Alexander, Sergey, I can't say exactly if this is ok to init AWT from that point, but even if it is, this seems to introduce new risks. At the same

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

On 19/03/15 16:19, Alexander Scherbatiy wrote: On 3/19/2015 2:03 PM, Anton V. Tarasov wrote: Hi Alexander, Sergey, I can't say exactly if this is ok to init AWT from that point, but even if it is, this seems to introduce new risks. At the same time, AFAICS, the root of the original focus prob

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

My first assumption was that we can get rid of the peer parameter at all (like you did in DropTarget.java), however this doesn't seem possible regardless of JFX/interop (AFAICS). On 18/03/15 19:23, Sergey Bylokhov wrote: Hi, Anton. The problem is that this method is called when the peer itself

Re: [OpenJDK 2D-Dev] [9] Review Request: 8074028 Remove API references to java.awt.peer

Thanks for the check, Kevin! Anton. On 06/03/15 02:13, Kevin Rushforth wrote: I verified that this doesn't break JavaFX Swing interop (specifically Drag and Drop), so it looks fine to me. -- Kevin Sergey Bylokhov wrote: The new version of the fix: http://cr.openjdk.java.net/~serb/8074028/w

Re: [9] Review Request: 8074028 Remove API references to java.awt.peer

Hi Sergey, Looks good to me. Thanks, Anton. On 04/03/15 15:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPeer() @deprecated 1.1 public java.awt.Font.ge

Re: Review Request for 8065709: Deadlock in awt/logging apparently introduced by 8019623

On 19/01/15 19:15, mikhail cherkasov wrote: On 1/19/2015 5:59 PM, Anton V. Tarasov wrote: Hi Mikhail, It seems the problem is not limited to EventQueue only. Even if you solve it for EventQueue, the EventQueue ctor may cause a chain of calls where some other AWT class is first accessed and i

Re: [9] Review Request: 8056214 Stop including libjawt in libawt_xawt

Hi Sergey, This looks reasonable to me. Regards Anton. On 29/12/14 15:22, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. libjawt was removed from the libawt_xawt. See bug report for additional information. Bug: https://bugs.openjdk.java.net/browse/JDK-8056214 Webrev can be f

hg: jdk8/awt/jdk: 8027157: [SwingNode] needs explicit expose for JWindow

Changeset: 55cab2211ae9 Author:ant Date: 2013-10-29 16:35 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/55cab2211ae9 8027157: [SwingNode] needs explicit expose for JWindow Reviewed-by: art, anthony ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/cla

Re: [8] Review request for CR 7161320 TEST_BUG: java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java fails (Invalid key code)

(Sorry, I was away on J1) I'm personnaly not against expanding the test to the platfroms where META is supported. I'm Ok with sun.awt.OSInfo.getOSType() as well. Thanks, Anton. On 24.09.2013 16:32, Anthony Petrov wrote: Perhaps we should filter out the Windows platform then, and let the test

hg: jdk8/awt/jdk: 8024839: [Unified Swing/Fx threading] don't schedule an event dispatching from the event dispatch thread

Changeset: 4899f6734a14 Author:ant Date: 2013-09-18 12:25 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4899f6734a14 8024839: [Unified Swing/Fx threading] don't schedule an event dispatching from the event dispatch thread Reviewed-by: anthony, pchelko ! src/share/classes/

hg: jdk8/awt/jdk: 8022512: JLightweightFrame: the content pane should be transparent

Changeset: 8f5b4e7623cf Author:ant Date: 2013-09-16 18:00 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8f5b4e7623cf 8022512: JLightweightFrame: the content pane should be transparent Reviewed-by: anthony ! src/share/classes/sun/swing/JLightweightFrame.java

Re: [8] Review Request: JDK-8024779 [macosx] SwingNode crashes on exit

Looks fine to me! Thanks, Anton. On 9/13/2013 4:06 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8024779 (Might not be on bugs.sun.com yet) The fix is available at: http://cr.openjdk.java.net/~pchelko/8024779/webr

Re: [8] Review Request for JDK-8024170, [SwingNode] Implement cursor change

Hi Petr, Great! At least, you no longer need to kick the awt cursor machinery =) Thanks! Anton. On 9/12/2013 4:58 PM, Petr Pchelko wrote: Hello, AWT Team. Please disregard the previous version of the fix. We've decided to change the approach completely. The new version of the JDK part is ava

hg: jdk8/awt/jdk: 8013611: Modal dialog fails to obtain keyboard focus

Changeset: 903a279f1fce Author:ant Date: 2013-08-09 05:20 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/903a279f1fce 8013611: Modal dialog fails to obtain keyboard focus Reviewed-by: leonidr ! src/share/classes/java/awt/KeyboardFocusManager.java + test/java/awt/Focus/80136

hg: jdk8/awt/jdk: 8020927: JLightweightFrame API should export layout properties change notifications

Changeset: 1e482f58c747 Author:ant Date: 2013-07-30 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1e482f58c747 8020927: JLightweightFrame API should export layout properties change notifications Reviewed-by: anthony ! src/share/classes/sun/swing/JLightweightFrame.ja

hg: jdk8/awt/jdk: 8014821: Regression: Focus issues with Oracle WebCenter Capture applet

Changeset: d57fa4e45100 Author:ant Date: 2013-06-14 16:38 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d57fa4e45100 8014821: Regression: Focus issues with Oracle WebCenter Capture applet Reviewed-by: leonidr ! src/windows/native/sun/windows/awt_Frame.cpp

hg: jdk8/awt/jdk: 8015454: java/awt/Focus/TypeAhead/TestFocusFreeze.java hangs with jdk8 since b56

Changeset: 33fc8a062f90 Author:ant Date: 2013-06-12 16:18 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/33fc8a062f90 8015454: java/awt/Focus/TypeAhead/TestFocusFreeze.java hangs with jdk8 since b56 Reviewed-by: anthony ! src/share/classes/java/awt/DefaultKeyboardFocusManag

hg: jdk8/awt/jdk: 8015339: Correct a wording in javadoc of java.awt.ContainerOrderFocusTraversalPolicy

Changeset: a4af3d10d19e Author:ant Date: 2013-06-05 17:44 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a4af3d10d19e 8015339: Correct a wording in javadoc of java.awt.ContainerOrderFocusTraversalPolicy Reviewed-by: art, anthony ! src/share/classes/java/awt/ContainerOrderF

hg: jdk8/awt/jdk: 8015589: Test java/awt/Window/Grab/GrabTest.java fails on MacOSX

Changeset: 481476e941fd Author:ant Date: 2013-05-31 15:56 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/481476e941fd 8015589: Test java/awt/Window/Grab/GrabTest.java fails on MacOSX Reviewed-by: anthony ! test/java/awt/Window/Grab/GrabTest.java

hg: jdk8/awt/jdk: 8013773: requestFocusInWindow to a disabled component prevents window of getting focused

Changeset: 56512cfccef9 Author:ant Date: 2013-05-30 18:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/56512cfccef9 8013773: requestFocusInWindow to a disabled component prevents window of getting focused Reviewed-by: leonidr, alexsch ! src/share/classes/java/awt/Default

hg: jdk8/awt/jdk: 8013424: Regression: java.awt.datatransfer.FlavorListeners not notified on Linux/Java 7

Changeset: 8472c148688c Author:ant Date: 2013-05-30 18:23 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8472c148688c 8013424: Regression: java.awt.datatransfer.FlavorListeners not notified on Linux/Java 7 Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XClipboard.j

hg: jdk8/awt/jdk: 8013437: Test sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails to compile since 8b86

Changeset: e8cacde33d27 Author:ant Date: 2013-05-24 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e8cacde33d27 8013437: Test sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails to compile since 8b86 Reviewed-by: alexsch ! test/sun/awt/datatransfer/Sup

hg: jdk8/awt/jdk: 8014227: JLightweightFrame needs another synchronization policy

Changeset: 722ee3129ce0 Author:ant Date: 2013-05-15 16:49 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/722ee3129ce0 8014227: JLightweightFrame needs another synchronization policy Reviewed-by: art ! src/share/classes/sun/swing/JLightweightFrame.java

Re: [8] Review request for CR 8011186 [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8

Thanks! Anton. On 4/23/2013 7:43 PM, Konstantin Shefov wrote: Oh, of course http://cr.openjdk.java.net/~kshefov/8011186/webrev.01/ On 23-Apr-13 19:39, Anthony Petrov wrote: You should also rename the class itself: 40 public class O

hg: jdk8/awt/jdk: 7147075: JTextField doesn't get focus or loses focus forever

Changeset: dcdf8cd4b09e Author:ant Date: 2013-04-15 13:02 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dcdf8cd4b09e 7147075: JTextField doesn't get focus or loses focus forever Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java

hg: jdk8/awt/jdk: 8010375: sun.swing.JLightweightFrame should be implemented for XToolkit

Changeset: 29570523b6cb Author:ant Date: 2013-03-29 16:12 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/29570523b6cb 8010375: sun.swing.JLightweightFrame should be implemented for XToolkit Reviewed-by: anthony ! src/share/classes/sun/swing/JLightweightFrame.java ! src/sola

hg: jdk8/awt/jdk: 8006406: lightweight embedding in other Java UI toolkits

Changeset: 73d1efc4710a Author:ant Date: 2013-02-22 15:13 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/73d1efc4710a 8006406: lightweight embedding in other Java UI toolkits Reviewed-by: serb, anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java + src/macosx/cl

hg: jdk8/awt/jdk: 6981400: Tabbing between textfield do not work properly when ALT+TAB; ...

Changeset: 0e007aa6f9db Author:ant Date: 2012-08-31 16:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0e007aa6f9db 6981400: Tabbing between textfield do not work properly when ALT+TAB 7157015: [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swi

hg: jdk8/awt/jdk: 7171776: one more setGlobalCurrentFocusCycleRoot call requires doPrivileged

Changeset: 4b2b963f8774 Author:ant Date: 2012-05-25 20:57 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b2b963f8774 7171776: one more setGlobalCurrentFocusCycleRoot call requires doPrivileged Reviewed-by: art ! src/share/classes/java/awt/KeyboardFocusManager.java

hg: jdk8/awt/jdk: 7170427: setGlobalCurrentFocusCycleRoot unexpectedly throws SecurityException

Changeset: 967b38bfd5c1 Author:ant Date: 2012-05-22 01:12 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/967b38bfd5c1 7170427: setGlobalCurrentFocusCycleRoot unexpectedly throws SecurityException Reviewed-by: art ! src/share/classes/java/awt/Component.java ! src/share/class

hg: jdk8/awt/jdk: 7145827: [macosx] JCK failure in b11: FocusableWindow3

Changeset: 1d75ff45586e Author:ant Date: 2012-05-17 22:21 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1d75ff45586e 7145827: [macosx] JCK failure in b11: FocusableWindow3 Summary: forward posrt from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWWindowPeer.java

hg: jdk8/awt/jdk: 7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

Changeset: 5976b5848554 Author:ant Date: 2012-05-17 22:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5976b5848554 7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest Summary: forward port from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/L

hg: jdk8/awt/jdk: 7125044: [macosx] Test failure because Component.transferFocus() works differently in applet and application.

Changeset: ef77fa799b34 Author:ant Date: 2012-05-17 21:48 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ef77fa799b34 7125044: [macosx] Test failure because Component.transferFocus() works differently in applet and application. Summary: forward port from 7u4 Reviewed-by: ar

hg: jdk8/awt/jdk: 7154072: [macosx] swallowing key events

Changeset: 17c5e1a12965 Author:ant Date: 2012-05-17 21:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/17c5e1a12965 7154072: [macosx] swallowing key events Summary: forward posrt from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m

hg: jdk8/awt/jdk: 7142565: [macosx] Many special keys processed twice in text fields

Changeset: c00d6508afce Author:ant Date: 2012-05-17 21:27 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c00d6508afce 7142565: [macosx] Many special keys processed twice in text fields Summary: forward port from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m

hg: jdk8/awt/jdk: 7110683: Issues with some KeyboardFocusManager method

Changeset: 69301efaac91 Author:ant Date: 2012-05-12 18:50 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/69301efaac91 7110683: Issues with some KeyboardFocusManager method Reviewed-by: ahgross ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/DefaultK

Re: Proposal for consolidation of KeyboardFocusManagerPeer

Hi Roman, The peer methods you mentioned contain the following comment: // TODO: consider moving it to KeyboardFocusManagerPeerImpl So, it would be fine to do it. Thanks, Anton. On 11/15/2011 1:35 AM, Roman Kennke wrote: Hi there, One thing that's bugging me for a while is how the Component

Re: CFV: New AWT Group Member: Sergey Bylokhov

Vote: YES On 10/26/2011 3:41 PM, Artem Ananiev wrote: I hereby nominate Sergey Bylokhov to Membership in the AWT Group. Sergey has fixed a number of AWT bugs in JDK7u and JDK8 projects and been actively contributing to the AWT part of the Mac OS X OpenJDK port. Votes are due by November 10,

hg: jdk7/awt/jdk: 6886678: Clicking on parent JFrame's client area does not switch focus from JWindow to JFrame on Windows

Changeset: d21c9804c512 Author:ant Date: 2010-09-27 17:38 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d21c9804c512 6886678: Clicking on parent JFrame's client area does not switch focus from JWindow to JFrame on Windows Reviewed-by: dcherepanov, art ! src/windows/native

hg: jdk7/awt/jdk: 6505819: Provide traverseIn method for sun.awt.EmbeddedFrame

Changeset: d32203d5a47c Author:ant Date: 2010-09-27 16:11 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d32203d5a47c 6505819: Provide traverseIn method for sun.awt.EmbeddedFrame Reviewed-by: dcherepanov, art ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/shar

hg: jdk7/awt/jdk: 6867293: switching TAB in a browser doesn't deactivate EmbeddedFrame

Changeset: c12a03da538b Author:ant Date: 2010-09-03 11:08 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/c12a03da538b 6867293: switching TAB in a browser doesn't deactivate EmbeddedFrame Reviewed-by: dcherepanov, art ! src/windows/native/sun/windows/awt_Window.h

hg: jdk7/awt/jdk: 6903890: SWT_AWT focus issues when a dialog is shown/disposed, on X11

Changeset: 384659657472 Author:ant Date: 2009-12-07 16:38 +0300 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/384659657472 6903890: SWT_AWT focus issues when a dialog is shown/disposed, on X11 Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.jav

hg: jdk7/awt/jdk: 6903354: deadlock involving Component.show & SunToolkit.getImageFromHash

Changeset: 44f04b551d8f Author:ant Date: 2009-12-04 15:07 +0300 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/44f04b551d8f 6903354: deadlock involving Component.show & SunToolkit.getImageFromHash Reviewed-by: art, bae ! src/share/classes/sun/awt/SunToolkit.java

hg: jdk7/awt/jdk: 6566375: PIT : test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html

Changeset: 35d43184687d Author:ant Date: 2009-12-02 17:26 +0300 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/35d43184687d 6566375: PIT : test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html Reviewed-by: art, dcherepanov ! test/java/awt/KeyboardFocusmanager/Typ

hg: jdk7/awt/jdk: 6855713: jdk7: debug build failure in awt_Frame.cpp

Changeset: 2df0d81c4201 Author:ant Date: 2009-06-30 12:55 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2df0d81c4201 6855713: jdk7: debug build failure in awt_Frame.cpp Reviewed-by: dcherepanov, yan ! src/windows/native/sun/windows/awt_Frame.cpp

hg: jdk7/awt/jdk: 6821291: assertion failure in awt_Frame.h

Changeset: e279dd2c5a2c Author:ant Date: 2009-06-23 15:53 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e279dd2c5a2c 6821291: assertion failure in awt_Frame.h Reviewed-by: dcherepanov, art ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_

hg: jdk7/awt/jdk: 4788402: SortingFocusTraversalPolicy: prob with non-focusable focus Cycle Root as first

Changeset: 49e7d22262a9 Author:ant Date: 2009-06-18 11:28 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/49e7d22262a9 4788402: SortingFocusTraversalPolicy: prob with non-focusable focus Cycle Root as first Reviewed-by: dcherepanov ! src/share/classes/java/awt/ContainerOrde

hg: jdk7/awt/jdk: 6833019: KeyboardFocusManager.getCurrentKeyboardFocusManager() throws unspecified HeadlessException

Changeset: 97ece6b3d84f Author:ant Date: 2009-05-21 15:04 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/97ece6b3d84f 6833019: KeyboardFocusManager.getCurrentKeyboardFocusManager() throws unspecified HeadlessException Reviewed-by: art ! src/share/classes/sun/awt/HeadlessTo

hg: jdk7/awt/jdk: 6815946: regression: failed to build MToolkit

Changeset: 04b368454df3 Author:ant Date: 2009-03-11 16:11 +0300 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/04b368454df3 6815946: regression: failed to build MToolkit Reviewed-by: anthony ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/motif/MToolkit

hg: jdk7/awt/jdk: 6806217: implement synthetic focus model for MS Windows

Changeset: 4dc625187820 Author:ant Date: 2009-03-10 18:33 +0300 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/4dc625187820 6806217: implement synthetic focus model for MS Windows Reviewed-by: art, dcherepanov ! make/sun/awt/make.depend ! src/share/classes/java/awt/Component.java

  1   2   >