[9, 8] Review request for 8081485: EDT auto shutdown is broken in case of new event queue usage

Hello Artem, Sergey thanks for your help with the issue investigation! could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8081485/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8081

Re: [9] Review request for 8080504: [macosx] SunToolkit.realSync() may hang

conform to this statement in the documentation of ST.realSync()? @param timeout the maximum time to wait in milliseconds,*negative means "forever"*. But I am not sure that all our implementations works in case of negative timeout. On 23.06.15 20:31, Anton Nashatyrev wrote: Hello,

[9] Review request for 8080504: [macosx] SunToolkit.realSync() may hang

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8080504/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8080504 Problem: under MacOS X the realSync() may hang under some ci

Re: Approved: Re: [9] Review request for RFE-8074882: Support 'replacement range' feature in the Input Method API

the replaceStart/replaceEnd will contain correct range and another will be -1? Plus since this is an RFE, which adds a new functionality, I suggest to write a new tests for it. On 12.04.15 13:57, Alexander Zuev wrote: Looks fine to me. /Alex On 10 Apr 2015, at 15:12, Anton Nashatyrev

Re: [9] Review request for 8041470: JButtons stay pressed after they have lost focus if you use the mouse wheel

/webrev.02/ <http://cr.openjdk.java.net/%7Eanashaty/8041470/webrev.02/> Thanks! Anton. On 28.05.2015 16:17, Alexander Zvegintsev wrote: the fix looks good to me. Thanks, Alexander. On 05/28/2015 03:32 PM, Anton Nashatyrev wrote: Hello Alexander, On 27.05.2015 23:04, Alexander Zvegintsev

Re: [9] Review request for 8041470: JButtons stay pressed after they have lost focus if you use the mouse wheel

/ <http://cr.openjdk.java.net/%7Eanashaty/8041470/webrev.01/> Thanks for review! Anton. -- Thanks, Alexander. On 05/27/2015 07:37 PM, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8041470/webrev.00/

[9] Review request for 8041470: JButtons stay pressed after they have lost focus if you use the mouse wheel

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8041470/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8041470 Problem: m

Re: [9] Review request for 8078606: Deadlock in awt clipboard

Hello, any volunteers? Thanks! Anton. On 08.05.2015 19:08, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8078606/webrev.00/ <http://cr.openjdk.java.net/%7Eanashaty/8078606/webrev.00/> bug:

Re: Approved: Re: [9] Review request for RFE-8074882: Support 'replacement range' feature in the Input Method API

Привет, Сергей можешь глянуть этот фикс плиз? Спасибо! Антон. On 12.04.2015 13:57, Alexander Zuev wrote: Looks fine to me. /Alex On 10 Apr 2015, at 15:12, Anton Nashatyrev mailto:anton.nashaty...@oracle.com>> wrote: Hello, any volunteers to review? Thanks! Anto

Re: [9] Review request for 8068886: IDEA IntelliJ crashes in objc_msgSend when an accessibility tool is enabled

l our code follow this rule. On 08.05.15 19:52, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8068886/webrev.00/ <http://cr.openjdk.java.net/%7Eanashaty/8068886/webrev.00/> bug: https://bugs.openjdk.java.net/br

Re: [9] Review request for 8068886: IDEA IntelliJ crashes in objc_msgSend when an accessibility tool is enabled

documentation of loops, CFRetainedResource, etc should be updated. Also please confirm that all our code follow this rule. On 08.05.15 19:52, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8068886/webrev.00/ <http://

[9] Review request for 8068886: IDEA IntelliJ crashes in objc_msgSend when an accessibility tool is enabled

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8068886/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8068886 Problem: t

[9] Review request for 8078606: Deadlock in awt clipboard

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8078606/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8078606 Problem: XClipboard sometimes deadlocked Reason: XClipbo

Re: [9] Review request for 8078165: [macosx] NPE when attempting to get image from toolkit

e: Hi, Anton. It seems both methods can be simplified because both already have such checks? On 22.04.15 22:12, Anton Nashatyrev wrote: Hello, could you please review the following simple fix: fix: http://cr.openjdk.java.net/~anashaty/8078165/webrev.00/ <http://cr.openjdk.java.net/%7

[9] Review request for 8078165: [macosx] NPE when attempting to get image from toolkit

Hello, could you please review the following simple fix: fix: http://cr.openjdk.java.net/~anashaty/8078165/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8078165 Problem: on MacOS Toolkit.getImage() throws NPE under

[9] Review request for RFE-8074882: Support 'replacement range' feature in the Input Method API

Hello, could you please review the following IM API extension proposal: fix: http://cr.openjdk.java.net/~anashaty/8074882/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8074882 Problem: Press-and-hold Mac IM (whe

Re: [9] Review request for 8074481: [macosx] Menu items are appearing on top of other windows

Hello the second reviewer still wanted. Thanks! Anton. On 19.03.2015 14:11, Anton V. Tarasov wrote: Ok, great! Thanks, Anton. On 19.03.2015 14:09, Anton Nashatyrev wrote: Hi Anton, thanks for review! I've run all [closed/]java/awt/Focus tests: no regressions were

Re: [9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

it). If yes then it seems that the previous fix(8010925) for this bug can be reworked in pure java using checkPasteboardWithoutNotification? 26.03.15 17:29, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8071668/9/webrev

[9] Review request for 8071668: [macosx] Clipboard does not work with 3rd parties Clipboard Managers

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8071668/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8071668 Problem: On Mac Java doesn't see external clipboard chang

Re: [9] Review request for 8074481: [macosx] Menu items are appearing on top of other windows

2015 20:55, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8074481/9/webrev.00/ <http://cr.openjdk.java.net/%7Eanashaty/8074481/9/webrev.00/> bug: https://bugs.openjdk.java.net/browse/JDK-8074481 Problem: applet p

[9] Review request for 8074481: [macosx] Menu items are appearing on top of other windows

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8074481/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8074481 Problem: applet popup windows are not closed when other n

[9] Review request for 8073008: press-and-hold input method for accented characters works incorrectly on OS X

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8073008/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8073008 Problem: any IM with a lookup window on Mac works incorre

Re: [9] Review request for 8072069: Toolkit.getScreenInsets() doesn't update if insets change

Hi Sergey, thanks for comments and for help! It turned out that the NSApplicationDidChangeScreenParametersNotification is not fired on Dock size change so the only remaining way is query insets natively each time. Here is the new version (the initial fix + comments): http://cr.openj

Re: [9] Review request for 8072069: Toolkit.getScreenInsets() doesn't update if insets change

Hi Sergey, No I didn't try it yet, but it looks like NSApplicationDidChangeScreenParametersNotification has no means to distinguish between display resolution change, attaching new display or insets changes. This way

Re: [9] Review request for 8072069: Toolkit.getScreenInsets() doesn't update if insets change

eference/ApplicationKit/Classes/NSApplication_Class/#//apple_ref/c/data/NSApplicationDidChangeScreenParametersNotification Thanks, Alexander. On 02/13/2015 03:06 PM, Anton Nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8072069/

[9] Review request for 8072069: Toolkit.getScreenInsets() doesn't update if insets change

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8072069/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8072069 Problem: Toolkit.getScreenInsets() returns old value aft

Re: [9] Review request for 8068283: Mac OS Incompatibility between JDK 6 and 8 regarding input method handling

Anton. > > P.S. Sorry, I've already pushed the fix before receiving your comment > > On 20.01.2015 20:09, Sergey Bylokhov wrote: > > As this bug became so critical I suggest to test all supported l&f in the test. > > On 20.01.2015 18:42, Anton Nashatyrev

Re: [9] Review request for 8068283: Mac OS Incompatibility between JDK 6 and 8 regarding input method handling

l available JDK LaFs in this concrete fix. Thanks! Anton. P.S. Sorry, I've already pushed the fix before receiving your comment On 20.01.2015 20:09, Sergey Bylokhov wrote: As this bug became so critical I suggest to test all supported l&f in the test. On 20.01.2015 18:42, Anton

[9] Review request for 8068283: Mac OS Incompatibility between JDK 6 and 8 regarding input method handling

Hello Alexander, Anton could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8068283/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8068283 Problem: No ways for keyboard shortcuts

Re: The input method handling

Hi Sergey, here is corresponding JBS issue for your problem: https://bugs.openjdk.java.net/browse/JDK-8068283 I've made some initial evaluation there. Regards, Anton. On 10.12.2014 20:56, Sergey Malenkov wrote: Hi all, In Oracle JDK the input method handling is slightly different fr

[8-backport] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

/ Thanks! Anton. On 24.09.2014 18:15, Andrew Brygin wrote: Hello Anton, the fix looks fine to me. Thanks, Andrew On 9/24/2014 1:51 PM, anton nashatyrev wrote: Sergey, thanks for review! Any other volunteer? On 19.09.2014 17:27, Sergey Bylokhov wrote: Hi, Anton. Then the fix looks good, thanks

Re: [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

Sergey, thanks for review! Any other volunteer? On 19.09.2014 17:27, Sergey Bylokhov wrote: Hi, Anton. Then the fix looks good, thanks for clarification. On 19.09.2014 17:25, anton nashatyrev wrote: We don't treat the 'text/plain; class=java.lang.Object&#x

Re: [9] Review request for 8056914: Right Click Menu for Paste not showing after upgrading to java 7

Hello, could please anyone review? Thanks! Anton. On 16.09.2014 13:17, anton nashatyrev wrote: Hello, the friendly reminder... Thanks! Anton. On 09.09.2014 19:48, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net

Re: [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

ode text/unknown; class=java.lang.Object text/plain; class=java.lang.Object; charset=unicode text/plain; class=java.lang.Object On 19.09.2014 15:58, anton nashatyrev wrote: Hi Sergey, On 18.09.2014 17:30, Sergey Bylokhov wrote: - Can you try to change sort TimSort algorithm to mergerSort. W

Re: [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

lated regression and jck tests. Executed all 'datatransfer' regression and JCK tests - no regressions detected. Thanks. On 18.09.2014 17:04, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8058473/9/we

[9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8058473/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8058473 Problem: DataFlavorComparator violates Comparator contrac

Re: [9] Review request for 8056914: Right Click Menu for Paste not showing after upgrading to java 7

Hello, the friendly reminder... Thanks! Anton. On 09.09.2014 19:48, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8056914/9/webrev.00/ <http://cr.openjdk.java.net/%7Eanashaty/8056914/9/webrev.00/> bug:

[9] Review request for 8056914: Right Click Menu for Paste not showing after upgrading to java 7

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8056914/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8056914 Problem: After moving AwtTextField from EDIT to RICHEDIT

[8] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8046495 Thank you! Anton. On 24.07.2014 18:10, Artem Ananiev wrote: On 7/18/2014 2:28 PM, anton nashatyrev wrote: Hello, in offline discussion with Artem and Petr we decided to further clean up the code and completely remove

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

ttp://cr.openjdk.java.net/%7Eanashaty/8046495/9/webrev.01/> bug: https://bugs.openjdk.java.net/browse/JDK-8046495 Thank you! Anton. On 17.07.2014 13:14, anton nashatyrev wrote: Hello All, could please anyone else take a look at the fix? Thanks! Anton. On 02.07.2014 19:37, Petr Pchelko wrote:

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

mailto:anton.tara...@oracle.com>> wrote: On 02.07.2014 19:28, anton nashatyrev wrote: Hello, Anton On 02.07.2014 18:13, Anton V. Tarasov wrote: On 02.07.2014 11:44, Petr Pchelko wrote: Hello, Anton. I'm not sure I have a detailed understanding of what's happening. Before your f

[7] Review request for 6993873: java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java test indicates ".a frame wasn't focused on click" jdk7 issue on linux

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/6993873/7/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6993873 This i

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

rrent time and using it when sending the event? Wouldn't that resolve both your issue and the issue the original fix was made for? I have a couple of comments about the code, but let's postpone that until we decide on the approach. Thank you. With best regards. Petr. On 01 июля 2014 г.

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

for? I have a couple of comments about the code, but let's postpone that until we decide on the approach. Thank you. With best regards. Petr. On 01 июля 2014 г., at 21:20, anton nashatyrev mailto:anton.nashaty...@oracle.com>> wrote: Hello, could you please review the follow

[9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8046495/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8046495 *Problem:*

Re: [9] Review request for 8032788: ImageIcon constructor throws an NPE and hangs when passed a null String parameter

Hello, any volunteers to review please? The fix is pretty simple. http://cr.openjdk.java.net/%7Eanashaty/8032788/9/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8032788 Thanks! Anton. On 22.05.2014 22:29, anton nashatyrev wrote: Hello, could you please review the following fix

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

hen pressing '[', 'o' on FR keyboard: before the fix: 'ôô' after the fix: 'oô' I suppose that both cases are not correct (in the first we get duplicated character). Hope to talk to you offline on how to handle both problems. Thanks! Anton. On 23.05.2014 20:1

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

#x27;D') we are getting Ctrl+d.) Go we still need this workaround after your fix? With best regards. Petr. On May 23, 2014, at 7:35 PM, anton nashatyrev wrote: Hello Petr, yes, I've run java/awt/event/KeyEvent tests from both open/closed parts: there were a number of fails on a

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

aracter). Hope to talk to you offline on how to handle both problems. Thanks! Anton. On 23.05.2014 20:14, Anthony Petrov wrote: On 5/23/2014 8:04 PM, anton nashatyrev wrote: could you please point me to the i18n tests you have mentioned? test/java/awt/im ...? In both open and closed re

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

K with the fix then. However, I also suggest to run some i18n tests and also try some non-English keyboard layouts (DE, FR, JP, etc.) with special characters and dead keys to ensure they aren't broken. -- best regards, Anthony On 5/23/2014 7:39 PM, anton nashatyrev wrote: Anthony,

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Ctrl+d.) Go we still need this workaround after your fix? With best regards. Petr. On May 23, 2014, at 7:35 PM, anton nashatyrev wrote: Hello Petr, yes, I've run java/awt/event/KeyEvent tests from both open/closed parts: there were a number of fails on a clean build, but no new fails

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

ee [1] for a related FX bug) [1] https://javafx-jira.kenai.com/browse/RT-16616 -- best regards, Anthony On 5/23/2014 7:14 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8028617/9/webrev.00/ <http://cr.openjdk.

Re: [9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

be we could right a regression test for this one? From your evaluation I have an impression that Ctrl+Key combination is now broken in normal layout too? Is this correct? Thank you. With best regards. Petr. On May 23, 2014, at 7:14 PM, anton nashatyrev wrote: Hello, could you please review

[9] Review request for 8028617: Dvorak keyboard mapping not honored when ctrl key pressed

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8028617/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8028617 Problem: Dvorak keyboard mapping not honored when Ctrl ke

[9] Review request for 8032788: ImageIcon constructor throws an NPE and hangs when passed a null String parameter

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8032788/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8032788 Problem: MediaTracker.waitForID() hangs if the Image was

Re: [8] Review request for 8024061: Exception thrown when drag and drop between two components is executed quickly

es, so it would be either initialized on the first doProcessEvent call or if the second call occurs it might be rewritten with the same value (if dnd is still not started). Thanks! Anton. -- best regards, Anthony On 10/14/2013 06:26 PM, anton nashatyrev wrote: Hi Artem, with the fix th

Re: [8] Review request for 8024061: Exception thrown when drag and drop between two components is executed quickly

ooks incompatible, I can't predict side effects of such a change. Fixing step 3, so we don't assume drag entered events already sent, looks more correct. What do you think? Thanks, Artem On 10/11/2013 7:49 PM, anton nashatyrev wrote: Hello, could you please review the followi

[8] Review request for 8024061: Exception thrown when drag and drop between two components is executed quickly

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~mcherkas/anton/8024061/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8024061 Problem: when doing quick drag'n'drop in X11 the

[8] Review request for 8025145: MacOSX: java 7 does not recognize tiff image on clipboard

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~vkarnauk/8025145/jdk8/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8025145 Problem: it looks like the TIFF format is popular i