Integrated: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

2021-08-16 Thread rajat mahajan
On Fri, 13 Aug 2021 19:23:21 GMT, rajat mahajan wrote: > Removed try catch block so the test can function as expected and fail > when it ought to, rather than passing all the time because of catch > block catching all exceptions and Passing test even there is a failure. This pull re

Re: RFR: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions [v4]

2021-08-16 Thread rajat mahajan
> Removed try catch block so the test can function as expected and fail > when it ought to, rather than passing all the time because of catch > block catching all exceptions and Passing test even there is a failure. rajat mahajan has updated the pull request incrementally with one a

Re: RFR: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions [v3]

2021-08-16 Thread rajat mahajan
> Removed try catch block so the test can function as expected and fail > when it ought to, rather than passing all the time because of catch > block catching all exceptions and Passing test even there is a failure. rajat mahajan has updated the pull request incrementally with one a

Re: RFR: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions [v2]

2021-08-13 Thread rajat mahajan
> Removed try catch block so the test can function as expected and fail > when it ought to, rather than passing all the time because of catch > block catching all exceptions and Passing test even there is a failure. rajat mahajan has updated the pull request incrementally with one a

Re: RFR: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions [v2]

2021-08-13 Thread rajat mahajan
On Fri, 13 Aug 2021 19:38:12 GMT, Alexey Ivanov wrote: >> rajat mahajan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix IDE warnings, added Default Locale as US, fixed Copyright to include >> curre

RFR: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

2021-08-13 Thread rajat mahajan
Removed try catch block so the test can function as expected and fail when it ought to, rather than passing all the time because of catch block catching all exceptions and Passing test even there is a failure. - Commit messages: - 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDia

Integrated: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-08-05 Thread rajat mahajan
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan wrote: > Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on > all OS. Added synchronization for focusCnt. This pull request has now been integrated. Changeset: cb368802 Author: Rajat Mahajan Committer: Alexey

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-04 Thread rajat mahajan
On Wed, 4 Aug 2021 14:35:34 GMT, Alexey Ivanov wrote: >> I still think nx, ny should be made CAPS...It seems to be the case for >> static final constant variables in java/awt test folder...I don't think it >> will increase noise as it will impact only in l57 > > It will affect more lines; these

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-04 Thread rajat mahajan
> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on > all OS. Added synchronization for focusCnt. rajat mahajan has updated the pull request incrementally with one additional commit since the last revision: make variables with static final modifier CAPS,

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-08-03 Thread rajat mahajan
On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan wrote: >> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on >> all OS. Added synchronization for focusCnt. > > test/jdk/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.ja

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-07-30 Thread rajat mahajan
On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan wrote: >> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on >> all OS. Added synchronization for focusCnt. > > test/jdk/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.ja

RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-07-29 Thread rajat mahajan
Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on all OS. Added synchronization for focusCnt. - Commit messages: - 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS Changes: https://git.openjdk.java.net/jdk/pu

Clarification regarding PageFormat and Paper getImageable* functions orientation consideration

2021-03-22 Thread Rajat Mahajan
Hi all, Issue: I am working on https://bugs.openjdk.java.net/browse/JDK-8203395 and this bug is about "PageFormat showing wrong printer margins in LANDSCAPE orientation" . Application code it trying to print in Landscape and Portrait but both show same margins: Margins default : 12,12,17,17