Re: [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-19 Thread Dmitry Markov
Phil, As it was pointed out by Sean the fallback code was redundant. It just invoked the same checkPermission() method and didn’t perform any specific checks. It is very unlikely that the removal of the fallback code will cause some test failures. However I ran the corresponding AWT and Swing r

Re: [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Sean Mullan
This looks good to me. The JDK SecurityManager implementation of checkRead and checkConnect have both been changed to call checkPermission since JDK 1.2 so the fallback code is redundant. --Sean On 12/18/17 11:47 AM, Dmitry Markov wrote: Hello, Could you review a fix for jdk10, please?  bu

Re: [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Phil Race
Dmitry, Did you confirm that there are no tests that check for this removed behaviour ? -phil. On 12/18/2017 10:01 AM, Sergey Bylokhov wrote: Looks fine. On 18/12/2017 08:47, Dmitry Markov wrote: Hello, Could you review a fix for jdk10, please? bug: https://bugs.openjdk.java.net/browse

Re: [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Sergey Bylokhov
Looks fine. On 18/12/2017 08:47, Dmitry Markov wrote: Hello, Could you review a fix for jdk10, please?  bug: https://bugs.openjdk.java.net/browse/JDK-8193435  webrev: http://cr.openjdk.java.net/~dmarkov/8193435/webrev.00/  CSR: https://bugs.openjdk.java.net/browse/JDK-8193709 Problem descr

[10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Dmitry Markov
Hello, Could you review a fix for jdk10, please? bug: https://bugs.openjdk.java.net/browse/JDK-8193435 webrev: http://cr.openjdk.java.net/~dmarkov/8193435/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8193709 Problem descrip