Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Looks fine for me as well. Thanks, Krishna Date: Tue, 6 Mar 2018 15:25:04 -0800 From: Sergey Bylokhov To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Looks fine, please make this test a macosx specific before the push( @requires tag) On 06/03/2018 04:59, Manajit Halder wrote: Hi Sergey, Thank you for the review comment. Modified the test case as per your comment. Created issue https://bugs.openjdk.java.net/browse/JDK-8199116 for the bug f

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Hi Sergey, Thank you for the review comment. Modified the test case as per your comment. Created issue https://bugs.openjdk.java.net/browse/JDK-8199116 for the bug found by you. Please review the webev: http://cr.openjdk.java.net/~mhalder/819076

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Hi, Manajit. On 26/02/2018 05:45, Manajit Halder wrote: Changed the fix as per Sergey’s review comment. Now both Frame and Dialog are checked for resizibility before setting canFullScreen to true. Please review the modified webrev: http://cr.openjdk.java.net/~mhalder/8190767/webrev.03/ There a

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Hi Sergey, Phil and Kevin, Thank you all for your review comments. Changed the fix as per Sergey’s review comment. Now both Frame and Dialog are checked for resizibility before setting canFullScreen to true. Please review the modified webrev: http://cr.openjdk.java.net/~mhalder/8190767/webrev.03

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Correcting the JDK version to be reviewed for to JDK 11. > On 29-Jan-2018, at 6:09 PM, Manajit Halder wrote: > > Hi All, > > Kindly review the fix for JDK11. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8190767 > > > Webrev: > http